From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#39274: Warn when using obsolete command interactively Date: Sat, 25 Jan 2020 20:18:01 +0100 Message-ID: <87sgk38hw6.fsf@marxist.se> References: <878slw8mj4.fsf@marxist.se> <837e1gq8pt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="64144"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39274@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 25 20:19:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ivQxb-000Gdb-1T for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 20:19:11 +0100 Original-Received: from localhost ([::1]:56800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivQxa-0004tA-6O for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 14:19:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39207) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivQxT-0004sr-Fu for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:19:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivQxS-0003ZZ-ID for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50359) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivQxS-0003Yr-En for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivQxS-0002gD-9q for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jan 2020 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39274 X-GNU-PR-Package: emacs Original-Received: via spool by 39274-submit@debbugs.gnu.org id=B39274.157997989110242 (code B ref 39274); Sat, 25 Jan 2020 19:19:02 +0000 Original-Received: (at 39274) by debbugs.gnu.org; 25 Jan 2020 19:18:11 +0000 Original-Received: from localhost ([127.0.0.1]:56332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivQwd-0002f7-Ft for submit@debbugs.gnu.org; Sat, 25 Jan 2020 14:18:11 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:53640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivQwb-0002eu-Ty for 39274@debbugs.gnu.org; Sat, 25 Jan 2020 14:18:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AvHpGCnIcBHotD72Hk+k/H1z8I2qJfqskhpcPCMioy0=; b=tHTolmuVMUpIZpLMhPJ4bM3T8l C3EJHhiuyGE6v8+f1/oQxqgUOilEDVg9zNNIGUECfCP6rQ6nFlEXvFAjGCj8XtapqZJ+NCnr9ckVr 7KtYP1cdMTBJNNBXK1fI2mcLIZxzbaTwIZz/JNHCctJwj6rvsmZ/QVUkPbrroz1qORqfrMtGXhu5T 5FtaOnBBMBJsvyeViHfUymo7jYs4sP+k8CVtgNYIa2twxNH6I7c+V1pSTDrdJD2Q7kViQJi+pekoD SK1b9jMUL2Cb5eo/eyjb/wcE/ohaJXQKZcso3oD38F+V9XNVGDqm/OSYL6+1GZ+z5Ky7SFUoUKiZ/ aOLhYS6w==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:45546 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ivQwW-0016UT-5Z; Sat, 25 Jan 2020 14:18:04 -0500 In-Reply-To: <837e1gq8pt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jan 2020 09:46:38 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175278 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Please add a warning along these lines: >> >> (message "The `%s' command is obsolete since version %s, use `%s' instead" >> obsolete-name version current-name) > > Where and when will this warning be displayed? I was thinking of something along the lines of the below patch. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=obsolete.diff diff --git a/lisp/simple.el b/lisp/simple.el index 8be27745b1..12a413ec0e 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1914,6 +1914,12 @@ execute-extended-command (while-no-input (setq binding (execute-extended-command--shorter (symbol-name function) typed)))) + (when-let (obsolete (with-temp-buffer + (when (help-fns--obsolete 'foo) + (buffer-string) + (goto-char (point-max)) + (delete-indentation 2)))) + (message obsolete)) (when binding (with-temp-message (format-message "You can run the command `%s' with %s" --=-=-=--