* bug#39515: 28.0.50; [not found] ` <handler.s.R.158161568811442.transcript@debbugs.gnu.org> @ 2020-02-13 18:06 ` Deus Max 2020-02-13 19:14 ` Eric Abrahamsen 0 siblings, 1 reply; 4+ messages in thread From: Deus Max @ 2020-02-13 18:06 UTC (permalink / raw) To: Jose A. Ortega Ruiz; +Cc: 39515, Eric Abrahamsen On Mon, 10 Feb 2020, "Jose A. Ortega Ruiz" wrote: > At any rate, if this is the expected behaviour, one should probably > update the manual, which doesn't mention this. That contributes to the > surprise, at least in my case. The gnus-group-make-nnir-group (GG) function documentation clearly states the expected behavior: ... if called from the *Group* buffer search any marked groups, or the group on the current line, or all the groups under the current ^^^^^^^^^^^^^^^ topic. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#39515: 28.0.50; 2020-02-13 18:06 ` bug#39515: 28.0.50; Deus Max @ 2020-02-13 19:14 ` Eric Abrahamsen 2020-02-14 15:00 ` Jose A. Ortega Ruiz 0 siblings, 1 reply; 4+ messages in thread From: Eric Abrahamsen @ 2020-02-13 19:14 UTC (permalink / raw) To: Deus Max; +Cc: Jose A. Ortega Ruiz, 39515 [-- Attachment #1: Type: text/plain, Size: 794 bytes --] On 02/13/20 20:06 PM, Deus Max wrote: > On Mon, 10 Feb 2020, "Jose A. Ortega Ruiz" wrote: > >> At any rate, if this is the expected behaviour, one should probably >> update the manual, which doesn't mention this. That contributes to the >> surprise, at least in my case. > > The gnus-group-make-nnir-group (GG) function documentation clearly > states the expected behavior: > > ... if called from the *Group* buffer search any marked groups, or > the group on the current line, or all the groups under the current > ^^^^^^^^^^^^^^^ > topic. Good enough for me! This patch should allow us to search all groups, visible or not, and recursive groups under sub-topics. A quick test shows it works for me -- anyone else want to try it out first? [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: gnus-search-topic-groups.diff --] [-- Type: text/x-patch, Size: 534 bytes --] diff --git a/lisp/gnus/nnir.el b/lisp/gnus/nnir.el index 0f364d66e1..0277524a8c 100644 --- a/lisp/gnus/nnir.el +++ b/lisp/gnus/nnir.el @@ -617,7 +617,8 @@ gnus-group-make-nnir-group (list (gnus-group-group-name)) (mapcar (lambda (entry) (gnus-info-group (cadr entry))) - (gnus-topic-find-groups (gnus-group-topic-name))))) + (gnus-topic-find-groups (gnus-group-topic-name) + nil t nil t)))) gnus-group-server)))) (query-spec (or (cdr (assq 'nnir-query-spec specs)) ^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#39515: 28.0.50; 2020-02-13 19:14 ` Eric Abrahamsen @ 2020-02-14 15:00 ` Jose A. Ortega Ruiz 2020-02-14 19:59 ` Eric Abrahamsen 0 siblings, 1 reply; 4+ messages in thread From: Jose A. Ortega Ruiz @ 2020-02-14 15:00 UTC (permalink / raw) To: Eric Abrahamsen; +Cc: 39515, Deus Max On Thu, Feb 13 2020, Eric Abrahamsen wrote: [...] > Good enough for me! This patch should allow us to search all groups, > visible or not, and recursive groups under sub-topics. A quick test > shows it works for me -- anyone else want to try it out first? it's working fine for me too. thanks both! ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#39515: 28.0.50; 2020-02-14 15:00 ` Jose A. Ortega Ruiz @ 2020-02-14 19:59 ` Eric Abrahamsen 0 siblings, 0 replies; 4+ messages in thread From: Eric Abrahamsen @ 2020-02-14 19:59 UTC (permalink / raw) To: Jose A. Ortega Ruiz; +Cc: 39515-done, Deus Max On 02/14/20 15:00 PM, Jose A. Ortega Ruiz wrote: > On Thu, Feb 13 2020, Eric Abrahamsen wrote: > > [...] > >> Good enough for me! This patch should allow us to search all groups, >> visible or not, and recursive groups under sub-topics. A quick test >> shows it works for me -- anyone else want to try it out first? > > it's working fine for me too. thanks both! Away we go! Closing the bug. Thanks, Eric ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-14 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87wo8ql70m.fsf@aia00054aia.gr>
[not found] ` <handler.s.R.158161568811442.transcript@debbugs.gnu.org>
2020-02-13 18:06 ` bug#39515: 28.0.50; Deus Max
2020-02-13 19:14 ` Eric Abrahamsen
2020-02-14 15:00 ` Jose A. Ortega Ruiz
2020-02-14 19:59 ` Eric Abrahamsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).