From: "Štěpán Němec" <stepnem@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 40335@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#40335: 27.0.90; elp-not-profilable not up to date
Date: Mon, 13 Apr 2020 17:31:57 +0200 [thread overview]
Message-ID: <87sgh79zbm.fsf@gmail.com> (raw)
In-Reply-To: <85sgh7zar6.fsf@gmail.com> (Noam Postavsky's message of "Mon, 13 Apr 2020 11:05:49 -0400")
On Mon, 13 Apr 2020 11:05:49 -0400
Noam Postavsky wrote:
> Štěpán Němec <stepnem@gmail.com> writes:
>
>> All the others can be removed AFAICT, and none of `eq', `get', `aref' or
>> `time-subtract', also called by the wrapper lambdas
>> (`elp--make-wrapper'), seemed to cause issues for me.
>>
>> IIUC advice has no effect for calls from C functions to C functions, but
>> I don't understand what makes e.g. `float-time' (which breaks) different
>> from `aref' or `get' (which apparently don't) in that respect.
>
> The obvious difference between `float-time' and `aref' or `get' is that
> the latter have byte code ops (so advice doesn't work on byte-compiled
> calls to them).
Ah! That makes sense, thank you.
> However, that doesn't explain why `subtract-time' is
> okay while `float-time' causes problems.
Right, because that was just an error on my part: `time-subtract' does
in fact exhibit the problem. But its alias `subtract-time' doesn't, even
when advised explicitly. I guess advices ignore aliases (i.e. pass
through to the real definition)?
--
Štěpán
next prev parent reply other threads:[~2020-04-13 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 21:25 bug#40335: 27.0.90; elp-not-profilable not up to date Philipp Stephani
2020-04-13 14:52 ` Štěpán Němec
2020-04-13 15:05 ` Noam Postavsky
2020-04-13 15:31 ` Štěpán Němec [this message]
2020-04-13 16:05 ` Noam Postavsky
2020-04-13 16:55 ` Štěpán Němec
2021-09-18 16:44 ` Lars Ingebrigtsen
2021-10-18 8:40 ` Lars Ingebrigtsen
2021-11-12 19:56 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgh79zbm.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=40335@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).