From: Noam Postavsky <npostavs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Alan Mackenzie <acm@muc.de>,
40992@debbugs.gnu.org, Phillip Lord <phillip.lord@russet.org.uk>
Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks
Date: Fri, 01 May 2020 23:05:32 -0400 [thread overview]
Message-ID: <87sggjm3yb.fsf@gmail.com> (raw)
In-Reply-To: <87o8r7xgb8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 02 May 2020 03:43:07 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Alan Mackenzie <acm@muc.de> writes:
>
>> There doesn't appear to be a good way of solving this bug. A workable
>> workaround would be to check that the 'edebug property value is a list
>> in edebug--overlay-breakpoints, and just to remove the breakpoint
>> highlights when it's not a list. When it's not a list, it's a marker
>> pointing to the start of the function, from which the end of the
>> function can be found, to serve as the END argument to
>> edebug--overlay-breakpoints-remove.
>>
>> Or something like that. :-(
>
> I think that sounds like a good solution on master, but the patch that
> introduced this should probably be reverted on emacs-27 -- it wasn't a
> bug fix, but a new feature, so reverting it should be safe, I think.
I don't understand; the fix looks trivial to me (leaving out
indentation), and only touches a new function. Surely this is okay for
emacs-27?
--- i/lisp/emacs-lisp/edebug.el
+++ w/lisp/emacs-lisp/edebug.el
@@ -3236,8 +3236,9 @@ 'edebug-breakpoint
"\x3c\x7e\xff\xff\xff\xff\x7e\x3c")
(defun edebug--overlay-breakpoints (function)
- (let* ((data (get function 'edebug))
- (start (nth 0 data))
+ (let ((data (get function 'edebug)))
+ (when (listp data)
+ (let* ((start (nth 0 data))
(breakpoints (nth 1 data))
(offsets (nth 2 data)))
;; First remove all old breakpoint overlays.
@@ -3264,6 +3265,7 @@ edebug--overlay-breakpoints
(propertize
"x" 'display
`(left-fringe edebug-breakpoint ,face)))))))))
+ ))
(defun edebug--overlay-breakpoints-remove (start end)
(dolist (overlay (overlays-in start end))
next prev parent reply other threads:[~2020-05-02 3:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 8:26 bug#40992: 27.0.90; Evaluating a function while using edebug breaks Phillip Lord
2020-05-01 15:56 ` Alan Mackenzie
2020-05-01 17:33 ` Alan Mackenzie
2020-05-01 18:02 ` Eli Zaretskii
2020-05-02 1:43 ` Lars Ingebrigtsen
2020-05-02 3:05 ` Noam Postavsky [this message]
2020-05-02 7:10 ` Eli Zaretskii
2020-05-02 13:34 ` Alan Mackenzie
2020-05-02 13:57 ` Eli Zaretskii
2020-05-03 11:55 ` Alan Mackenzie
2020-05-03 12:13 ` Alan Mackenzie
2020-05-02 21:54 ` Phillip Lord
2020-05-11 20:16 ` Alan Mackenzie
2020-05-02 13:14 ` Alan Mackenzie
2020-05-04 1:27 ` Pouar Dragon
2020-05-04 18:34 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sggjm3yb.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=40992@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=larsi@gnus.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).