unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 41744@debbugs.gnu.org
Subject: bug#41744: 27.0.91; Various D-Bus cleanups
Date: Mon, 08 Jun 2020 15:00:01 +0100	[thread overview]
Message-ID: <87sgf51wv2.fsf@tcd.ie> (raw)
In-Reply-To: <874krln7fg.fsf@gmx.de> (Michael Albinus's message of "Mon, 08 Jun 2020 13:06:11 +0200")

Michael Albinus <michael.albinus@gmx.de> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> While reading through the D-Bus manual and implementation, I noticed
>> some opportunities for small cleanups.
>
> Thanks a lot for your enourmous work!
>
>> I propose these documentation cleanups for emacs-27:
>
> In general, I agree with your changes.

Thanks for reviewing.

> However, they are so large that I don't know whether they shall go
> into the emacs-27 branch. To be decided by Eli, I guess.

Sure.

>> diff --git a/doc/misc/dbus.texi b/doc/misc/dbus.texi
>
> The changed formatting of the examples exceeds sometimes 80 columns,
> maybe you can adapt the formatting.

None of my changes increase the width of either text or examples.  The
only example touched by the patch which already exceeds 80 columns is
this:

@lisp
(@var{integer} ((@var{string} @var{bool} @var{bool}) (@var{string} @var{bool} @var{bool}) @dots{}))
@end lisp

But I left it alone because the result is less than 60 columns wide and
looks nice to me:

     (INTEGER ((STRING BOOL BOOL) (STRING BOOL BOOL) ...))

Can you please point out which parts you want reformatted?

>> And these implementation cleanups for master:
>
> This I will review once the first patch set has arrived in master.

Sure, thanks,

-- 
Basil





  reply	other threads:[~2020-06-08 14:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-06 23:26 bug#41744: 27.0.91; Various D-Bus cleanups Basil L. Contovounesios
2020-06-08 11:06 ` Michael Albinus
2020-06-08 14:00   ` Basil L. Contovounesios [this message]
2020-06-08 14:20     ` Michael Albinus
2020-06-08 14:48   ` Eli Zaretskii
2020-06-08 14:52     ` Michael Albinus
2020-06-08 17:28       ` Basil L. Contovounesios
2020-06-17 20:08   ` Basil L. Contovounesios
2020-06-18  9:59     ` Michael Albinus
2020-06-18 15:34       ` Basil L. Contovounesios
2020-06-18 16:59         ` Michael Albinus
2020-06-18 17:05           ` Basil L. Contovounesios
2020-06-18 18:02             ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgf51wv2.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=41744@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).