From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#42237: [PATCH] Clean up Tramp version check Date: Tue, 07 Jul 2020 09:19:00 +0200 Message-ID: <87sge3g5cr.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42237@debbugs.gnu.org To: Nicholas Drozd Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 07 09:23:44 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jshx8-0003Md-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jul 2020 09:23:42 +0200 Original-Received: from localhost ([::1]:45364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshx7-0007f0-4e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jul 2020 03:23:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshta-0001Ii-Tt for bug-gnu-emacs@gnu.org; Tue, 07 Jul 2020 03:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshta-0005dc-KE for bug-gnu-emacs@gnu.org; Tue, 07 Jul 2020 03:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jshta-0008KM-Fd for bug-gnu-emacs@gnu.org; Tue, 07 Jul 2020 03:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jul 2020 07:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159410635031883 (code B ref 42237); Tue, 07 Jul 2020 07:20:02 +0000 Original-Received: (at 42237) by debbugs.gnu.org; 7 Jul 2020 07:19:10 +0000 Original-Received: from localhost ([127.0.0.1]:35412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jshsk-0008IB-Hu for submit@debbugs.gnu.org; Tue, 07 Jul 2020 03:19:10 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:52207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jshsh-0008Hl-Qa for 42237@debbugs.gnu.org; Tue, 07 Jul 2020 03:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594106341; bh=h77axYdSxd6r2A1lqO3uEyl1ah6h7wDMfeEVkFXKOmg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lr83p0TREhc50KPC85hLXyXwodz+Nz5FAHGVlKWUjHpjvYK1sv6pbfCqCPnxaFwDL Y1mJb6g6vlme4h0o+pQhbX0iGbChcXO0gk3f1o5UqAlWx0o91vKUnFk2EIX787zhzq 2ePmp+3PJqoKL7dbJ300xEGprXDQSc3Zjf98Z0EA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.118.167]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N33Ib-1ktrPU0P2D-013PdE; Tue, 07 Jul 2020 09:19:01 +0200 In-Reply-To: (Nicholas Drozd's message of "Mon, 6 Jul 2020 17:19:48 -0500") X-Provags-ID: V03:K1:7pNpqMDCpwIR/wTg7zbYpOJ8eIvuMLEmTSeAeoP5v6mUeZq3l1y miXXcCJzRt2l0alnZtalokvoCWGIiAnyXeqT+nz1LporPySKcptuC2U2H2sw5jq+FOpksLH Q3k2n645lqh6HfcSI6U04W3Hid+F4v37dKEDKDCxmW6siya44OTuoavW6Cy/cDeLBNzWgb0 te1v0QLYK/9dFczLS5Mog== X-UI-Out-Filterresults: notjunk:1;V03:K0:7f4OmduElhM=:r4zWH8XKwVi3hUrCEL2Wxm R0P8P6Qij1E243vWpWmVMi5kLctKpB0ioCSqVJj5n+kiadWwOD5seRGVtkdRI0ElpSQPMoYX7 tMVxci9a7TKbNn2ylxtaipXlGPJ2qHKdR36N0MvEYI9Qa/I9nlIAWrGqY4wiKUeIlozQXRi34 vVcbQxZ12ZawrrMPOJ/I+gceBq/gx/k/OV22aZ3GqvmPZJtwBcHjLK7mOLDqKhRLpvyBNNkWa DsxJ9OOyGP9/AZZS+E8V8X3EqQMCAiYBppLb7xuk6fJAAgDhU0eWT5E1Tj8FuMHLJPqCVPfrV l8JNJ+ICCCT3WhR297IAlMY8C5usumm8qXfKnAA7+ht28NIaloVGNko7MZGjC/DygvyOPtbSM HC8O0WeIWTKZhzqZokWWcnZ+ZaVtVjZ38+icAr+gYtAyWBKoyM/X6nx4VyhzgrI1ZO+g2NkOX CaRNAn6VSup9hUhVa4gOIj6DtUR5synzpR6bb75o/0s0p241dvD29hrhFspU0NS/+vmUI16ys Z5TYdOLoFl4hiC1z0+5Gpehk8PUgiHBEvYtEi+9EDTYC8jlJOi3IeH4SHYJov9SIeJvsE4sU7 Tb4WkCkTwPxLsJufXGY6SJmntz7U186GBayaHYjp2nSvJfXFXNSXtNhsoWykfx5HgwZxE81PV wdRFjPz1/PBHogkKZPUk+TY+OtFKgm4TGWeWtgSmuvFXQsG/WCZ3dR8X0CMstzaczWFadp/PV Rc9UGoJxHPVOQo6XlMfYoBA25m4sNrEbVrOPkkQDKGCWROLdDjd202lZ4xhdZ0SVLrkAz2Jz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182776 Archived-At: Nicholas Drozd writes: Hi Nicholas, Thanks for working on Tramp. > I actually saw the "not fit for" error message in the wild. The source > looked a little strange, so I cleaned it up. This shouldn't change any > behavior. Well, this code snippet has its history. Initially, it was (and still is) used in the Tramp git repository, file aclocal.m4. And that code snippet is also propagated to trampver.el via template trampver.el.in. If you want to improve the code, please change only these two files. The Tramp git repository is located at (see also the Tramp manual). > +(ert-deftest tramp-test46-version () > + "Check that the version check checks out." > + (tramp-check-version) > + (let ((emacs-version "24.3")) > + (should-error (tramp-check-version))) > + (let ((tramp-minimum-emacs-version "30.1")) > + (should-error (tramp-check-version)))) This is a nice extension :-)