unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Andrea Corallo <akrl@sdf.org>
Cc: 40838-done@debbugs.gnu.org
Subject: bug#40838: 28.0.50; [feature/native-comp] Function overrides in init.el are not honored after deferred compilation
Date: Tue, 28 Jul 2020 17:06:03 +0800	[thread overview]
Message-ID: <87sgdcj9fo.fsf@localhost> (raw)
In-Reply-To: <xjf5za8drvc.fsf@sdf.org>

> That said this is an area I plan to fix to have it 100% compatible with
> the vanilla implementaiton once I'm done with moving all the eln file.
Great!

> My understanding was that the issue reported in this bug was not advise
> related but it could be also a side effect of?

Some of the broken functions were "redefined" with :around advice or
using el-patch. Though el-patch is working with function slots directly,
as I understand.

FYI, I do not encounter the original bug as often on the latest master.
What I noticed is that it also tends to happen when I change original
source code of the native-compiled functions and eval-sexp the new
versions. 

Best,
Ihor

Andrea Corallo <akrl@sdf.org> writes:

> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> Reopen.
>>
>> I think I found something related to this bug report in
>> exlplain-pause-mode package. See
>> https://github.com/lastquestion/explain-pause-mode/issues/65 for
>> details.
>>
>> best,
>> Ihor
>
> Hi Ihor,
>
> thanks for the finding.
>
> native-comp does not support advises to (most) primitive functions for
> performance reasons.  The elisp manual strongly discourage this practice
> tho.
>
> The issue can be worked around adding those functions into the
> `comp-never-optimize-functions' customize.
>
> That said this is an area I plan to fix to have it 100% compatible with
> the vanilla implementaiton once I'm done with moving all the eln file.
>
> My understanding was that the issue reported in this bug was not advise
> related but it could be also a side effect of?
>
> Regards
>
>   Andrea
>
> -- 
> akrl@sdf.org

-- 
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg





      reply	other threads:[~2020-07-28  9:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25  8:14 bug#40838: 28.0.50; [feature/native-comp] Function overrides in init.el are not honored after deferred compilation Ihor Radchenko
2020-04-25  9:16 ` Andrea Corallo
2020-04-25 14:26   ` Andrea Corallo
2020-04-26  4:55     ` Ihor Radchenko
2020-04-26  8:59       ` Andrea Corallo
2020-04-28 14:40         ` Ihor Radchenko
2020-04-28 15:03           ` Andrea Corallo
2020-05-18 15:23             ` Ihor Radchenko
2020-05-18 20:15               ` Andrea Corallo
2020-05-18 21:01                 ` Andrea Corallo
2020-05-19  3:06                 ` Ihor Radchenko
2020-05-23 14:13                   ` Ihor Radchenko
2020-05-23 14:39                     ` Andrea Corallo
2020-05-23 15:23                       ` Ihor Radchenko
2020-06-02  7:27                         ` Andrea Corallo
     [not found]                           ` <87zh7ltgc7.fsf@localhost>
2020-07-28  7:24                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-28  9:06                               ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgdcj9fo.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=40838-done@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).