From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.bugs Subject: bug#37871: 27.0.50; Merge feature/gnus-select2 Date: Mon, 07 Sep 2020 06:53:30 +0800 Message-ID: <87sgbubjpx.fsf@ust.hk> References: <87blu8lpu4.fsf@ericabrahamsen.net> <87sgnklkct.fsf@gnus.org> <87pniok558.fsf@ericabrahamsen.net> <87o8y8ljis.fsf@gnus.org> <87d0eok1t7.fsf@ericabrahamsen.net> <87pn8ro6vm.fsf@gnus.org> <874kq2bvun.fsf@ericabrahamsen.net> <87a6y5ggba.fsf@ericabrahamsen.net> <87pn6yudgr.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11396"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: cohen@bu.edu, Eric Abrahamsen , Lars Ingebrigtsen , 37871@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 00:54:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF3Y0-0002qu-NY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 00:54:08 +0200 Original-Received: from localhost ([::1]:58606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF3Xz-0006ME-NB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 18:54:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF3Xu-0006M7-3w for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 18:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF3Xt-0005ge-Q2 for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 18:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF3Xt-0007Sf-Pj for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 18:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Cohen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Sep 2020 22:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37871 X-GNU-PR-Package: emacs Original-Received: via spool by 37871-submit@debbugs.gnu.org id=B37871.159943282428658 (code B ref 37871); Sun, 06 Sep 2020 22:54:01 +0000 Original-Received: (at 37871) by debbugs.gnu.org; 6 Sep 2020 22:53:44 +0000 Original-Received: from localhost ([127.0.0.1]:47376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF3Xc-0007SA-Fa for submit@debbugs.gnu.org; Sun, 06 Sep 2020 18:53:44 -0400 Original-Received: from andy.bu.edu ([128.197.41.152]:42154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF3Xa-0007Rw-Ep for 37871@debbugs.gnu.org; Sun, 06 Sep 2020 18:53:42 -0400 Original-Received: from dy088-153.ust.hk ([143.89.88.153] helo=hanan) by andy.bu.edu with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF3XT-0004BR-PG; Sun, 06 Sep 2020 18:53:36 -0400 In-Reply-To: <87pn6yudgr.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 06 Sep 2020 16:33:40 +0100") X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam_report: Spam detection software, running on the system "andy.bu.edu", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dear Basil >>>>> "BLC" == Basil L Contovounesios writes: [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187398 Archived-At: Dear Basil >>>>> "BLC" =3D=3D Basil L Contovounesios writes: [...] BLC> I already pushed some minor code/doc cleanups to more closely BLC> follow Emacs conventions in: BLC> Fix formatting of recent Gnus nnselect changes d7197f9d99 BLC> 2020-09-06 16:06:57 +0100 BLC> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dd7197f9d9= 9ca6aa326d38e64ca9eb1d13e18d664 Thanks for all this! BLC> But I have some remaining comments. BLC> First, the merge introduced the following build warning: BLC> In end of data: org/ol-gnus.el:271:1: Warning: the function BLC> =E2=80=98nnir-article-group=E2=80=99 is not known to be defined. BLC> Org should probably be updated to use the new names of things. Clearly this needs to be changed. I wasn't expecting this internal function to be used outside of gnus (and it probably shouldn't).=20 BLC> Second, several changes in gnus-msg.el have resulted in BLC> misindented code of the form: Ugh. I spent hours trying to make sure the code was indented properly. I must be doing something wrong. BLC> (unwind-protect (progn (one-single-form)) ;; No unwind forms! BLC> ) I'm sorry I don't see exactly which unwind-protect you are referring to? I don't think I changed any of the several unwind protects in gnus-msg.el. Maybe someone else remembers why they are this way? BLC> If the unwind-protect+progn wrappers are no longer needed, they BLC> should be removed and the code reindented. BLC> More worryingly, some of the changes that let-bind BLC> gnus-newsgroup-name are preceded by the following commentary: BLC> ;; We can't `let' gnus-newsgroup-name here, since that leads BLC> ;; to local variables leaking. BLC> If the leaking is still an issue, then the nnselect changes BLC> should be reconsidered; otherwise these stale comments should BLC> be removed. I believe the leaking was a bug that has been dealt with, so the comments should be removed. However I might have failed to fix it (I have had a variety of people test it, but you never know). BLC> Third, the bodies of gnus-fetch-headers and nnheader-parse-nov BLC> are misindented. (BTW, please respect the setting of BLC> indent-tabs-mode in Emacs' top-level dir-locals-file, and BLC> especially don't use tab characters for aligning comments to BLC> the right of code.) See my above comment :( All settings are at default, so I must be making some other stupid mistake. BLC> Finally, the merge makes several backward-incompatible changes BLC> to user options which should be rectified, lest we break BLC> existing user configurations. The renamed user options BLC> gnus-refer-thread-use-nnir and BLC> nnir-retrieve-headers-override-function should be defined as BLC> obsolete varaliases for their new names BLC> gnus-refer-thread-use-search and BLC> nnselect-retrieve-headers-override-function, respectively. BLC> Also, their :version tags should be bumped to 28.1. The BLC> removed user option nnir-summary-line-format should still be BLC> defined but made obsolete. Right. Thanks for noting these. BLC> Thanks, BLC> -- Basil