From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ozhap Newsgroups: gmane.emacs.bugs Subject: bug#42823: [PATCH] gnus-unplugged: nnimap (gmail) folder names having spaces not appearing Date: Sat, 19 Sep 2020 10:27:04 +0530 Message-ID: <87sgbejrdr.fsf@Kittu.i-did-not-set--mail-host-address--so-tickle-me> References: <87wo23u7hn.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14064"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42823@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 08:39:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJWWd-0003Yd-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 08:39:11 +0200 Original-Received: from localhost ([::1]:53700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJWWc-000157-OD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 02:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJWWU-00014h-BM for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 02:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJWWU-0002NU-2N for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 02:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJWWT-00042Y-WD for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 02:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ozhap Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 06:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42823 X-GNU-PR-Package: emacs Original-Received: via spool by 42823-submit@debbugs.gnu.org id=B42823.160049752515498 (code B ref 42823); Sat, 19 Sep 2020 06:39:01 +0000 Original-Received: (at 42823) by debbugs.gnu.org; 19 Sep 2020 06:38:45 +0000 Original-Received: from localhost ([127.0.0.1]:45549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJWWC-00041o-MH for submit@debbugs.gnu.org; Sat, 19 Sep 2020 02:38:45 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:55121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJUwA-0001Sr-B4 for 42823@debbugs.gnu.org; Sat, 19 Sep 2020 00:57:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600491430; bh=6VCCXSfK7M+jNxEHzveuzaWwGSuvq6cGJFV0NRFKIAI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=CgVTA4PmH0pT12artYZB7ccF2lTI2u9Pac+XiTTND4HvAO4y5Wo23QHlHUo+9tW7a lKDYNL36O+JarF31DMUdRelFNKFUGSrMHl73OWPqoedl3YaxpP3bFmhPyeRhVbr8CX xmXDUZfEwf1CqkWbGfhF68PTlMZT3ieWSZ4EThR8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from localhost ([59.94.230.38]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MwQXH-1kZeCm25Jd-00sMbt; Sat, 19 Sep 2020 06:57:10 +0200 In-Reply-To: <87wo23u7hn.fsf@ericabrahamsen.net> X-Provags-ID: V03:K1:ApNk+3yuzyVNyr0ySNfNr7/CX80fegpUXAk9+pZc9Dwh/7FOhzS momj3WOwOb3rij56NvhL41lyo1Fd8ZLkpX4ijf2iElB0ekgLDLmyB/lsN8ibWGjBht6GNzs hxr58ZSIo6x/udr3HfpXD1xTsxkOoD+AUHq/j8EPQxys/HfUTMmS7HyBUwqbRg5y9xIvEW0 A/N2qHr1NsRg4HQM9tiPw== X-UI-Out-Filterresults: notjunk:1;V03:K0:j07Fn6WTDcM=:ZdDuJfdRUJJP62ZtZOapcG IU/a7pKWdNwOYzzRnVR0P32NdiArThh4A1NTcbU8njtzNKWYFNmUNS2dq5X8o01LZZ8z6+cbo kgDBCklcjXv53ekT9kSIO0jV+snK7U0NUERd0wcReDk70A9pkt6xFazqYMlnFPCZ4d067N0M2 dwIxq3IN7dHm9F2pQ/2q1RetU3tYEikf28vMYUaoc39pkbRz5zPw/SIZ0OuRUDdqJNQJaTtEE fld+dgS3WlKrZrL3ky3D8fGq7lsg1JcecYtgP8pZ38ajTHEG/ZNWhVLI/7UE0arZ3l0A9iu8X 2GVZ/HBd2G1aD0El8wTqY0nGL0gouinopvF9gzxxTBIGDwmK09+g+ySpxvNmOawerq9whHS4i ZcFkdzNAYjE02uq2Wk3V5sA51sngIoQwHNcsFTddfCgl81CdfZLEGuCz8UMxRUc455cHf9rzR Pbigl82imNju7JCf8Zgb/KLuNZDSDPMXUk7AYDNzwOJCQZoI+YQZlbK3F4mMTZeppDzhMrLdh RXss2AyWhV4gkO0MU069VngcEoEuD/4yiTz2KscmAoGli7GpdBVWYf3Uzo23ijhPege01uBAU CPzn6DyT+KNPDFLw0Y3E1enIooS+mXoydUIA1jn7H9I304Xx1rEF/SB1zdzWXlxTjN3g4SsYp MRPaZUSQeska+8iqfAFWREkVlpyvdYEtx7Ap4mLqKj39jVSPImqWL1J3gMT3q6RbsanVoxvq8 0h49H+8Vb7mXVCJ6Sp2H3brPeafXOnXBV+OjKfS15WJ/dGbGtKX6EAjBg6Kfi8JcT0EcmYto X-Mailman-Approved-At: Sat, 19 Sep 2020 02:38:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188364 Archived-At: Eric Abrahamsen writes: > I've only been able to get as far as figuring out that the group is > *not* present in nnml-group-alist, after nnagent has been made the > current server. Presumably that's because the reading of the active file > is still done with `read', which will only read one word, not the full > name, thus the parsing fails and this line is discarded. > > It might be time to get rid of the last of the `read' tricks... I considered that approach, but felt it would always be flawed by space also being a delimiter in the active file. This patch puts quotes around the group names when *writing* the active file of agent & cache (and escapes any \ or " in them). I've been using it and I think it's clean. diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el index 3429d6560b..f822ce57ba 100644 --- a/lisp/gnus/gnus-util.el +++ b/lisp/gnus/gnus-util.el @@ -1179,10 +1179,13 @@ gnus-write-active-file (maphash (lambda (group active) (when active - (insert (format "%s %d %d y\n" - (if full-names - group - (gnus-group-real-name group)) + (insert (format "\"%s\" %d %d y\n" + (replace-regexp-in-string + "[\\\"]" "\\\\\\&" + (if full-names + group + (gnus-group-real-name group)) + t nil) (or (cdr active) (car active)) (car active))))) But I'm not a position to actually test it with nntp, or IMAP folder names with \ or ". -- Ozhap