From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 12:04:34 +0200 Message-ID: <87sgbcrcgd.fsf@gnus.org> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> <83lfh50zxa.fsf@gnu.org> <87eemwss3t.fsf@gnus.org> <834kns22q2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17217"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 12:06:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJwES-0004NH-Ny for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 12:06:08 +0200 Original-Received: from localhost ([::1]:33672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJwER-00028L-Qd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 06:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJwDO-0001RZ-Cy for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 06:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJwDO-0005zT-3C for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 06:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJwDN-0003Ph-V3 for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 06:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 10:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160059628713094 (code B ref 6227); Sun, 20 Sep 2020 10:05:01 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 10:04:47 +0000 Original-Received: from localhost ([127.0.0.1]:48769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJwD9-0003P8-EY for submit@debbugs.gnu.org; Sun, 20 Sep 2020 06:04:47 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJwD6-0003Ot-Gk for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 06:04:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Cgdj9iwE9NSxfDwbgLVIds8rs8NoiwMXK7rH4f0F8Gc=; b=ZHJDJXXRiAj3MMBMeCi5+5OnZ8 FB6q+KrGTlGXsjoUlcnLbIzjsZDGF6fpK/+jymG5nyoBatNSMdvhbCa3KY9TILlc+oBfdDV0WaWYB 9BbK0IbzCfvZhqDff34PJEHNMC60IeH9XRWf7ecSCc5KnsiqD52JhPYM4l/p5kLh6USU=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJwCx-0005zl-TC; Sun, 20 Sep 2020 12:04:38 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEX6+/ng4ti6ubjY zLG7kGaac1YpIxlgV0r////07S+QAAAAAWJLR0QIht6VegAAAAd0SU1FB+QJFAoBMdY45SAAAAGl SURBVDjLrdPNUsIwEADgDZ3xvJs6nqUFvJIGvWuDXB0KclcpTwB9fXeT9AerN3Npp192s002AP8w VHwivxIPpVERIvJbQJ1lWVHYAjVqgS4yjc8lMYGhERjJJwHqJ9wDsADc4o9UoZTErt1zAEWcxfaw 60EGGM7Aa6R2z6CGa0wBMgH3C2jESf4H3NV1/RlBIVBb1bKH5KrcCDACuBmDLxoSa625AsO7nOHg RLqIvGgB5ZBg0kbkL7PtMEIOymdZVfMtosKW/LHK+/zr/SMes9b8QWZLOerheDnydCT5MoSNBxVS hy4JK25OlyPhgn/wZH3uKGpdX47LAL4jOticDucI0PcKw2tzaCK0kwMcDuc9whiCxohRQ8eq4E9Q w/8g34mLumFIMACZlEiaYcrgJIK/pitbljYl08I+Atm5q6yh2D5P3RrKPJY7V6bLcA59uYlzRbWq sghPXblJbt1uXeX+zhD2oMhap99SylDpCH4PuZFm5aoioKmexi1JRZTVbvdYGQGiwV6h7wa55xxB ZtHUzZlCl6DvDP4paXu5ukAE/zi+AbraYd8dfcGFAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTA5 LTIwVDEwOjAxOjQ5KzAwOjAwZfyqiQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0wOS0yMFQxMDow MTo0OSswMDowMBShEjUAAAAASUVORK5CYII= X-Now-Playing: Andrew Poppy's _On Zang Tuum Tumb (3): Under the Son_: "The Passage (parts 1, 2, 3)" In-Reply-To: <834kns22q2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Sep 2020 12:53:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188480 Archived-At: Eli Zaretskii writes: >> I don't see why not. It's just a more detailed visualisation. > > But with slightly different colors. How do we know long-time users of > Isearch will understand what they mean, unless they deliberately turn > on this option? When they're typing "foo\(bar\)" in regexp isearch and see the different colours, I think they'll catch on pretty quickly. >> > Comment #2: This seems to effectively disable the feature on displays >> > that have fewer than 88 colors. Is that intentional? If so, why >> > doesn't the documentation say so? >> >> I'm guessing it's just cargo-culting off of the isearch face: >> >> (defface isearch >> '((((class color) (min-colors 88) (background light)) > > I don't understand: the 'isearch' face has definitions for all kinds > of displays, even for monochrome ones: > > (defface isearch > '((((class color) (min-colors 88) (background light)) > ;; The background must not be too dark, for that means > ;; the character is hard to see when the cursor is there. > (:background "magenta3" :foreground "lightskyblue1")) I meant that these deffaces aren't complete -- they look like examples, and the examples are taken from the isearch face. There should be more of them, and they should be complete, and they should have better names (isearch-group-1 etc perhaps). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no