From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41250: 28.0.50; Dired displays unconditionally ls-switches on modeline Date: Wed, 30 Sep 2020 22:04:51 +0300 Organization: LINKOV.NET Message-ID: <87sgazi550.fsf@mail.linkov.net> References: <87v9ky9p6o.fsf@mail.linkov.net> <654acc31-015d-4552-bd9b-3b8c69661fcd@default> <0957af50-7f85-455a-9d2c-e96451727872@default> <6073a2d5-4024-465d-8293-88ad7f6127ed@default> <87mu172qxb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20385"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41250@debbugs.gnu.org, Arthur Miller To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 21:21:01 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNhev-00059Z-Hb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 21:21:01 +0200 Original-Received: from localhost ([::1]:59776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNhet-0003YT-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 15:20:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNhdz-0002rz-9J for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 15:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNhdy-00046i-S5 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNhdy-0003Ab-Ce for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41250-submit@debbugs.gnu.org id=B41250.160149358412134 (code B ref 41250); Wed, 30 Sep 2020 19:20:02 +0000 Original-Received: (at 41250) by debbugs.gnu.org; 30 Sep 2020 19:19:44 +0000 Original-Received: from localhost ([127.0.0.1]:33162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNhdT-00039E-AV for submit@debbugs.gnu.org; Wed, 30 Sep 2020 15:19:44 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:35187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNhdQ-00038t-Ck for 41250@debbugs.gnu.org; Wed, 30 Sep 2020 15:19:29 -0400 Original-Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 8CAB5200008; Wed, 30 Sep 2020 19:19:21 +0000 (UTC) In-Reply-To: <87mu172qxb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Sep 2020 18:02:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189424 Archived-At: > Drew Adams writes: > >> Sorry. `diredp' should be `dired' everywhere. >> This patch takes care of that typo. > > Looks good to me, so I've now applied your patch to Emacs 28. > > Some bikeshedding ensued, and people should feel free to alter the code > (as-is vs t, for instance). I recall I asked for 't' instead of 'as-is', but actually 'as-is' is fine as a value as long as it is not checked for this value in function body. And indeed it's on the 't' branch of 'cond'. > And I'm not sure about this: > > + (concat " " xs (and (< l2 l1) "…"))))) > > Perhaps that should be conditional upon the terminal being able to > display that character? Like everywhere else (if (char-displayable-p ?…) "…" "...")