From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 41250@debbugs.gnu.org, Arthur Miller <arthur.miller@live.com>
Subject: bug#41250: 28.0.50; Dired displays unconditionally ls-switches on modeline
Date: Wed, 30 Sep 2020 22:04:51 +0300 [thread overview]
Message-ID: <87sgazi550.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mu172qxb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Sep 2020 18:02:56 +0200")
> Drew Adams <drew.adams@oracle.com> writes:
>
>> Sorry. `diredp' should be `dired' everywhere.
>> This patch takes care of that typo.
>
> Looks good to me, so I've now applied your patch to Emacs 28.
>
> Some bikeshedding ensued, and people should feel free to alter the code
> (as-is vs t, for instance).
I recall I asked for 't' instead of 'as-is', but actually 'as-is' is fine
as a value as long as it is not checked for this value in function body.
And indeed it's on the 't' branch of 'cond'.
> And I'm not sure about this:
>
> + (concat " " xs (and (< l2 l1) "…")))))
>
> Perhaps that should be conditional upon the terminal being able to
> display that character?
Like everywhere else (if (char-displayable-p ?…) "…" "...")
next prev parent reply other threads:[~2020-09-30 19:04 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 1:42 bug#41250: 28.0.50; Dired displays unconditionally ls-switches on modeline Arthur Miller
2020-05-14 22:33 ` Juri Linkov
2020-05-14 23:42 ` Drew Adams
2020-05-15 8:44 ` Arthur Miller
2020-05-15 18:55 ` Drew Adams
2020-05-15 19:09 ` Eli Zaretskii
2020-05-15 21:08 ` Arthur Miller
2020-05-15 22:19 ` Drew Adams
2020-05-17 3:09 ` Arthur Miller
2020-05-17 6:59 ` Drew Adams
2020-05-17 11:12 ` Arthur Miller
2020-05-16 6:34 ` Eli Zaretskii
2020-05-16 12:18 ` Arthur Miller
2020-05-17 3:01 ` Arthur Miller
2020-05-17 15:17 ` Eli Zaretskii
2020-05-17 16:34 ` Arthur Miller
2020-05-17 16:42 ` Eli Zaretskii
2020-05-17 22:57 ` Arthur Miller
2020-05-17 23:37 ` Stefan Kangas
2020-05-18 15:08 ` Arthur Miller
2020-05-18 14:25 ` Eli Zaretskii
[not found] ` <<VI1PR06MB4526BAF92DBDCEA6A75D7A0196BD0@VI1PR06MB4526.eurprd06.prod.outlook.com>
[not found] ` <<835zcwv15e.fsf@gnu.org>
2020-05-16 14:42 ` Drew Adams
2020-05-15 19:54 ` Arthur Miller
2020-05-15 22:19 ` Drew Adams
2020-05-15 22:24 ` Drew Adams
2020-09-30 16:02 ` Lars Ingebrigtsen
2020-09-30 19:04 ` Juri Linkov [this message]
2020-09-30 19:30 ` Lars Ingebrigtsen
2020-09-30 19:58 ` Juri Linkov
2020-09-30 19:59 ` Lars Ingebrigtsen
2020-10-01 19:37 ` Juri Linkov
2020-10-01 19:59 ` Lars Ingebrigtsen
2020-10-02 6:31 ` Eli Zaretskii
2020-10-02 14:10 ` Lars Ingebrigtsen
2020-10-02 14:57 ` Eli Zaretskii
2020-10-03 17:36 ` Lars Ingebrigtsen
2020-10-02 6:54 ` Juri Linkov
2020-10-02 14:14 ` Lars Ingebrigtsen
2020-10-02 14:59 ` Eli Zaretskii
2020-10-03 17:38 ` Lars Ingebrigtsen
2020-10-04 19:44 ` Juri Linkov
2020-10-05 7:08 ` Lars Ingebrigtsen
2020-10-05 20:15 ` Juri Linkov
2020-10-06 1:37 ` Lars Ingebrigtsen
2020-10-05 15:49 ` Glenn Morris
2020-10-05 20:12 ` Juri Linkov
2020-10-05 21:31 ` Andreas Schwab
2020-10-06 13:08 ` Stefan Monnier
2020-10-06 13:28 ` Andreas Schwab
2020-10-05 23:06 ` Glenn Morris
2020-10-06 7:13 ` Andreas Schwab
2020-10-06 7:18 ` Eli Zaretskii
2020-10-06 7:28 ` Eli Zaretskii
2020-10-06 7:48 ` Andreas Schwab
2020-10-06 8:18 ` Eli Zaretskii
2020-10-06 8:44 ` Andreas Schwab
2020-10-06 9:03 ` Eli Zaretskii
2020-10-06 9:17 ` Andreas Schwab
2020-10-06 9:24 ` Eli Zaretskii
2020-10-06 9:45 ` Andreas Schwab
2020-10-06 7:52 ` Juri Linkov
2020-10-01 20:01 ` Lars Ingebrigtsen
2020-10-01 2:30 ` Eli Zaretskii
2020-10-01 2:39 ` Lars Ingebrigtsen
2020-10-01 9:24 ` Andy Moreton
2020-09-30 21:07 ` Drew Adams
2020-10-01 1:25 ` Lars Ingebrigtsen
2020-10-01 16:35 ` Drew Adams
2020-09-30 20:56 ` Drew Adams
2020-05-16 23:11 ` Juri Linkov
2020-05-17 1:16 ` Drew Adams
2020-05-15 6:43 ` Eli Zaretskii
2020-05-15 8:40 ` Arthur Miller
2020-05-15 10:15 ` Eli Zaretskii
2020-05-15 10:50 ` Arthur Miller
2020-10-06 11:36 ` Mattias Engdegård
[not found] <<VI1PR06MB45265DF0191578C413A3B37C96BC0@VI1PR06MB4526.eurprd06.prod.outlook.com>
[not found] ` <<87v9ky9p6o.fsf@mail.linkov.net>
[not found] ` <<654acc31-015d-4552-bd9b-3b8c69661fcd@default>
[not found] ` <<VI1PR06MB45265603DFF6BE71DBD819EB96BD0@VI1PR06MB4526.eurprd06.prod.outlook.com>
[not found] ` <<0957af50-7f85-455a-9d2c-e96451727872@default>
[not found] ` <<83a729uiaq.fsf@gnu.org>
2020-05-15 21:00 ` Drew Adams
2020-05-15 21:14 ` Arthur Miller
2020-05-15 22:04 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgazi550.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=41250@debbugs.gnu.org \
--cc=arthur.miller@live.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).