From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#43682: 28.0.50; Clean up nnimap server buffers? Date: Thu, 01 Oct 2020 10:25:00 -0700 Message-ID: <87sgax6eqb.fsf@ericabrahamsen.net> References: <87eemlh3ro.fsf@ericabrahamsen.net> <87d024bpqc.fsf@gnus.org> <87mu18qw3g.fsf@ericabrahamsen.net> <87k0wc9i4k.fsf@gnus.org> <87tuvfc4ur.fsf@ericabrahamsen.net> <87d022wx5y.fsf@gnus.org> <871rii7cso.fsf@ericabrahamsen.net> <87o8lmq6k4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19334"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43682@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 19:43:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO2bp-0004tW-MY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 19:43:14 +0200 Original-Received: from localhost ([::1]:41442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO2bo-00072z-N0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 13:43:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO2LD-0004VN-EC for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 13:26:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO2LC-0004N6-Hl for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 13:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO2LC-0001vf-Eb for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 13:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43682 X-GNU-PR-Package: emacs Original-Received: via spool by 43682-submit@debbugs.gnu.org id=B43682.16015731127357 (code B ref 43682); Thu, 01 Oct 2020 17:26:02 +0000 Original-Received: (at 43682) by debbugs.gnu.org; 1 Oct 2020 17:25:12 +0000 Original-Received: from localhost ([127.0.0.1]:38165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO2KN-0001ub-Nb for submit@debbugs.gnu.org; Thu, 01 Oct 2020 13:25:11 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:44928 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO2KL-0001uJ-7u for 43682@debbugs.gnu.org; Thu, 01 Oct 2020 13:25:11 -0400 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 61D4CFA08E; Thu, 1 Oct 2020 17:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1601573102; bh=l7qRM+mkBMZiJ/t3GEu148YnVaFRGbwVv6N9oW6BtRw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Bh4fBcGW2hrYyOWbj5CMXE0D4B9MW1YurFx/SKRWw1ndjFkLByLAfmHu++U9cGqDS 19dFCWjjXIqRT//CUccXDZxlHleka0/+3uFWTQjp7LTMu+atBDI6kj/zRCVNxdh5gd 5RuzrEsIF9AwhCzW8XeBA3gG423vCHrGJZnM9p68= In-Reply-To: <87o8lmq6k4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Oct 2020 18:01:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189541 Archived-At: On 10/01/20 18:01 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> It's possible (I'm not claiming to understand all the code) that all we >> would need to do is fix `gnus-async-wait-for-article' to replace its >> calls to `nntp-find-connection' and `nntp-accept-process-output' with >> something generalized. Those two functions deal with directly with >> `nntp-connection-alist', so we'd need something that would do the >> equivalent with `nnimap-connection-alist'. > > Yup. This is something I wouldn't want to tackle until we have generic functions. >> Anyway, in the interest of completing this far less ambitious patch: if >> the nnimap connection has timed out, we should remove this connection >> from `nnimap-connection-alist', so this version of the patch does that. >> If async has opened a second connection, I guess we should leave that >> alone, though I don't have too much confidence that the whole process >> will recover gracefully from the main connection dying... > > Well, the connections are separate, and there's all kinds of reasons for > the server to close a connection, so... > >> + (unless (memq (process-status (get-buffer-process buffer)) >> + '(open run)) > > Aka `process-live-p'. I forgot we have that! > Otherwise looks fine to me (but I haven't tested the code). Okay, I'll run this for a bit, as well.