From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41065: (no subject) Date: Tue, 27 Oct 2020 09:47:07 +0100 Message-ID: <87sga0qcms.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41065@debbugs.gnu.org To: Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 27 09:48:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXKeI-0000PT-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 09:48:10 +0100 Original-Received: from localhost ([::1]:39498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXKeH-00050P-J8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 04:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXKeA-00050A-H7 for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 04:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXKeA-0008Md-7y for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 04:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXKeA-000180-4t for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 04:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Oct 2020 08:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41065 X-GNU-PR-Package: emacs Original-Received: via spool by 41065-submit@debbugs.gnu.org id=B41065.16037884403444 (code B ref 41065); Tue, 27 Oct 2020 08:48:02 +0000 Original-Received: (at 41065) by debbugs.gnu.org; 27 Oct 2020 08:47:20 +0000 Original-Received: from localhost ([127.0.0.1]:42779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXKdU-0000tG-8k for submit@debbugs.gnu.org; Tue, 27 Oct 2020 04:47:20 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXKdS-0000nS-6e for 41065@debbugs.gnu.org; Tue, 27 Oct 2020 04:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Cc:To:From:Sender:Reply-To:Subject:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YChYUdL8T5lcj+Ae5hvI04Lxkh1s0TU/tacj93YVr+U=; b=gJxc3s8QUZjB54YL34E2pPEZgl 8jnA0S9nT50jNkwNn2n5UplRBLTOsoiCUNDCUFvTZb4C/bZsL61mFiyNNNpmx94A6W9AI8HoSueQs SNzZcIWfEsTkhyrgRCxD/XQFyXPwAP1ByGfrwDm1MG+jqAg+D08cUT1UVrG1Dvn/Jd+s=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXKdI-0004hl-Uk; Tue, 27 Oct 2020 09:47:11 +0100 X-Now-Playing: Big in Japan's _From Y to Z and never again_: "Nothing Special" In-Reply-To: (Paul Pogonyshev's message of "Tue, 27 Oct 2020 01:10:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191710 Archived-At: Paul Pogonyshev writes: > Subject: [PATCH] Don't leak result of nested byte-compilation to outer level > (bug#41065) [...] > + byte-compile-dest-file byte-compiler-error-flag) > (setq target-file (byte-compile-dest-file filename)) > (setq byte-compile-dest-file target-file) > (with-current-buffer > @@ -2000,7 +2000,6 @@ byte-compile-file > 'no-byte-compile) > (when byte-compile-verbose > (message "Compiling %s..." filename)) > - (setq byte-compiler-error-flag nil) Thanks; applied to Emacs 28. I tried to follow the code paths where this variable is used, and as far as I can tell, this should be safe. The old code was rather odd, because there's just a (defvar byte-compiler-error-flag) in the file -- it's not actually defined, but after compiling something, that `setq' would define it globally. So your patch fixes that problem, too. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no