From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44338: 27.1; EWW can't download and view pdf Date: Wed, 04 Nov 2020 20:01:15 +0000 Message-ID: <87sg9oriwk.fsf@tcd.ie> References: <878sbmo6i0.fsf@tcd.ie> <83tuu5b1oh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16200"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44338@debbugs.gnu.org, Nicholas Harrison To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 04 21:02:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaOyz-00048K-Nv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Nov 2020 21:02:13 +0100 Original-Received: from localhost ([::1]:60356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaOyy-00070l-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Nov 2020 15:02:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaOyo-0006xa-Sx for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 15:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39131) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaOyo-0003pA-It for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 15:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kaOyo-0005t9-Ge for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 15:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Nov 2020 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44338-submit@debbugs.gnu.org id=B44338.160452008722572 (code B ref 44338); Wed, 04 Nov 2020 20:02:02 +0000 Original-Received: (at 44338) by debbugs.gnu.org; 4 Nov 2020 20:01:27 +0000 Original-Received: from localhost ([127.0.0.1]:50673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaOyE-0005rz-RP for submit@debbugs.gnu.org; Wed, 04 Nov 2020 15:01:27 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:41498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaOyB-0005rj-8H for 44338@debbugs.gnu.org; Wed, 04 Nov 2020 15:01:24 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id s9so23372543wro.8 for <44338@debbugs.gnu.org>; Wed, 04 Nov 2020 12:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IheLB6h5BbT8JqtMHv/rJeIi8ngozHYNmcxS/YQ1Oes=; b=HZzuLNAkWPqp+TrRMZBgUP7wBbaLh0sQ4F8dP7wcb2hphW1PIqrO/RsKL5ANx6iFEx oyxqjIvDiES1jC0IIgNH6k3bQzAduh9ja3lEcWcl/oce5my5XiC0zPjUt1gYGXR+qzFO xMWo7z+IkgtpXkki/S5lJ40/0Rnz6H+E46ADXadtbQtdCUfZ1E6L5MgHBc5Zr+/GXL1p 01OkVcglu0hcBiEWdOJCIYkNVBWqV80vjfhS8N1NZBV0ZydB2q09d10MyuGu1R1wHww9 i8JV8raYevQ69DJkQlLy0kujBDZLrutK9cJ5b/RJq22bbNeYK7W6/1XkKFMSKKZ5i5Ix vL1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IheLB6h5BbT8JqtMHv/rJeIi8ngozHYNmcxS/YQ1Oes=; b=QNzk60GgU3LKdHPAnqz0YwD6vJ/695B+xe0o7CeZd2kiP5xA4I/vylRGMoJX7hFgY/ wDYqKbR1XBB5JyMdXlwFYeeZuel9ATq0kdjAkNoW54hiUv3nS0eFRb2GhwbLVKqoI7sM 9jnGAdrGp5M+a7NBvzi/7HLZt15zU1oTzx2r1UYCyCstt9eKkbfvsnnFbKvuuBnjbRJn Kd2jswWzHKOCGxTrXznRTEc0ws7FbSXfNfHnSJwZffPLzCvnim/+Lax827jP3jD3UT7F wJ9nsMCRAnDHRC1SUpyMpyjc8vVPF3OqbVhcrBqKtutj9UkX7gnF+uoHd3wKEUPxu5Cl PwHA== X-Gm-Message-State: AOAM533vUcvi4eqeTT0FLJjma02AYEDEwzG/cJ720Z/hwwbdDeH5vDlF b9+Felk6eIuSyv5lufhYjxLUvw== X-Google-Smtp-Source: ABdhPJx0H7/rVSh19Gi1F1saXYUmGyRsxAo6jpZKe3uKfD1bk6xJfm0FHTXfMbv44REOs892ehy56Q== X-Received: by 2002:a5d:468f:: with SMTP id u15mr34390747wrq.154.1604520077358; Wed, 04 Nov 2020 12:01:17 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id y201sm4001523wmd.27.2020.11.04.12.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 12:01:16 -0800 (PST) In-Reply-To: <83tuu5b1oh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Nov 2020 17:07:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192683 Archived-At: Eli Zaretskii writes: > In any case, this isn't right: > > (defun eww-display-pdf () > (let ((data (buffer-substring (point) (point-max)))) > (pop-to-buffer-same-window (get-buffer-create "*eww pdf*")) > (let ((coding-system-for-write 'raw-text) <<<<<<<<<<<<<<<<<<<<<< > (inhibit-read-only t)) > (erase-buffer) > (insert data) > (mailcap-view-mime "application/pdf"))) > (goto-char (point-min))) > > We should use 'raw-text-unix here, since the buffer contents is a > stream of raw bytes. Thanks, I've made the change in my patch, and will push in a few days if I don't hear otherwise. -- Basil