From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44338: 27.1; EWW can't download and view pdf Date: Thu, 05 Nov 2020 21:25:15 +0000 Message-ID: <87sg9nzebo.fsf@tcd.ie> References: <878sbmo6i0.fsf@tcd.ie> <83tuu5b1oh.fsf@gnu.org> <837dqzc42r.fsf@gnu.org> <83sg9najmh.fsf@gnu.org> <83h7q3adsh.fsf@gnu.org> <87lfff39rc.fsf@tcd.ie> <87361nsfjm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29260"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44338@debbugs.gnu.org, Nicholas Harrison To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 05 22:26:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kamm3-0007Ub-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Nov 2020 22:26:27 +0100 Original-Received: from localhost ([::1]:38576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kamm2-0004ln-3z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Nov 2020 16:26:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kamle-0004k1-MQ for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 16:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kamle-0005wE-CK for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 16:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kamle-0006u1-8O for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Nov 2020 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44338-submit@debbugs.gnu.org id=B44338.160461152926494 (code B ref 44338); Thu, 05 Nov 2020 21:26:02 +0000 Original-Received: (at 44338) by debbugs.gnu.org; 5 Nov 2020 21:25:29 +0000 Original-Received: from localhost ([127.0.0.1]:54315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaml6-0006tG-PP for submit@debbugs.gnu.org; Thu, 05 Nov 2020 16:25:29 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:38477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaml1-0006sl-4Y for 44338@debbugs.gnu.org; Thu, 05 Nov 2020 16:25:26 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id n18so3413094wrs.5 for <44338@debbugs.gnu.org>; Thu, 05 Nov 2020 13:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aVnbwhYUbpDwh8pnHk4TGog7u6lJNZ+6MRiQvNgAuEo=; b=N0HuMZnj7cifw7cICyTrvlokW2Jjq/M9aiNXtYA0uAL/x6bdj7DQovpMs9TAECDz9s CHErxrYLfkI5vxYtD8yN9oOAiDRw7oD/IE1QEzsd2Wzt2/hIoXNo7+rtd+AwV4Vdxkmh N8eWStVFBNGnu4VnXPNauA1iEZzjO4ZAW/5JEo7SleD3uygbzjK2yvD1fhYJ7AAsApQ6 T4VYjpejm+F4EWuf/AUsGwIRndVJcNwfnRQZjTn/XWorljVlUzf/19ZidVux/iO1203D CjEvzFUwjJfswwhzs0XTJrnXjAaAfrKWFn92aYIc+C5jZ+O+x3GZjc3Mjwt8ZFeftU0u avVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=aVnbwhYUbpDwh8pnHk4TGog7u6lJNZ+6MRiQvNgAuEo=; b=ZoCN6wPywdA1Ey2Aqf/3Tdh1A8WtSk/tR7V/uH10awhMXO7WeGFXdI8UhfUd5oQrT2 dGGmj8ARkRrVl0ozM0OfcXnWeJA/n0sGRLze7ZVAw1nx8KLcIGjI+ZTNrDs+Zrd+RrGx lb46x89UHAwZOorQwLg8NlaxA+neCt/q8HRAsBp4WBFNNGoYpj9fhqhoC8ErmCGanCTm WZjIUvGLQ/UMrjlViax5W21VgZX4GpQTtZ2N5Fsiwx1hx0UBi1+6FYdbD4x3BM8Phh7S Wg1y6Opfm/G0PVT18HWaAoKZdvSHfaqcwnJcSM6bGRSYkWJsy2mFw57d1R7iAdVSGuPp BP0w== X-Gm-Message-State: AOAM531b8MOtf1aktsEQbCX4c7Qm9RGfI3iNRVtw3EYkL1r45zqnzZ5e NuneQFOz32QmZTeXFHACPXcwag== X-Google-Smtp-Source: ABdhPJwExaSvam0T4iBXRlCWYUEbxiitItr6jL6Ng93ovv9bRzTHbsMheTWHe3FRToZqquzZTd0GSg== X-Received: by 2002:adf:ab50:: with SMTP id r16mr4967230wrc.235.1604611517197; Thu, 05 Nov 2020 13:25:17 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id y4sm4453567wrp.74.2020.11.05.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 13:25:16 -0800 (PST) In-Reply-To: <87361nsfjm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 05 Nov 2020 21:40:45 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192757 Archived-At: --=-=-= Content-Type: text/plain tags 44338 fixed close 44338 28.1 quit Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> In other words, can we remove the binding altogether from >> eww-display-pdf and make the *eww pdf* buffer unibyte, as Stefan >> suggested? > > Yes, this is the correct fix. Thanks, done. Fix coding system in eww-display-pdf 4610241a9b 2020-11-05 21:06:39 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4610241a9b3fbddd1f0973bf49f7008ed09ab955 I'm therefore marking this bug as fixed in 28.1. Nicholas, here's the cumulative change to the function eww-display-pdf, in case you want to patch/advise yours on Emacs 27.1: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eww.diff diff --git a/lisp/net/eww.el b/lisp/net/eww.el index d6f850ca3b..43405fbd9c 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -667,14 +811,19 @@ eww-display-image (declare-function mailcap-view-mime "mailcap" (type)) (defun eww-display-pdf () - (let ((data (buffer-substring (point) (point-max)))) - (pop-to-buffer-same-window (get-buffer-create "*eww pdf*")) - (let ((coding-system-for-write 'raw-text) - (inhibit-read-only t)) - (erase-buffer) - (insert data) - (mailcap-view-mime "application/pdf"))) - (goto-char (point-min))) + (let ((buf (current-buffer)) + (pos (point))) + (with-current-buffer (get-buffer-create "*eww pdf*") + (let ((inhibit-read-only t)) + (erase-buffer) + (set-buffer-multibyte nil) + (insert-buffer-substring buf pos) + (mailcap-view-mime "application/pdf")) + (if (zerop (buffer-size)) + ;; Buffer contents passed to shell command via temporary file. + (kill-buffer) + (goto-char (point-min)) + (pop-to-buffer-same-window (current-buffer)))))) (defun eww-setup-buffer () (when (or (plist-get eww-data :url) --=-=-= Content-Type: text/plain -- Basil --=-=-=--