From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 29193@debbugs.gnu.org
Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal
Date: Sat, 12 Dec 2020 12:39:16 +0100 [thread overview]
Message-ID: <87sg8b5k4b.fsf@gnus.org> (raw)
In-Reply-To: <f283e3a4-f9a9-dbc3-3d2c-4304f0c7a53d@yandex.ru> (Dmitry Gutov's message of "Tue, 7 Nov 2017 17:28:06 +0200")
Dmitry Gutov <dgutov@yandex.ru> writes:
> Rubocop can report warning when 'end' is at wrong column. It just
> reports the beginning column, of course.
>
> In ruby-mode, (thing-at-point 'sexp) signals an error at this position.
> I'm not sure exactly whether it's a problem in ruby-mode.
>
> But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the
> whole 'end' token gets highlighted (which is probably what we expect).
>
> In contrast, Flymake only highlights its first character ('e').
I had a look at the current `flymake-diag-region', and it does not use
(thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp),
though.
So is this problem still present? There was no recipe for reproduction,
so it's not immediately clear.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-12-12 11:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 15:28 bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Dmitry Gutov
2020-12-12 11:39 ` Lars Ingebrigtsen [this message]
2020-12-12 23:56 ` Dmitry Gutov
2020-12-13 12:51 ` Lars Ingebrigtsen
2020-12-13 13:19 ` João Távora
2020-12-13 20:55 ` Dmitry Gutov
2020-12-14 11:03 ` João Távora
2020-12-16 0:55 ` Dmitry Gutov
[not found] ` <handler.29193.D29193.160808016725606.notifdone@debbugs.gnu.org>
2020-12-17 23:25 ` Glenn Morris
2020-12-18 2:06 ` Dmitry Gutov
2020-12-18 11:42 ` João Távora
2020-12-18 15:22 ` Dmitry Gutov
2020-12-18 15:26 ` João Távora
2020-12-18 15:29 ` Dmitry Gutov
2020-12-18 15:39 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg8b5k4b.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=29193@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).