From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#45068: Patch for Modus themes 1.1.1? (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Date: Mon, 25 Jan 2021 10:49:46 +0200 Message-ID: <87sg6po0yd.fsf_-_@protesilaos.com> References: <87im9fgm27.fsf@protesilaos.com> <87zh2ozer4.fsf@tcd.ie> <87ft4edret.fsf@protesilaos.com> <87zh2ldgtf.fsf@protesilaos.com> <87k0toof83.fsf@mail.linkov.net> <83wnxo1mcr.fsf@gnu.org> <83v9d81khh.fsf@gnu.org> <83mtyk1hq3.fsf@gnu.org> <87czzgbapt.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> <83im9814oh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31515"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: contovob@tcd.ie, info@protesilaos.com, 45068@debbugs.gnu.org, Stefan Kangas , juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 25 09:51:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3xb1-00084c-6c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jan 2021 09:51:39 +0100 Original-Received: from localhost ([::1]:48096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3xb0-00088C-7J for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jan 2021 03:51:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3xZT-0007JN-QJ for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 03:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3xZS-0002O3-Kd for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 03:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3xZS-0007ze-Hy for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 03:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2021 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161156460130713 (code B ref 45068); Mon, 25 Jan 2021 08:50:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 25 Jan 2021 08:50:01 +0000 Original-Received: from localhost ([127.0.0.1]:37866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3xZQ-0007zI-Qj for submit@debbugs.gnu.org; Mon, 25 Jan 2021 03:50:01 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3xZO-0007z2-6Z for 45068@debbugs.gnu.org; Mon, 25 Jan 2021 03:49:58 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5601AFF813; Mon, 25 Jan 2021 08:49:49 +0000 (UTC) In-Reply-To: <83im9814oh.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Dec 2020 22:14:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198556 Archived-At: On 2020-12-11, 22:14 +0200, Eli Zaretskii wrote: >> From: Stefan Kangas >> Date: Fri, 11 Dec 2020 13:08:19 -0600 >> Cc: juri@linkov.net, contovob@tcd.ie, 45068@debbugs.gnu.org >> >> Eli Zaretskii writes: >> >> > . don't consider this a "theme", but a normal Lisp package (since it >> > basically violates the conventions for writing a theme) >> >> I guess such violations of our old conventions are getting increasingly >> common in (third-party) Emacs theme development. > > Then maybe the best way is to provide that require-theme function I > proposed. Hello again! I have produced a newer version in the meantime. Though I understand that a patch would not be able to be merged under the present conditions. Should I prepare it regardless? This would also fix bug#45141 pertaining to some formatting issues in modus-themes.texi. To recapitulate for your convenience: + The current etc/themes/modus-{operandi,vivendi}-theme.el are old-style themes in that they look like the rest of that directory's contents. - They exist as standalone files. They do not require any library. - All their face declarations are furnished therein. - Their version is 0.13.0. + As of version 1.0.0 (and now 1.1.1) of the Modus themes, those two files merely expand a macro and declare their respective theme. They thus depend on a shared library: currently that is modus-themes.el. - The library unifies the themes' defcustom declarations and, in general, streamlines their development (before I would copy lines from one to the other to ensure parity). - This approach of a library and concomitant macro expansion is not in line with the current design of etc/themes/, though as Stefan Kangas observed, such deviations from the established norms are becoming increasingly common in third-party packages. A quick-and-dirty workaround would be to place the library in some other path, such as lisp/modus-themes.el and keep the other two files were they currently are: etc/themes/modus-{operandi,vivendi}-theme.el This could, however, make the source code more difficult to understand. It would also set a bad precedent for any possible future themes, as this thread revealed. So Eli Zaretskii proposed a new 'require-theme' function. I believe this is how things stand. For my part, I am willing to do whatever you consider necessary and will follow your lead. Thank you for your time and efforts! Protesilaos or Prot -- Protesilaos Stavrou protesilaos.com