From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ahmed Khanzada Newsgroups: gmane.emacs.bugs Subject: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Date: Mon, 25 Jan 2021 22:37:53 -0800 Message-ID: <87sg6oyzi6.wl-me@enzu.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8968"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (sparc64-unknown-openbsd) MULE/6.0 (HANACHIRUSATO) To: 46111@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 26 10:07:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4KJZ-00024U-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Jan 2021 10:07:09 +0100 Original-Received: from localhost ([::1]:49032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4KJY-000207-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Jan 2021 04:07:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4KJS-0001zp-5F for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 04:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4KJR-0005N0-Tg for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 04:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4KJR-0001pj-PC for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 04:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ahmed Khanzada Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2021 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46111 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16116519666978 (code B ref -1); Tue, 26 Jan 2021 09:07:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jan 2021 09:06:06 +0000 Original-Received: from localhost ([127.0.0.1]:40726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4KIU-0001oG-DA for submit@debbugs.gnu.org; Tue, 26 Jan 2021 04:06:06 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4HzH-0004Y1-Nc for submit@debbugs.gnu.org; Tue, 26 Jan 2021 01:38:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4HzH-0003OG-GG for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:38:03 -0500 Original-Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:52044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4HzF-0005ib-En for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:38:03 -0500 Original-Received: by mail-pj1-x1031.google.com with SMTP id a20so1448782pjs.1 for ; Mon, 25 Jan 2021 22:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enzu-ru.20150623.gappssmtp.com; s=20150623; h=date:message-id:from:to:subject:user-agent; bh=AdUAxxgLc9HDBs73bhRxbp4dLCsBC9CcwPHGSk5d/C0=; b=OBZmyuwFQoei0Xt+wwkOCPpb3Ne/AS8aBoBBrQSfn9ssdkKTJDJJt8WjxrOraxSc2r a068gO1X1hUCWIBmCIlvthQwOcgRSEmtdEQbJZR3JGjtFZc0nNp/4NITozFMgvLR1SmK uig1F9bg5lnBVGrUeRbZBpuxysgKd/Hc9qgYXEbuzYhDged+eTRPlePJ84F2LO0ALVtH 3T+nk79lvRs45E6dteOVJPoRgcBdlji+3Zm2GSqfNXFxcjcuEYREe36ceX0CApCSlZ8r Uj7JysC0xQkvmZx37Kolx0p09jUKVJtKQnn9RFDKiXvaDH0clLEUdILnwYxfmaSE7v8h eq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:subject:user-agent; bh=AdUAxxgLc9HDBs73bhRxbp4dLCsBC9CcwPHGSk5d/C0=; b=sLivptDVrHfylEiunnfUFyVYo5AFsin68m5pSV2xzVUaln02/Ijej1SLhFA259KoTs kZ+Ub+SnAXyNfS82HE0/wqNnh9r5BMpFFF5ccKRmApUh8YC7f/3i21iHCF1/ZAWi9Jbb TifJTQewNMpgA2C3t17D8WtXZUfDJg3XRm5VeiIYvkBcrP3ZHAdV96QsNfN1sLkfFXSH qPP1me7nfAHCl4MAhuMyWsrr/vDbLo8gEdnx7ztmiG2ES9SV8MfJ1tcEzqF9iUrQRWFI pYM3rbW9W6ubeHGKhd1yPOo0Gm54DvT7EVLZTZke4tjKDg/pGjKBlYb1/VhktQOus7OU 0Jbg== X-Gm-Message-State: AOAM533khCTt0f23mFgeC/Px0J2IQmwK6yhAyFdXtdgvEDTOWpvnYU6d xHyEcdVmeHkkTQY2NzspAsiygNQl3pAfoH9y X-Google-Smtp-Source: ABdhPJw/q3jk9yWBVQZuPdRulYzZBaM4mRgzXJJXn2kXCWMpngGoJp+vX5e7i8840ps0odAcDwGIbg== X-Received: by 2002:a17:90b:46cf:: with SMTP id jx15mr4464090pjb.61.1611643079019; Mon, 25 Jan 2021 22:37:59 -0800 (PST) Original-Received: from ultra.enzu.ru.enzu.ru (cpe-45-48-14-47.socal.res.rr.com. [45.48.14.47]) by smtp.gmail.com with ESMTPSA id t206sm18271059pgb.84.2021.01.25.22.37.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 22:37:58 -0800 (PST) Received-SPF: none client-ip=2607:f8b0:4864:20::1031; envelope-from=me@enzu.ru; helo=mail-pj1-x1031.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 26 Jan 2021 04:06:01 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198612 Archived-At: I'm not an expert on C, OpenBSD, or SPARC64, but I did notice emacs-current was not compiling. During a gmake, bootstrap-emacs would get a SIGBUS and fail. Running gdb led me to the hash_string function where it seemed to be failing. Reverting the hash_string function to a previous version seems to have fixed the issue. If I had to guess, it may have something to do with SPARC64 alignment. I don't have an updated AMD64 OpenBSD box running at the moment, but if you would like me to test there, I could find a way. I understand that reverting this function might not be the best way forward, but wrote a patch just in case that reverts hash_string to an earlier version that compiles on OpenBSD/SPARC64. I am already signed all my GNU contributor docs. --[[text/plain; type=patch; name="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" Content-Disposition: attachment; filename="0001-Reverting-hasattach filh_string-function-due-to-problem-on-Ope.patch"][base64]] RnJvbSBkOTM4NzQ1Y2U1NjA1OGJlMjQwNzhlYzUyZDk3Mzk4Njk3ZGI0Yjc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBaG1lZCBLaGFuemFkYSA8bWVAZW56dS5ydT4KRGF0ZTogTW9u LCAyNSBKYW4gMjAyMSAyMToxNjo0OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydGluZyBo YXNoX3N0cmluZyBmdW5jdGlvbiBkdWUgdG8gcHJvYmxlbSBvbgogT3BlbkJTRC9TUEFSQzY0Cgot LS0KIHNyYy9mbnMuYyB8IDMyICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggN2FiMmU4ZjFhMC4uMDEyN2ZlM2Y0OCAxMDA2 NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDU5OSwzNCArNDU5OSwxNiBA QCAjZGVmaW5lIFNYSEFTSF9NQVhfTEVOICAgNwogRU1BQ1NfVUlOVAogaGFzaF9zdHJpbmcgKGNo YXIgY29uc3QgKnB0ciwgcHRyZGlmZl90IGxlbikKIHsKLSAgRU1BQ1NfVUlOVCBjb25zdCAqcCAg ID0gKEVNQUNTX1VJTlQgY29uc3QgKikgcHRyOwotICBFTUFDU19VSU5UIGNvbnN0ICplbmQgPSAo RU1BQ1NfVUlOVCBjb25zdCAqKSAocHRyICsgbGVuKTsKLSAgRU1BQ1NfVUlOVCBoYXNoID0gbGVu OwotICAvKiBBdCBtb3N0IDggc3RlcHMuICBXZSBjb3VsZCByZXVzZSBTWEhBU0hfTUFYX0xFTiwg b2YgY291cnNlLAotICAgKiBidXQgZGl2aWRpbmcgYnkgOCBpcyBjaGVhcGVyLiAgKi8KLSAgcHRy ZGlmZl90IHN0ZXAgPSAxICsgKChlbmQgLSBwKSA+PiAzKTsKLQotICAvKiBCZXdhcmU6IGBlbmRg IG1pZ2h0IGJlIHVuYWxpZ25lZCwgc28gYHAgPCBlbmRgIGlzIG5vdCBhbHdheXMgdGhlIHNhbWUK LSAgICogYXMgYHAgPD0gZW5kIC0gMWAuICAqLwotICB3aGlsZSAocCA8PSBlbmQgLSAxKQorICBj aGFyIGNvbnN0ICpwID0gcHRyOworICBjaGFyIGNvbnN0ICplbmQgPSBwICsgbGVuOworICB1bnNp Z25lZCBjaGFyIGM7CisgIEVNQUNTX1VJTlQgaGFzaCA9IDA7CisKKyAgd2hpbGUgKHAgIT0gZW5k KQogICAgIHsKLSAgICAgIEVNQUNTX1VJTlQgYyA9ICpwOwotICAgICAgcCArPSBzdGVwOworICAg ICAgYyA9ICpwKys7CiAgICAgICBoYXNoID0gc3hoYXNoX2NvbWJpbmUgKGhhc2gsIGMpOwogICAg IH0KLSAgaWYgKHAgPCBlbmQpCi0gICAgeyAvKiBBIGZldyBsYXN0IGJ5dGVzIHJlbWFpbiAoc21h bGxlciB0aGFuIGFuIEVNQUNTX1VJTlQpLiAgKi8KLSAgICAgIC8qIEZJWE1FOiBXZSBjb3VsZCBk byB0aGlzIHdpdGhvdXQgYSBsb29wLCBidXQgaXQnZCByZXF1aXJlCi0gICAgICAgICBlbmRpYW4t ZGVwZW5kZW50IGNvZGUgOi0oICAqLwotICAgICAgY2hhciBjb25zdCAqcDEgPSAoY2hhciBjb25z dCAqKXA7Ci0gICAgICBjaGFyIGNvbnN0ICplbmQxID0gKGNoYXIgY29uc3QgKillbmQ7Ci0gICAg ICBkbwotICAgICAgICB7Ci0gICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gKnAxKys7Ci0gICAg ICAgICAgaGFzaCA9IHN4aGFzaF9jb21iaW5lIChoYXNoLCBjKTsKLSAgICAgICAgfQotICAgICAg d2hpbGUgKHAxIDwgZW5kMSk7Ci0gICAgfQogCiAgIHJldHVybiBoYXNoOwogfQotLSAKMi4yOC4w Cgo=