From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46836: 28.0.50; Clean up obsolete comment for unchain_marker Date: Mon, 01 Mar 2021 14:29:49 +0100 Message-ID: <87sg5f6lyq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21812"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46836@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 14:31:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGidx-0005Zl-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 14:31:25 +0100 Original-Received: from localhost ([::1]:41786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGidw-0004Aj-4E for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 08:31:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGidb-000490-K5 for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGida-0007sU-2i for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGida-0002Xs-07 for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 13:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46836 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46836-submit@debbugs.gnu.org id=B46836.16146054056209 (code B ref 46836); Mon, 01 Mar 2021 13:31:01 +0000 Original-Received: (at 46836) by debbugs.gnu.org; 1 Mar 2021 13:30:05 +0000 Original-Received: from localhost ([127.0.0.1]:48488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGice-0001bm-OA for submit@debbugs.gnu.org; Mon, 01 Mar 2021 08:30:05 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:42442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGicZ-0001YU-UA for 46836@debbugs.gnu.org; Mon, 01 Mar 2021 08:30:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HtZCoBOXaOU+Ot64kbJiTSBRF00nZmKWHk4UtmCYe5I=; b=klLbTMGUIq0CHWjDT5AEP4/PDP EZ5KdO1ZPK05ueoWAoK+xjGNzdvSaln0CuAPqCd4GjzKp8W7IcCyPOqKj1TChrQJrcb9X5QDwg0r1 EaZekOZ9aqnQrIlH/Oqc8ChYoneYEY6hKpR7LDvwUUvKsRJcoD6q1oe2LB8CaDJnZths=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGicQ-0002Eg-RF; Mon, 01 Mar 2021 14:29:53 +0100 X-Now-Playing: Lightning Bolt's _Sonic Citadel_: "=?UTF-8?Q?H=C3=BCsker_?= =?UTF-8?Q?D=C3=B6nt?=" In-Reply-To: (Matt Armstrong's message of "Sun, 28 Feb 2021 14:54:27 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201089 Archived-At: Matt Armstrong writes: > I wondered why there was a scare comment for unchain_marker, when the > code itself did not look like it was especially different from the other > nearby functions. It turns out that the call into this function from GC > was removed a few years ago. [...] > -/* Remove MARKER from the chain of whatever buffer it is in, > - leaving it points to nowhere. This is called during garbage > - collection, so we must be careful to ignore and preserve > - mark bits, including those in chain fields of markers. */ > +/* Remove MARKER from the chain of whatever buffer it is in. Set its > + buffer NULL. */ Thanks; applied to Emacs 28. Looking at the code in unchain_marker, I was a bit confused, because the code looks very straightforward? I wondered whether the function could also be simplified now that it doesn't have to preserve mark bits... But all the special mark bit code was removed from this code a couple decades ago. :-) commit 5e097e002ba08205c8a4643b3495dbd45462147f Author: Stefan Monnier AuthorDate: Thu Jun 26 23:17:50 2003 +0000 ... else - { - omark = XMARKBIT (XMARKER (prev)->chain); - XMARKER (prev)->chain = next; - XSETMARKBIT (XMARKER (prev)->chain, omark); - } -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no