From: Lars Ingebrigtsen <larsi@gnus.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 6000@debbugs.gnu.org, Lennart Borgman <lennart.borgman@gmail.com>
Subject: bug#6000: describe-text-sexp does not know window-width
Date: Sun, 06 Jun 2021 11:03:47 +0200 [thread overview]
Message-ID: <87sg1vuzyk.fsf@gnus.org> (raw)
In-Reply-To: <b7cf674b-63b7-9711-0af5-66d98eb29c5d@gmx.at> (martin rudalics's message of "Fri, 4 Jun 2021 14:44:38 +0200")
martin rudalics <rudalics@gmx.at> writes:
> `describe-text-sexp' always works on the current buffer
>
> (defun describe-text-sexp (sexp)
> "Insert a short description of SEXP in the current buffer."
>
> so the added line will avoid the [Show] button iff the selected window
> doesn't show the current buffer which should be rare enough.
That's what I thought should happen, but your proposed change is the
patch below, which seems to do the opposite? I.e., it'll always do the
[Show] button if the selected window doesn't show the current buffer...
diff --git a/lisp/descr-text.el b/lisp/descr-text.el
index 85017de5d5..f92f37d53d 100644
--- a/lisp/descr-text.el
+++ b/lisp/descr-text.el
@@ -51,7 +51,8 @@ describe-text-sexp
(setq pp (substring pp 0 (1- (length pp)))))
(if (and (not (string-match-p "\n" pp))
- (<= (length pp) (- (window-width) (current-column))))
+ (eq (window-buffer) (current-buffer))
+ (<= (length pp) (- (window-width) (current-column))))
(insert pp)
(insert-text-button
"[Show]"
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-06-06 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 12:15 bug#6000: describe-text-sexp does not know window-width Lennart Borgman
2014-07-01 23:37 ` Juri Linkov
2021-06-03 9:07 ` Lars Ingebrigtsen
2021-06-03 20:25 ` Juri Linkov
2021-06-04 9:18 ` martin rudalics
2021-06-04 9:49 ` Lars Ingebrigtsen
2021-06-04 12:44 ` martin rudalics
2021-06-06 9:03 ` Lars Ingebrigtsen [this message]
2021-06-06 7:42 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg1vuzyk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=6000@debbugs.gnu.org \
--cc=lennart.borgman@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).