unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35393@debbugs.gnu.org
Subject: bug#35393: 26.2; `help-echo' text propertized with `face' is not shown in that face
Date: Tue, 22 Jun 2021 16:38:34 +0200	[thread overview]
Message-ID: <87sg1anevp.fsf@gnus.org> (raw)
In-Reply-To: <123777d9-e748-4744-9db1-72889a1dcc8a@default> (Drew Adams's message of "Tue, 23 Apr 2019 06:10:24 -0700 (PDT)")

Drew Adams <drew.adams@oracle.com> writes:

> Now try this instead:
>
> (put-text-property 1 10
>   'help-echo (propertize "rstuvwxyz" 'face 'custom-changed))
>
> The propertized string is not used.  The text property `face' is set
> correctly, but the tooltip displayed ignores it.

So the test case here is basically:

(tooltip-show (propertize "foo" 'face 'error))

This was apparently fixed earlier this year in Emacs 28.  The code is
now:

          ;; Use non-nil APPEND argument below to avoid overriding any
          ;; faces used in our TEXT.  Among other things, this allows
          ;; tooltips to use the `help-key-binding' face used in
          ;; `substitute-command-keys' substitutions.
          (add-face-text-property 0 (length text) 'variable-pitch t text)

So I'm closing this bug report.  If this is still a problem (there's
some difference between different architectures), please respond to the
debbugs address and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2021-06-22 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 13:10 bug#35393: 26.2; `help-echo' text propertized with `face' is not shown in that face Drew Adams
2019-04-23 13:33 ` Drew Adams
2021-06-22 14:38 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg1anevp.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=35393@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).