From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#50552: 28.0.50; Add context-menu-occur Date: Wed, 29 Sep 2021 10:00:11 +0000 Message-ID: <87sfxnu2fo.fsf@posteo.net> References: <87ilz5d9a1.fsf@posteo.net> <87o88xu13p.fsf@mail.linkov.net> <87a6khd316.fsf@posteo.net> <8735q8g9dj.fsf@mail.linkov.net> <874ka4v5ae.fsf@posteo.net> <875yujc2kq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50552@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 29 12:06:04 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVWTT-0009Sl-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Sep 2021 12:06:03 +0200 Original-Received: from localhost ([::1]:53092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVWTS-0001Sw-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Sep 2021 06:06:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVWOd-0003SF-8o for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 06:01:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVWOd-0007Kb-0N for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 06:01:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVWOc-0004vi-IA for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 06:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2021 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50552-submit@debbugs.gnu.org id=B50552.163290962218885 (code B ref 50552); Wed, 29 Sep 2021 10:01:02 +0000 Original-Received: (at 50552) by debbugs.gnu.org; 29 Sep 2021 10:00:22 +0000 Original-Received: from localhost ([127.0.0.1]:47805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVWNx-0004uX-Sx for submit@debbugs.gnu.org; Wed, 29 Sep 2021 06:00:22 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:46001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVWNv-0004uF-K0 for 50552@debbugs.gnu.org; Wed, 29 Sep 2021 06:00:20 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 41E10240026 for <50552@debbugs.gnu.org>; Wed, 29 Sep 2021 12:00:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1632909613; bh=LtS6zBL9arVUImyAcpPWyGyrLvFb47EEbvYbIuXNrHo=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=apeq6kO4EkLPkF7L+I3DBj4cmlnFAjjYKwDj3ZqvsG687Lkz2Q7T3R3/Ed2M8vYXt MbTohuHWcW+042WbxDVx0ZFYEdllS7qIgrtLSzkS0/fNrs0eI780kU1PoIaLKTiJjI RgOm7sMgqJS+ACN0H9ClF+CqhBT+5UTfapkJ6Z7PUTkTdOOW+m8j3evA33n6KgRLn7 0w6xnjz5TceWzDLQhsZ1lvUikKj72XotuqZD86KgQrMqCFk/hPv4AUZa7OL5zaSQNG bL31ognPMsgEguPzAVASLzMcU7hFlbTBScmCsgfqrxzKNYswMOv+QD3R43nBse3czc Lta+QGHc8ldwA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HKBgw2sYYz6tmG; Wed, 29 Sep 2021 12:00:12 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <875yujc2kq.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 29 Sep 2021 10:19:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215829 Archived-At: Juri Linkov writes: >>>> I see, but I wonder why dictionary.el directly manipulates >>>> context-menu-functions with add-hook. >>> >>> The reasoning was the following: by default, dictionary.el is not loaded, >>> so its context menu item is not used. But when the user wants to use >>> dictionary.el and explicitly loads it, then automatically provide also >>> its context menu item. >> >> On this topic, I am not sure how good it is to do this >> automatically. One effect seems to be that context-menu-dictionary >> inserts itself at an unintended place in the menu (in my case as the >> first item, even though I'd prefer it to be further down). Might it make >> more sense to autoload context-menu-dictionary and let the user manually >> add it to context-menu-functions? > > Then we need to decide what is the preferred way for the users > to add the dictionary menu item to the context menu. > > 1. One possible way is allow the user to customize context-menu-functions, > and manually paste context-menu-dictionary to the entry field: > > INS DEL Choice: Value Menu Custom function: context-menu-dictionary Why not use the new custom-add-choice function (or something along these lines) in dictionary.el? > 2. To allow using 'add-hook' in the user's init file with e.g. > > (add-hook 'context-menu-functions 'context-menu-dictionary 1) In my case I am setting context-menu-functions manually, without add-hook. I am not sure if that breaks anything? > In either case, 'context-menu-dictionary' should be autoloaded > like you suggested. So now I've changed dictionary.el according to this, > thanks for the suggestion. Great, thank you. -- Philip Kaludercic