From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Thu, 14 Oct 2021 19:25:51 +0800 Message-ID: <87sfx3luf4.fsf@yahoo.com> References: <87czp6ysw7.fsf.ref@yahoo.com> <8335pz3dli.fsf@gnu.org> <87r1dj4q4m.fsf@yahoo.com> <83zgs71su7.fsf@gnu.org> <87k0jb4k5l.fsf@yahoo.com> <83sfxz1pw0.fsf@gnu.org> <87o88m14g0.fsf@yahoo.com> <83sfxyxeer.fsf@gnu.org> <87h7ee1252.fsf@yahoo.com> <83pmt2xcox.fsf@gnu.org> <87lf3myhlb.fsf@yahoo.com> <87a6jzvnpq.fsf@yahoo.com> <83o88fom1k.fsf@gnu.org> <871r5bvex8.fsf@yahoo.com> <83v92mkzft.fsf@gnu.org> <87k0j0rwo3.fsf@yahoo.com> <838rzbddfa.fsf@gnu.org> <878rzbd1w5.fsf@yahoo.com> <83wnmgkmok.fsf@gnu.org> <878ryvnain.fsf@yahoo.com> <87lf2v7te4.fsf@gmail.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24105"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , larsi@gnus.org, 50660@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 14 13:27:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maytA-00067G-M8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 13:27:08 +0200 Original-Received: from localhost ([::1]:48508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mayt9-0002NV-CX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 07:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mayt4-0002NN-7p for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 07:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mayt3-00073O-Vw for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 07:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mayt3-0004gY-SD for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 07:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50660 X-GNU-PR-Package: emacs Original-Received: via spool by 50660-submit@debbugs.gnu.org id=B50660.163421077017949 (code B ref 50660); Thu, 14 Oct 2021 11:27:01 +0000 Original-Received: (at 50660) by debbugs.gnu.org; 14 Oct 2021 11:26:10 +0000 Original-Received: from localhost ([127.0.0.1]:34831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maysD-0004fR-RT for submit@debbugs.gnu.org; Thu, 14 Oct 2021 07:26:10 -0400 Original-Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]:44452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mays9-0004es-Gb for 50660@debbugs.gnu.org; Thu, 14 Oct 2021 07:26:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634210760; bh=lSVN71ldcDLuX66cZ4AeijLp9yqUHSVfhZaPSWE/Ww4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=m225dWGMh/tZdo1SKMfJ9GA5QhxQY/CyyuKVP7eMoG4XsnmdziYknE1Lb/pYwP1++mFoivGSl5MwzpU7FqaigWtXSIckQaKemvnDraEKLlrzItLi8SfI/w/4TfF33SnTQlUKLZZJc26zo3MBOgX4BEbCSHffjDKfGSQU2xqp2dQSAhw1AjIOima55+L5D6GWY6sRTE30TGQqCQ9kDST4YgGSdgGMYMhDNFBVhEgUtWYOfjeQIFy9CE9VVMt871Hm9MkEqCIBKF+EAjBP6BMcQK7SO1+ua3MRo5VBZd8/RqP2vasi51gqzyc3uNbjZzx4EJyGGG0Bkk3F83rNMWC06A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634210760; bh=8XSlZ4Im8IPewQEVNiqHFni8M5R7ZmsHXlkkV2fol11=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=c1+j0PRcnmgfMDaFpOXZal2+vEmMsBNjVmWSW65A+yplHxZs1RLzBENf/sA/EAQqy1kyYJitiH7RYD00k49djnVnGyenncXuHLzO/vGGnlsC8t5znmV9dkvIyHVXeCrlfFxeL8uJzpE89lA3B2GMslKGIo4jBIEcO1FuVx//X1WulyUZpLsh/DFMdlXN/gaMFGH1lWbvpPk5E5VDd1ETyL0WC0MM/2/sgBgfyLpzd2TTPPq10zqcD0Ix/Bz/z6FxTaamNA3H6KJJYBdEGG3IyxmjdCyYjXyge42P/CJJVct5rMboZiZgkS1ozLk9/5g3/R3p1QMXiQK9N6z6gd1haA== X-YMail-OSG: St0LyPcVM1m_.xDQsLjKHIhmcV99P5UxgHEfdYQZ1sJjgp4QHzOlDDQEWfL7DBe 4jJbA.YxwJ2tst7qzU0tnZ5Cpiz5Uxo1RSKVuqqcQEl7C4A2Chb.NsibgQS2wnjKwikP8rZ1Twr_ c1MgMsP1SIds4TWCjJ7sPSYEqIfs2LCz7pyCim9GDDPMwIPB8C8yOs5rBGV1kpa732nJVNB21S0T _4dNJGKodgEvfy5M6Uo6dgkVnYYppZz2c7dlxibJgKy2Cn0lhckJJwv_l3s1iT_6yojd4Mzq35sm ldb7anBR86a9zz64mDc7UysPGKic2GQl4uCoQf0rzKPz12gq9wFo74wdrHGmtO.oXVtNJsfIoNlH GdVhEX5inolQUhZhH_F9s8uRCAKwT.lbiQCsWdFmarybaQsMePx1p4Xf82f6cVjBxz2ABp8oquXn R9DWdVZGLMYQez0ZxRgSt1T7DKnMlcaZCGBXlMhwF_JBI4YJ_uZ4m3QX0IDX6.nE3kYQ29OhjSim 7iyA4jqEXvKWf.wUfbBF6gOWfQ2Cru5JQsKqIw_zoufW8z98k8LvWtShZ5sXOYKAg.QVKb6ieKjq yxBcSWN_HZC1xmmkOGzwihn_hnbJpYE8B3.B9WZqEnn0TsbgSszaPDXC4p021TS.uuTpwRXCKtDa 0pS5eyjFhbvv_1dgiP_9fIPcra6K4l.CXo_7K88KlWWesEopLUIOqC4CuGQ.kzOdtL53u9KUdlFA WrTsPRAW3eST8bpHh55muQJq4GuXw3EuxJfYXezoBN5grGJ6rmtEadC.In3bNiQ4C5eT78w9Sdkc hLc8P5e1TDTZMcrDoWKoWoxKPrJjwcScfteKRnpx1c X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 14 Oct 2021 11:26:00 +0000 Original-Received: by kubenode517.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d121bca40d8f8900ef581f0fb5d6d0e5; Thu, 14 Oct 2021 11:25:55 +0000 (UTC) In-Reply-To: <87lf2v7te4.fsf@gmail.com> (Robert Pluim's message of "Thu, 14 Oct 2021 13:11:47 +0200") X-Mailer: WebService/1.1.19116 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217214 Archived-At: Robert Pluim writes: > Po Lu> + struct face *face_for_box_line =3D s->face; > Po Lu> + > Po Lu> + if (s->hl =3D=3D DRAW_CURSOR && cursor_in_mouse_face_p (s->= w)) > Po Lu> + { > Po Lu> + /* In this situation, the cursor is in the mouse face, = but > Po Lu> + s->face hasn't been updated with the mouse face yet. */ > Po Lu> + face_for_box_line =3D > Po Lu> + FACE_FROM_ID_OR_NULL (s->f, MOUSE_HL_INFO (s->f)->mouse_face= _face_id); > Po Lu> + > Po Lu> + if (!face_for_box_line) > Po Lu> + face_for_box_line =3D FACE_FROM_ID (s->f, MOUSE_FACE_ID); > Po Lu> + } > > This chunk looks like it=CA=BCs repeated a lot, perhaps break it out into= a > function? Actually, on second thought, I think a better solution would be to set s->face to the mouse face in x_set_cursor_gc if cursor_in_mouse_face_p. Any thoughts? TIA.