From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Thu, 21 Oct 2021 04:45:36 +0200 Message-ID: <87sfwvjdtb.fsf@gnus.org> References: <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> <87tuhcc1u1.fsf@gnus.org> <83tuhcaqad.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 04:46:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdO5u-0009Vp-FB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 04:46:14 +0200 Original-Received: from localhost ([::1]:54272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdO5r-0004aY-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 22:46:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdO5i-0004aM-5C for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 22:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdO5h-00031Y-SQ for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 22:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdO5h-0005RO-Mp for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 22:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 02:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163478434920895 (code B ref 50752); Thu, 21 Oct 2021 02:46:01 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 21 Oct 2021 02:45:49 +0000 Original-Received: from localhost ([127.0.0.1]:55804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdO5U-0005Qx-N0 for submit@debbugs.gnu.org; Wed, 20 Oct 2021 22:45:48 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdO5S-0005Qj-WB for 50752@debbugs.gnu.org; Wed, 20 Oct 2021 22:45:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=02GSYTDjammwxeIFRY/2YqZx5vacaOjhx8WwKyHcsNU=; b=BURIqhnmwYLLBAZ5YgpTWBslZ3 FLVCccGUB9KP5pKD/IJVO+2ZFRrwcgTmIcIyIidr2TVVwxh2rpM9fkG702teUO7z0ROrNpfUjAa2G blU/4gVYp+HXkmyxZSrH6mxjh7KSW9PMhEdkY5w8oM9T6c71VZQ3iAeJb8gba4rAosUE=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdO5I-0005Ff-MC; Thu, 21 Oct 2021 04:45:39 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVPSZeWZJemqNJL J1z///9SRQkfAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UKFQIpL0s56UEAAAGPSURBVDjLbZSLscQg CEUhNCDaQLQCMvTf2+OjxrxZd3Ym4Xj5KQGYC0euDt9Vx/hJLrdwQef3P0EBIAU28gG3kIo9EIzB rx19u9uRtB5hmMFIahAOZ6blQupLsFxbcnXT6FwCVJdk3MhNN3HJnTWUWsJGlrAKwwQ4kIm2QtG2 JmAuoseyrVm9RYA0ccSy8lclkuBJINahFIDSAhx5LVB0ecp6eEaHFXuBiydYuU5XigvsRPlJgLMp /tIOhWBEVwfUngTN0y2zEENmonDl4I1BCitGlF4DqFeC4WQW+CyFvWOYnieB7QQJ8laSp+iORK3C CaZCKADtyj1IKCRC03FKloGhTFXgPFdz1xLQihBZ+b9MyeyVX604QQfyAsQAD5PYnZx2v7NeYfMm MkF7ARa2wejooDxlhSDB7rPUvWPWDLvx6/bwqDFrzN3bvyUQs2fAf7UJvKD7dA5r8jBwjCDWmOde HZUDQO3pzZPjE1zDNlcrxgfwlOD+MNi9+fja34zPd+ElHX6v63iWEyDti/wHpVlir3d8zIMAAAAl dEVYdGRhdGU6Y3JlYXRlADIwMjEtMTAtMjFUMDI6NDE6NDYrMDA6MDDcWq4VAAAAJXRFWHRkYXRl Om1vZGlmeQAyMDIxLTEwLTIxVDAyOjQxOjQ2KzAwOjAwrQcWqQAAAABJRU5ErkJggg== X-Now-Playing: Alice Coltrane's _Kirtan Turiya Sings_: "Rama Katha" In-Reply-To: <83tuhcaqad.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Oct 2021 14:28:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217732 Archived-At: Eli Zaretskii writes: >> I thought it made sense to be conservative here and do it "properly", >> instead of open-coding an A-Za-z upcase/downcase ourselves. > > Why is it a problem to do it ourselves? It's a simple and very > efficient operation, and it will always be correct. Hopefully. >> And doesn't >> uniprop_table just return the table from char-code-property-alist here? >> So it's an assq from a short list. > > It returns a char-table (so not really a short list), and it loads a > file when first called. It isn't incorrect, just too heavy for such a > simple job. These case tables are predefined (they're in `char-code-property-alist' on startup with -Q), so calling uniprop_table here doesn't load anything, and it doesn't cons anything -- it just does an assq on char-code-property-alist and returns the char table. Unless I'm misreading the code completely. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no