From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in batch mode Date: Sat, 04 Dec 2021 20:59:13 +0100 Message-ID: <87sfv83zvy.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2718"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52281@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 04 21:00:49 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtbDE-0000SK-Es for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 21:00:48 +0100 Original-Received: from localhost ([::1]:40646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtbDC-0003hz-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 15:00:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtbCU-0003fo-3d for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 15:00:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtbCT-0003dB-Q8 for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 15:00:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtbCT-0001p3-ME for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 15:00:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 20:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52281 X-GNU-PR-Package: emacs Original-Received: via spool by 52281-submit@debbugs.gnu.org id=B52281.16386479656925 (code B ref 52281); Sat, 04 Dec 2021 20:00:01 +0000 Original-Received: (at 52281) by debbugs.gnu.org; 4 Dec 2021 19:59:25 +0000 Original-Received: from localhost ([127.0.0.1]:55048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtbBt-0001nd-Ce for submit@debbugs.gnu.org; Sat, 04 Dec 2021 14:59:25 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:40482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtbBr-0001nN-7l for 52281@debbugs.gnu.org; Sat, 04 Dec 2021 14:59:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=If7Iyx+Ecm3iAHLfoq7pG96nsLYuYky0qzt4bddATMA=; b=nUCKdDCiZYWHGAKdOHy+jarYfF ChEX8Tbdw4w+rno2o7d3KBOzIRMfVA00i1YWdgOK9FQ0kowxMD2GPRxDKmXWSiYnrFiZrciakIc97 DJSU2bSCXGXsvhW5AqYRa4I7MwXzHIP43mYXvJ63qczmqkioKU0Ocyo/dwH2hkuwE6Lg=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtbBi-0008Qp-Co; Sat, 04 Dec 2021 20:59:17 +0100 X-Now-Playing: Kraftwerk's _Exceller 8_: "Ruckzack" In-Reply-To: (Philipp Stephani's message of "Sat, 04 Dec 2021 19:24:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221494 Archived-At: Philipp Stephani writes: > This is inconsistent, and causes parsers (such as Emacs's compilation > mode) to incorrectly parse these messages. I think messages in batch > mode should never be broken up. The following should fix the issue: diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index 36b275e2d3..1d061364a0 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -307,7 +307,9 @@ display-warning 'type 'warning-suppress-log-warning 'warning-type type)) (funcall newline) - (when (and warning-fill-prefix (not (string-search "\n" message))) + (when (and warning-fill-prefix + (not (string-search "\n" message)) + (not noninteractive)) (let ((fill-prefix warning-fill-prefix) (fill-column warning-fill-column)) (fill-region start (point)))) Does anybody have an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no