From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53769: Implementation of X11 MULTIPLE selection is incomplete (with patches) Date: Fri, 04 Feb 2022 12:57:58 +0800 Message-ID: <87sfsz44a1.fsf@yahoo.com> References: Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2457"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 53769@debbugs.gnu.org To: Vladimir Panteleev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 04 05:59:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFqgi-0000T3-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Feb 2022 05:59:12 +0100 Original-Received: from localhost ([::1]:46336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFqgg-0003kQ-FB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Feb 2022 23:59:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFqgZ-0003kH-0v for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 23:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFqgY-0007ql-JC for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 23:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFqgY-0006vO-Fb for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 23:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Feb 2022 04:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53769 X-GNU-PR-Package: emacs Original-Received: via spool by 53769-submit@debbugs.gnu.org id=B53769.164395069726560 (code B ref 53769); Fri, 04 Feb 2022 04:59:02 +0000 Original-Received: (at 53769) by debbugs.gnu.org; 4 Feb 2022 04:58:17 +0000 Original-Received: from localhost ([127.0.0.1]:58580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFqfo-0006uK-P0 for submit@debbugs.gnu.org; Thu, 03 Feb 2022 23:58:16 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:37358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFqfm-0006u6-GI for 53769@debbugs.gnu.org; Thu, 03 Feb 2022 23:58:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1643950688; bh=50UXn/kBD32OW3B+HrP/qqYgDvCjNO9jtQN0aHgke7E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=hnAB6UV/vYZhhj854Uil7x4MugcZWeR8F9hEhNffoF0gwik0cMDVFS3jcLTVzPQpJsS9p+yTXEj55V5yR//TyDut70Owfm2a0PvRPcY9vgFIqtl+tAuK4v2PmNcl1etybQ2URLo4DEh7No3P7hHUwfp5C4z0ri5KM0jhVEOeVD6hpOfPE9/gRwb+jexzFDBXWWYdQ/8qijoqJUOUt7nyv/Kk0UnN6jXFKhAGoEKJOmgtx8uPmtPNtG5QpYz8bnldmbLFR/vqY7a5uhOASK4d8MkNvL3meYTG2aaIOjUrJ+yWno7tURVwViXFmD/dblIpFyiIaXtj244JOLs5e/kBDw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1643950688; bh=owM9+/YkcqBBJZyIPryN4+3CgQ7qx1DK9NOk7dskFgz=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=osv9cOPu4m5vqPI4fox4U9FeSwo9K1PUvRI57M4Tsf2d7h3i3Bi543HVlAlsAeupJfNAb5DdlTuRsAmSzZjw4MS8jM50jrL2XCC5JbXMpccZbCC6EwB3kZA8bPY0N8D0egIgg9CBbTRFX6TQEQjMwNODVaELL4yi4BMYUhrf1OdyKaPN+AQy8VlhbfvVcGqzQ/vxw7MlkZuKTMdqVM6IRDtEySPl1egW6pUpd9G9Y4iU3uw/oIqVtd9265gLdZSxn6Zefj7vlGcbuBVhxOAVel6aLd42sYEbsjJK9FBj19Rw9QOk+UhPW6b9duqoyCgQHc0ikFea502HKG/jIpT8DA== X-YMail-OSG: rUkEEgkVM1n76JqZ1fVqabCT8akjpRQDiNlmxx_K4t11o3GQTSWO7pxT2CAudty .oTM6mJMwkZ5GoohCnfy6EM51TxS1fONqd2F_gVtVYwFTvbOjA2vmSobIVkTMLYO6P9V.xsRJKeA w0q.JA9_UX0Drnsw.spDSZhdV58AbZ9DFg01r.7ze6fm8jYnc95PVkonyHQqRiMirTLcE9QUmTjM 4ua9ptzReXufj4zmFwLUkeqru34eUpEUO0G4.DrcY2p40W_bmB8t2xy0ZWdOVVoGVoLokm7_3ikA 5zD7miik36aX419HUUBzhDBjblPhia.2cliOqdn3XaqY5G3NDMu47PVgRxHud_6RhzVGn9Bfsezb G5zJdheP2Ify9cdJNc.wXf1lQW7nthHn3dXbrsTQm8XkN4ERJCvutellT1hJRld97HVocC3ZGjsY r3paC_ueLWxSzq.R9fJYqrFAa4iJmmuU7K9hSm7gEWSuGQNmLOyJ94XafDFxnems6hrZ0TVDeCdC ezpXGat3NKUD5Us3CbLziBp_N1oSAshOP3A356oCsK7uJH0C1zZRvlwu89vCGg.rq.C2aRWGHJSP y8YzKykUxN_gSovb1bxjLs9603K4NQdWglPLxRGZqWpVqD07e28amZboMV8c18Rx_xdkVTkkNri3 306wnsTZ8TzNBDsm2Di2Z.588x14TKToKrM2qmI93l3b1J32vs6i1U7rhA5LBl1jS_9MGxHUFYoN HKI575cAT6qp4Qqs3QDduZ69_swHd3fgH.x9tkHwkwM6V4MSypsvHdyvuGQ..RMRDxnqBN8FZSgG UsnvkOve.L3svrJ1HEKQ5H6EiD9P1PxnMZ7ljmii5E X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Fri, 4 Feb 2022 04:58:08 +0000 Original-Received: by kubenode518.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID f796a91981d827a8b16ca4259209598c; Fri, 04 Feb 2022 04:58:03 +0000 (UTC) In-Reply-To: (Vladimir Panteleev's message of "Fri, 4 Feb 2022 03:01:43 +0000") X-Mailer: WebService/1.1.19711 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225959 Archived-At: Your change LGTM, but: > + if (! for_multiple && actual_type == dpyinfo->Xatom_INCR) We typically don't put a space between the "!" and "for_multiple" here. The surrounding code does it a lot, but there's no reason to introduce any more instances of that style. Thanks.