unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Vladimir Panteleev <vladimir.panteleev.md@gmail.com>
Cc: 53769@debbugs.gnu.org
Subject: bug#53769: Implementation of X11 MULTIPLE selection is incomplete (with patches)
Date: Fri, 04 Feb 2022 12:57:58 +0800	[thread overview]
Message-ID: <87sfsz44a1.fsf@yahoo.com> (raw)
In-Reply-To: <CAHhfkvyddsJGaYWS7PTYPhz82TwPpZ24idOXZwA8ab36cZy+4Q@mail.gmail.com> (Vladimir Panteleev's message of "Fri, 4 Feb 2022 03:01:43 +0000")


Your change LGTM, but:

> +  if (! for_multiple && actual_type == dpyinfo->Xatom_INCR)

We typically don't put a space between the "!" and "for_multiple" here.
The surrounding code does it a lot, but there's no reason to introduce
any more instances of that style.

Thanks.





  reply	other threads:[~2022-02-04  4:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04  3:01 bug#53769: Implementation of X11 MULTIPLE selection is incomplete (with patches) Vladimir Panteleev
2022-02-04  4:57 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-02-04 13:09   ` Vladimir Panteleev
2022-02-04 14:03     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-04 14:41       ` Eli Zaretskii
2022-02-05  1:02         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-05  1:07           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfsz44a1.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=53769@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=vladimir.panteleev.md@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).