From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies Date: Sun, 06 Feb 2022 15:52:13 +0000 Message-ID: <87sfswj8fw.fsf@posteo.net> References: <8735kx3zct.fsf@posteo.net> <87a6f4ieue.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10460"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, monnier@iro.umontreal.ca, pu.stshine@gmail.com To: thievol@posteo.net, 53805@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 06 16:57:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGjub-0002WR-Ko for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 16:57:13 +0100 Original-Received: from localhost ([::1]:48412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGjua-0000wS-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 10:57:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGjuR-0000vi-7j for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 10:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGjuQ-0000r2-TG for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGjuQ-0003gK-Ts for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 10:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Feb 2022 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53805 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Thierry Volpiatto , "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Philip Kaludercic , "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Stefan Monnier , 53805@debbugs.gnu.org, Xingyu Pu Original-Received: via spool by 53805-submit@debbugs.gnu.org id=B53805.164416296314044 (code B ref 53805); Sun, 06 Feb 2022 15:57:02 +0000 Original-Received: (at 53805) by debbugs.gnu.org; 6 Feb 2022 15:56:03 +0000 Original-Received: from localhost ([127.0.0.1]:39637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGjtS-0003eL-MS for submit@debbugs.gnu.org; Sun, 06 Feb 2022 10:56:03 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:56561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGjtQ-0003dk-NI for 53805@debbugs.gnu.org; Sun, 06 Feb 2022 10:56:01 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C666D24002D for <53805@debbugs.gnu.org>; Sun, 6 Feb 2022 16:55:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644162954; bh=NgPJByE8fLXxldfmQIernQP/xSOxRGQGLO0DsGLizpE=; h=From:To:Cc:Subject:Date:Autocrypt:From; b=TnGBKHEZSQ2IOhBc7mnjTjcL/lH3AFbK+7S575eLaZVgB0EvJ2cplujeb9gd3Rjg+ 04XSgN/SVZs3SisGSHOuMNx4DpaHDhI8vtDB2w7om5zPnDvrR0A1DIa9j1q1NU9pjF GvSe/keb3Rv7W2BLnPLYpuypnaTRKDh/BR5Xe/2zKonDaHWPpU74IjN03+ogfI8BPe HFB2ohmDIxJQS31oprF40RaJ+ROI0KE4eGNZ4C90U/5evbvjYZcfnsdgwAQzsFuHnC tWoh+mWMb9zbXgb6M18+ut7QoCv/s7t3wcoAllaHn3za3+hbIfFytN5QML0e06gmJY RZE9gURQSuGkQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JsDQH27c5z6tm5; Sun, 6 Feb 2022 16:55:51 +0100 (CET) In-reply-to: <87a6f4ieue.fsf@posteo.net> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226155 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Philip Kaludercic , Thierry Volpiatto writes: > Thierry Volpiatto writes: > >> Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >>>> It seems to me that the core of the issue is that the ELPA build system >>>> overrides the existing -pkg.el files, by trying to infer all the packa= ge >>>> metadata from the main files (helm.el, helm-core.el). If as in the ca= se >>>> of helm and helm-core these are empty, this leads to unexpected result= s. >>> >>> The best course of action is to fix the upstream. >>> They simply shouldn't have any `-pkg.el` file. >> >> I disagree, in the simple case of async package this didn't cause proble= ms, but >> here it does because we have two packages (helm-core+helm) coming from >> the same git repo. > > What is the issue in this case? The ELPAs already have packages that > share common upstream repositories. The main issue here that I see is > that helm.el and helm-core.el There is no helm-core.el file. > don't have Package-Requires headers, which is why the dependency list > is currently empty. Since long time I asked to not have such informations fetched from source files but from pkg.el files, which is cleaner. =20 >>> We will generate the `-pkg.el` in any case because we include more >>> information there than what the upstream will have put (e.g. we include >>> the commit id from which the tarball is built), >> >> So what is the problem? Just append the informations fetched from the >> upstream *pkg.el files to the *pkg.el file you are usually building. >> I guess it is what Melpa does more or less. >> >>> and and modifying files that are under version control tends to lead >>> to problems. >> >> You are anyway creating a new *pkg.el file so why do you want to modify >> the original *pkg.el files? > > This is also what the patch I proposed above would do. Or rather the > -pkg file is parsed, and later overwritten. Looks good. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmH/74MTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk5WOC/4+fitBssDsiWLHwTfJ5UakMSQqtOPc rLMZbxb1W4R2B/0Xfl5QoRURYgGXPbLIVs+JWJykncAKFopa7Nsu6it+A4VJO/bX Fw5ruLR5ytYgr9p9QaymoMAXVqzH+muwoILGkuD1aSAzJvaif6/z9Iv2BgV1qjxa iZA6k+SfLYlQ8ffDEFfV3Jguei3Ncr/HValPzA/P65UIeC4nzt8AaZjzDDKUaT9P Or0Ef+vUh3YNPyC6RhLXGJx531Z/DBdAhXsHGHM5QLSWmCavIYeVN6t0TbI10FYC zHsNLJJ5jKhJdsXKGjFfXYVBMoUulqIPYX5ePfiB4JYiJXA8LwVJ3APsk4HZdKfd Jal8GVyOYRxt0NXXKz2pOqV0YcD/7xn0T15f+tceW839Gs1IkCKpfRgr4HJpw8P2 Q1DNVwiU9YzGm/PBr2X/uq7x398nKq3kfbvF24XqtQ87gkJR7u3hpjgbOTU7jY4L 3UgBB7TJAPf1tVFFF0WPyxJ0KHp/As0bI9g= =8lg4 -----END PGP SIGNATURE----- --=-=-=--