From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 06:47:50 +0200 Message-ID: <87sfpxhkuz.fsf@fastmail.fm> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6328"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" To: "M. Ian Graham" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 06:51:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njw7W-0001Ou-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 06:51:15 +0200 Original-Received: from localhost ([::1]:53740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njw7V-0004O0-Mf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 00:51:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njw7L-0004Ns-Ax for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 00:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njw7K-0004BY-9L for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 00:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njw7K-0002hK-6u for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 00:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 04:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs Original-Received: via spool by 55149-submit@debbugs.gnu.org id=B55149.165112145610359 (code B ref 55149); Thu, 28 Apr 2022 04:51:02 +0000 Original-Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 04:50:56 +0000 Original-Received: from localhost ([127.0.0.1]:44940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njw7E-0002h1-FM for submit@debbugs.gnu.org; Thu, 28 Apr 2022 00:50:56 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njw7B-0002gl-QL for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 00:50:55 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5BA205C00FD; Thu, 28 Apr 2022 00:50:48 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 00:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651121448; x=1651207848; bh=G4PhP5xVpg 9RAC7xhBk2VhD+zHW2GoxgqxDsjOcST7I=; b=SbTH8pBPQNFPW+fTmRlBy+VhC5 QTtsIYZBqkkPpmN5mSvn6p2IyrC11C9JzyQJ1/O4ZtHROoJOJJdYkjkrw+dxsYzR JSLUN1PnmJG3m6a9rZAymCypw8tz+A4gYgjgZDsKT2c8ryWSJokPpzOOkpKVh6tq UaG9eT/Y9siHQgPGW1DyypByeCF5jI7G6hNl2HN2TzF4KEYDY2uDc2tHhngfYDu8 HIRU+qmQO1Rub5nfpZKSYBI3nfcbKkHheMmbZDHVxkEzxzah19WpXmzepdB+E6JF UUvKsddA9tKvCvT3m2OUiydg9CB5MjRgVbCMISz0XKs6cPNsvwQUjtwZbC6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651121448; x= 1651207848; bh=G4PhP5xVpg9RAC7xhBk2VhD+zHW2GoxgqxDsjOcST7I=; b=y altGWUEaRh66FvuNe1T5vEmmoEU5OesCsz0VUKmRAudT58CmWHdwP+Wo4JkjBhyQ 0DqZTfidjtVhzdbYDtXGhTPil3r0l9h3/cUUcCpbDgKZsl1ZIu47yRIpa0fINRn5 rmyBXqAHbWtH2p+bx8Q27zS3h5fBAxOPIyD+kFT80EnipiujjOuymQTnlnzsFl1p L414BZy3MuBIhNRDtzeUk5IaZmpxptMX+ko4mIw0yi8dMV164W8qzmxKsyR8iGTU kouI7YZf5k1oA5NjtP0GGHTXBV4h3Zc1kJdG41Gfw+4pVfH7Z2SLWI3bjHWE1IfI 0QA8ukzvd70msFukDZiuw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvvefuffgjkfggtgesthdtre dttdertdenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhhohhrnhesfhgrshht mhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepgeffiefhjeekueeiueehteetgfehte fgffegfeduheejiefhgfehteektefhvdfgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhrnhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 00:50:46 -0400 (EDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230828 Archived-At: "M. Ian Graham" writes: >> With stock-emacs when doing "emacsclient foo.txt", it just prints >> "Waiting for Emacs..." but finishes immediately. > > Hi, quick clarification on this: As far as I can tell from my own > observations, all emacsclient breakage here is a downstream > side-effect of magit/with-editor's advice calls somehow getting messed > up. Oh, you are right. But I was able to extract (at least one of) the problematic with-editor advice(s) which cause the breakage. Save the below as bug-recipe.el: --8<---------------cut here---------------start------------->8--- (advice-add 'server-visit-files :after #'server-visit-files--with-editor-file-name-history-exclude) (defun server-visit-files--with-editor-file-name-history-exclude (files _proc &optional _nowait) (pcase-dolist (`(,file . ,_) files) (when (cl-find-if (lambda (regexp) (string-match-p regexp file)) '("don't care")) (setq file-name-history (delete file file-name-history))))) (server-start) --8<---------------cut here---------------end--------------->8--- Then start emacs as "emacs -Q -l bug-recipe.el" and you'll be able to perform my "stock emacs" recipe, i.e., emacsclient foo.txt => finishes immediately emacsclient -c foo.txt => doesn't display the foo.txt buffer Bye, Tassilo