From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41793: `comment-only-p' erroneously flags blank lines as comments Date: Mon, 09 May 2022 13:14:44 +0200 Message-ID: <87sfpj7yaj.fsf@gnus.org> References: <20200610175331.GA23889@bb84> <20200610185251.GA25375@bb84> <871re54mmc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28849"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 41793@debbugs.gnu.org To: Toby Cubitt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 13:31:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no1cH-0007J3-BM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 13:31:53 +0200 Original-Received: from localhost ([::1]:45894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no1cG-00051V-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 07:31:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no1Ly-0007Gj-S9 for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no1Ly-0001e6-Ey for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no1Ly-0008AB-7e for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 11:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41793 X-GNU-PR-Package: emacs Original-Received: via spool by 41793-submit@debbugs.gnu.org id=B41793.165209489631352 (code B ref 41793); Mon, 09 May 2022 11:15:02 +0000 Original-Received: (at 41793) by debbugs.gnu.org; 9 May 2022 11:14:56 +0000 Original-Received: from localhost ([127.0.0.1]:56376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no1Lr-00089c-S0 for submit@debbugs.gnu.org; Mon, 09 May 2022 07:14:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no1Lq-00089M-0f for 41793@debbugs.gnu.org; Mon, 09 May 2022 07:14:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FILU1U/KbAscBi7qWuk2wMRh4nBXbj96KdRaM9P71NE=; b=fq4cCqWetl5ggtKtYLlxNvDeN9 SPnOPbhAPgLXHD646cKz4b/dBZNXVRil3+i9FWnL3vpuK7fo6JdXaGMrqZdVcU8uCmQI6E/GtFWPY /E4LhZXV5GduC1SpfluAi92fJuiACws8Rk2bu0gKEcNML8QIZZ/7jU1SNyPeUpUFEkNA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no1Lg-00055G-W4; Mon, 09 May 2022 13:14:47 +0200 X-Now-Playing: Grace Jones's _Living My Life_: "Inspiration" In-Reply-To: <871re54mmc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Jan 2021 07:11:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231724 Archived-At: Lars Ingebrigtsen writes: >> Gah. That attempt breaks flagging of comments separated by >> whitespace-only lines. Maybe this? > > Do you have an example of when that fails? The test was ;; foo ;; ;; bar where comment-only-p would give the wrong results. Anyway, I think it's ambiguous whether whitespace only should be a comment or not. The current algo considers this to be one comment: ;; foo ;; bar And I think that's correct. If we consider whitespace lines to not be comments, this would change how our comment navigation commands work. So there's some DWIM in this area, but I think how it currently works is basically the way we want it to work, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no