unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: "C. Michailidis" <signal3@gmail.com>
Cc: 56110@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#56110: 27+; switching from line-mode to char-mode
Date: Tue, 21 Jun 2022 14:20:16 +0200	[thread overview]
Message-ID: <87sfnyw6m7.fsf@web.de> (raw)
In-Reply-To: <87wndaw84w.fsf@web.de> (Michael Heerdegen's message of "Tue, 21 Jun 2022 13:47:27 +0200")

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Stefan, how would a fix look like that fits your intention?

This maybe?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-WIP-Fix-56110.patch --]
[-- Type: text/x-diff, Size: 916 bytes --]

From db062f00cbd4cdf5934237dee3350046a40f0482 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Tue, 21 Jun 2022 13:41:51 +0200
Subject: [PATCH] WIP: Fix 56110

---
 lisp/term.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/term.el b/lisp/term.el
index 94bf13e973..a8e44b4c34 100644
--- a/lisp/term.el
+++ b/lisp/term.el
@@ -1467,10 +1467,10 @@ term-char-mode
       (when (> (point) pmark)
 	(unwind-protect
 	    (progn
-	      (add-function :override term-input-sender #'term-send-string)
+	      (add-function :override (local 'term-input-sender) #'term-send-string)
 	      (end-of-line)
 	      (term-send-input))
-	  (remove-function term-input-sender #'term-send-string))))
+	  (remove-function (local 'term-input-sender) #'term-send-string))))
     (term-update-mode-line)))

 (defun term-line-mode  ()
--
2.30.2


[-- Attachment #3: Type: text/plain, Size: 204 bytes --]


[ I first failed to do this correctly because I had tried with
(local term-input-sender) instead of (local 'term-input-sender) - maybe
we can warn about that syntax missing that quote? ]

TIA,

Michael.

  reply	other threads:[~2022-06-21 12:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 14:20 bug#56110: 27+; switching from line-mode to char-mode C. Michailidis
2022-06-21 11:47 ` Michael Heerdegen
2022-06-21 12:20   ` Michael Heerdegen [this message]
2022-06-22 17:23     ` Michael Heerdegen
2022-06-22 19:22       ` signal3
2022-06-22 21:14         ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-22 22:23           ` signal3
2022-06-23  0:02       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-23 16:56         ` Michael Heerdegen
2022-06-23 21:45           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-25 12:17             ` Michael Heerdegen
2022-06-26  8:17               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-26 11:24                 ` Michael Heerdegen
2022-06-26 12:23                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-26 13:04                     ` Michael Heerdegen
2022-06-26 15:15                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-26 14:49             ` Michael Heerdegen
2022-06-26 15:08               ` Andreas Schwab
2022-06-26 15:30                 ` Michael Heerdegen
2022-06-26 16:01               ` signal3
2022-06-26 18:00                 ` Michael Heerdegen
2022-06-26 18:39                   ` Michael Heerdegen
2022-06-26 18:40                   ` Lars Ingebrigtsen
2022-06-26 18:44                     ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfnyw6m7.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=56110@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=signal3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).