From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54034: 29.0.50; Diff prettify broken for empty files Date: Fri, 24 Jun 2022 01:36:15 +0300 Message-ID: <87sfnvxb1c.fsf@tcd.ie> References: <87iltex7bo.fsf@gmail.com> <87v8xakm0i.fsf@gmail.com> <87bkz1jxd9.fsf@gmail.com> <87sfsbakqo.fsf@gmail.com> <87ee3v9ylm.fsf@gmail.com> <87wng1omfa.fsf@gmail.com> <87sfqpnzar.fsf@gmail.com> <87o81dnyxl.fsf@gmail.com> <87fsmpm6n6.fsf@gmail.com> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32763"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54034@debbugs.gnu.org, Stefan Monnier To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 24 00:37:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4VS8-0008Lk-9l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 00:37:32 +0200 Original-Received: from localhost ([::1]:52044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4VS6-0003Tu-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Jun 2022 18:37:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4VRf-0003TQ-Iv for bug-gnu-emacs@gnu.org; Thu, 23 Jun 2022 18:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4VRe-0007uF-Al for bug-gnu-emacs@gnu.org; Thu, 23 Jun 2022 18:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4VRe-0000zP-5v for bug-gnu-emacs@gnu.org; Thu, 23 Jun 2022 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jun 2022 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54034 X-GNU-PR-Package: emacs Original-Received: via spool by 54034-submit@debbugs.gnu.org id=B54034.16560237903761 (code B ref 54034); Thu, 23 Jun 2022 22:37:02 +0000 Original-Received: (at 54034) by debbugs.gnu.org; 23 Jun 2022 22:36:30 +0000 Original-Received: from localhost ([127.0.0.1]:40279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4VR8-0000yb-Fz for submit@debbugs.gnu.org; Thu, 23 Jun 2022 18:36:30 -0400 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:40749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4VR2-0000yK-Gc for 54034@debbugs.gnu.org; Thu, 23 Jun 2022 18:36:29 -0400 Original-Received: by mail-ed1-f48.google.com with SMTP id ej4so961863edb.7 for <54034@debbugs.gnu.org>; Thu, 23 Jun 2022 15:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uw/9fwrAxCX4vEfoM/Kr3C3elGO/n2tnyPTGmoKxH5g=; b=Kz3u19q8SEYocmxKmzlAu/ODG/py0eg5v/qB2BwBkQaEkYrLLQu+xC5FxZrWYrP28k 8ufb6xzhV7xO9upRbfoQYBJ8UiYD7qNsq/NsCBCRTWmemPxyXLHwD718GlijZV0Uaeq7 2cJrbtkc+LqH6j86tieM15U405qFRERJAeNyDqV0J5mEAwKJtK2QdVAunM1Y7Sw8ggIk qT+/ko+Q19NQitG6bRGbG/k9BTUAT5HeNYHYgP+NMOP+4wvfPKjr/zvdgDNPj2V+I9Ms exqivlEJ4DaeGlDUO6tXxyQ7TN7j12LKsDCmAthbygDfjO2Zg0kvDm7ijh9JVM2qQs3B qMmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uw/9fwrAxCX4vEfoM/Kr3C3elGO/n2tnyPTGmoKxH5g=; b=zvAE1gJAvtYO1VT/YEGX1yiuwH6Tn3J2+et1c0YzjYnhWvhZTo2Zc0y0rnoO5yU+ab 2Cw8MhM7+OyflmvXTgrTOb0czS+U4Er7go1JqgyiQw7QrKjhd/MJrudODlMUTbV1HTxc NKLjeolYnu3MajErk330ie0KgJYmWy8OpAXPP/p6dRDS6bH8L8mJWDkwDc0AFYfamK0N jYFwsk2/b0Zk3whC+DQEFO64FjqxBewcqlVrvYkpPcoA9YgWQKHP5SXl9tufYhBGu9rF MycCe0avgzC7nRMIlmesW5LtKyiY6VSqxgt2Wg3NSc6XrObM9lkl7NSP7FCqJkwzbWgQ 9IaA== X-Gm-Message-State: AJIora8MM4W1xQYrcy51gUgZbUMGQ4Kd8hkvo1MoE7CLlQvBUhamTB9a dIetq9tKi3IJWT6VPUolVhRTAg== X-Google-Smtp-Source: AGRyM1voHLaEt7b3qbJImgR8e8klajzkfQYl7IFaRCoy+mAYdu0p2VmlN4Br46Oj6xhZex0rngDwbA== X-Received: by 2002:a05:6402:5c8:b0:433:545f:a811 with SMTP id n8-20020a05640205c800b00433545fa811mr13622600edx.101.1656023778545; Thu, 23 Jun 2022 15:36:18 -0700 (PDT) Original-Received: from localhost ([2a02:587:322b:6f5e:dc92:136a:a7c4:dc8c]) by smtp.gmail.com with ESMTPSA id ah16-20020a1709069ad000b007262da9f513sm145838ejc.168.2022.06.23.15.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 15:36:17 -0700 (PDT) In-Reply-To: <87fsmpm6n6.fsf@gmail.com> (Matthias Meulien's message of "Thu, 07 Apr 2022 14:15:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235142 Archived-At: Matthias Meulien [2022-04-07 14:15 +0200] wrote: > From: Matthias Meulien > Date: Thu, 7 Apr 2022 00:11:55 +0200 > Subject: [PATCH] Display file mode information when diff font lock prettify > enabled > > * lisp/vc/diff-mode.el (diff--font-lock-prettify): Make regexp capture > file mode information. I think this gave rise to the following regression in the header when diff-font-lock-prettify is enabled: 0. emacs -Q 1. M-x diff-buffers RET RET RET [ Header now comprises 'diff -u ...'. ] 2. (setq diff-font-lock-prettify t) C-x C-e 3. C-x o g [ Header is now 'Deleted file'. ] It's not particularly jarring to see a header like that when diffing non-file-visiting buffers, but more importantly the same header appears when diffing any regular files via M-x diff. Thanks, -- Basil