From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin Date: Thu, 23 Jun 2022 21:40:25 -0700 Message-ID: <87sfnun07a.fsf@athena.silentflame.com> References: <8e21db9c-0100-998e-f280-81304e7ff61a@cornell.edu> <87mtecl82o.fsf@athena.silentflame.com> <40d9e52f-2041-b341-ff77-546ca7792791@cornell.edu> <87k09elrf8.fsf@athena.silentflame.com> <1de33903-4c55-e043-3754-726f7044f2d0@cornell.edu> <7e7daa2f-dbbc-cd0a-4958-2a2932b17837@gmail.com> <8974408d-91cd-aebd-7a5b-596a57bd640e@cornell.edu> <17d41105-b006-f9ad-af0b-ece84a7f5248@gmail.com> <040b3a36-459b-a94d-f879-7f45aac50bda@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32072"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) To: Ken Brown , Jim Porter , 56025@debbugs.gnu.org, Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 24 06:41:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4b8I-00087B-Bo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 06:41:26 +0200 Original-Received: from localhost ([::1]:58356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4b8G-0003iB-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 00:41:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4b7v-0003hs-9N for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 00:41:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4b7u-0002Er-V7 for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 00:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4b7t-0001Yv-SH for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 00:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2022 04:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56025 X-GNU-PR-Package: emacs Original-Received: via spool by 56025-submit@debbugs.gnu.org id=B56025.16560456345963 (code B ref 56025); Fri, 24 Jun 2022 04:41:01 +0000 Original-Received: (at 56025) by debbugs.gnu.org; 24 Jun 2022 04:40:34 +0000 Original-Received: from localhost ([127.0.0.1]:40481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4b7S-0001Y6-Ef for submit@debbugs.gnu.org; Fri, 24 Jun 2022 00:40:34 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:36714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4b7Q-0001Xt-Dc for 56025@debbugs.gnu.org; Fri, 24 Jun 2022 00:40:33 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id o8so1516770wro.3 for <56025@debbugs.gnu.org>; Thu, 23 Jun 2022 21:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=email-arizona-edu.20210112.gappssmtp.com; s=20210112; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version; bh=O6gOJLF8lJV2u4q/IMV/P2ID364rQ8qP8l2f2m55T0g=; b=Arh3CLr/h1pneTB32ZXmb29TVwlOn/tWVoMJju4VzQkrFMkhjtzBivgtGBdu/h+c/e srFk9ez1KmrTvsoC1oRiEmln1neXe1kbSEkoxdsU0TQ6JkMwvU60AJPH/T0fWnKre+m8 ddxEsaBiQcZNzhgCcsj3q3wGpvDSPvewSL9axPrILuVAB0fSvFW2BFjDOJxRsqwsdgLI MssB3jzWpvdfzOr7pDpUxQazImYlNO2WxETG73f+gu/pA+0BtdiAGcZ4gAy+8pogq4N8 i+Y5chU+22rKfLMhQGPIjr41ldprqsomyE8vF9O7c2tJMhRVdM06EMqkklIgZ6PZrFcV ewPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=O6gOJLF8lJV2u4q/IMV/P2ID364rQ8qP8l2f2m55T0g=; b=0oNNZBKx3NIFgvuHbOZSHs/sZ18o5pmbfrpziep1s9XcvUad80bsq4na65iKTnh9sP kTfAW4BfxUXe9wUYCPoqzU7sycQmw8wd0hQPRzrnYWX32rMvRzb+TGH7z5NoBUmSCclW cGFhKTVZAhcLj4vh/G6+it+1ww7d3pAuJmIvbHE5qoXeEtBBmk1UWeS3Yn/ib32b8AR2 YWfosBsNuDVpYUuX36UN+XqjCHFOhV5Q31mmP43EYoso7DERxLAijpJ+sv6qdPk8Gep6 4IUAsu0KMXMFiTAEzYoqh8luaCr7yC9G8Oszd0RUB1cAlzKB7cRBLrg0aZa+WOVBFbPs ucoQ== X-Gm-Message-State: AJIora9LrYfCqGNYaJyBCm6KKCAJHZuoMihqwKkGWLdggjMGbM/FNaaO JhE2CfD36jEKEGERVq+Yy3s1NcS63ioGlqZUNcEKZXoUONNO+wW/2z9B7KhJav8tZuQJFxpk1CG zP8Z93w== X-Google-Smtp-Source: AGRyM1sVgXW/lcYjC+fwQGNO7lp8pJsEfvHW0XIKEet+mhXZfCAN5PYygzErYTFkzRlgiQiQhE/StA== X-Received: by 2002:a05:6000:1a89:b0:21b:83a9:aa6f with SMTP id f9-20020a0560001a8900b0021b83a9aa6fmr11461724wry.33.1656045626384; Thu, 23 Jun 2022 21:40:26 -0700 (PDT) Original-Received: from athena.silentflame.com (coeus.silentflame.com. [2a01:4f8:c010:9ea2::1]) by smtp.gmail.com with ESMTPSA id y10-20020a1c4b0a000000b0039c587342d8sm5546885wma.3.2022.06.23.21.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 21:40:25 -0700 (PDT) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id 4E5921B6401; Fri, 24 Jun 2022 04:40:25 +0000 (UTC) In-Reply-To: <040b3a36-459b-a94d-f879-7f45aac50bda@cornell.edu> X-ua-ms: gsuite X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235146 Archived-At: Hello, On Thu 23 Jun 2022 at 09:18pm -04, Ken Brown wrote: > diff --git a/lisp/eshell/esh-io.el b/lisp/eshell/esh-io.el > index 3644c1a18b..1c4131cb07 100644 > --- a/lisp/eshell/esh-io.el > +++ b/lisp/eshell/esh-io.el > @@ -276,8 +276,8 @@ eshell-close-target > ;; If we're redirecting to a process (via a pipe, or process > ;; redirection), send it EOF so that it knows we're finished. > ((eshell-processp target) > - (if (eq (process-status target) 'run) > - (process-send-eof target))) > + (while (eq (process-status target) 'run) > + (process-send-eof target))) > > ;; A plain function redirection needs no additional arguments > ;; passed. > > I'm about to go AFK for a few days. If the eshell people agree that something > like this patch should be installed, please go ahead. I think it would then be > worth re-enabling the extpipe tests on EMBA to see if the problem is fixed there > too. I'm a bit queasy about an unbounded loop here. Why not just try three times? Or, better, try twice, and a third time only if we're on a platform where we know it's needed. Many thanks for the investigative work. -- Sean Whitton