From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#56180: 29.0.50; editing file with tramp's "sudo:" changes file owner Date: Fri, 24 Jun 2022 17:32:23 +0200 Message-ID: <87sfnu2i2g.fsf@gmx.de> References: <10b15cda-9cd4-1e54-be07-0b2f31ebc244@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56180-done@debbugs.gnu.org To: Platon Pronko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 24 17:34:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4lJo-0003aL-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 17:34:00 +0200 Original-Received: from localhost ([::1]:48298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4lJm-0003Qr-Uu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 11:33:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4lIt-0003LG-OL for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 11:33:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4lIs-0007MX-Rt for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 11:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4lIs-0007fK-DU for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 11:33:02 -0400 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2022 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56180 X-GNU-PR-Package: emacs Mail-Followup-To: 56180@debbugs.gnu.org, michael.albinus@gmx.de, platon7pronko@gmail.com Original-Received: via spool by 56180-done@debbugs.gnu.org id=D56180.165608476129107 (code D ref 56180); Fri, 24 Jun 2022 15:33:02 +0000 Original-Received: (at 56180-done) by debbugs.gnu.org; 24 Jun 2022 15:32:41 +0000 Original-Received: from localhost ([127.0.0.1]:43258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4lIW-0007ZG-Sj for submit@debbugs.gnu.org; Fri, 24 Jun 2022 11:32:41 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:43059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4lIN-0007OP-EL for 56180-done@debbugs.gnu.org; Fri, 24 Jun 2022 11:32:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656084745; bh=6LIW3t/Qfusk2W3jI7nMr1V623l6WX8eO1LNO1eVunM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YhwHBkBDsRfUZtp+NmVzZ9B5iPwSybI9yma+shcEzt5FULrVqN5omrYCHxqsWyg59 fyOCqFqb9eocqWa+y+mdQw8MVCeE4sOGNNbAFLbECn/5MQ1zcSacU81veljqKkkIx/ LhoYMsjsTfJcUJ4HCMZvyw5+1ajPpYcGGoi9NtuU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.156.125]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQvCv-1oH3WQ00Dn-00O0Sy; Fri, 24 Jun 2022 17:32:25 +0200 In-Reply-To: <10b15cda-9cd4-1e54-be07-0b2f31ebc244@gmail.com> (Platon Pronko's message of "Fri, 24 Jun 2022 08:26:05 +0300") X-Provags-ID: V03:K1:v6nLWZGwA/LXaNSSJexcmBq+ypy/VgP5x+/y9YithTbKLEQ0Ajv jfK+8b5B+nBoyZq7shx1A4VO6JN4aullm1vICgXPATkydnG30/H7wNLxgwmxeLOFwrb2NnZ 6xnCu/mWKP5OWLsvaQWUTTFFpkUpDoLTCLNf10vAkMSHpvVafHC86isDWgb98KFbQGDwI1I xakdkSp9pr/XJijMCNisg== X-UI-Out-Filterresults: notjunk:1;V03:K0:MS26gJyiI1U=:u84Mjga/Dwa4K0IcIsa8IO R/ME6Rbb2kz8v/UIVWkHUKfl2+4NRMDXMTUlJBdMFh8wDeSOQmFTffOTqWiMcSSSls4BpdwMD F/CGjSBF6m1oZzVImnnYN9OV1Pcdt7HBocvzd+HnGYkRrUwnFpPtNuZ+PdUZQ+MUvLw6U+puA zZl0dou1/Luebt3MmAZaToyy3VfeusK3S0PMd+W/83fb77STiyJn6Wxj4pY6BJs4knqcQ4VAX QRhGh8/ppqwGwMyrtG1BJWL3h9Hv/cEkjGwdwChi6Sp1U6eCYVidy9pQrumo/kuwJk8ozTd7j xtTjEgXgtx8nq+nxFLLWJOuj8oAi8pNsDsjU1Ts/d4CVb1mca/azItVOsgHwP8RBst79Sx3c0 XG9CXxlFTHgR0gm68JbadQOTZq4yAmJPFAeT/uoXSkB8nzVMitbK28EMFZtG4Le5OnnuCK/vo zTpppFVTDmdhgOIFL1DtPGvg9F84PtLm9uXqr92R7b7Fk/FRezP6RoZq3YAjlAO24VH6fY7/y OTfJdwlmWInIDM2+sBegd764rftk219Gbgm5+tcbBTnzXicJLBg2x82mn4b1WRiZvEJTlzKSY L7nOQuKkvSfZSy87wamlMODdr/dTc95j20ZjbVzMytjlSFr1697JROLa9wzBj+Mhl4SnE9nCt leur7YU0igkP/T1USgrffE0joI1FK0FXL35ptUso1LQ6nZVQLudqEteaSkvgV2zHYlVGunGfC iEfXl+VYkcYMYmjEO+TZCoX8pssXD7dqSjFPb4mGiAQnvD9C0agpwDX3Y2HgiF9jsThQf34v X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235195 Archived-At: Version: 29.1 Platon Pronko writes: Hi Platon, > When I'm editing some root-owned file on the local system with via tramp's "sudo:" > file owner and group are changed to my username (the one Emacs is running under). Thanks for your report! > It seems that this is a regression from a commit 4e7879f8 in May, which tweaked > how tramp decides whether to chown the file after it is written. I think that > one of the checks needs to be inverted (patch below), because currently it reads > "if uid is different, then skip setting the uid, but if it is equal then set it to the same value". Indeed. Accidently, the logic of this check was inverted by commits 47fe7a59 and 4e7879f8. I've pushed your patch to the master branch, closing the bug. Best regards, Michael.