From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57961: 29.0.50; [PATCH] image-dired thumbnail generation fails for PDFs on macOS Date: Wed, 21 Sep 2022 13:42:14 +0200 Message-ID: <87sfkl6jjd.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57961@debbugs.gnu.org, Stefan Kangas To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 13:43:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oay8s-0004wl-Tt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 13:43:50 +0200 Original-Received: from localhost ([::1]:52782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oay8r-0001J7-Mc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 07:43:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oay86-0001HC-72 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:43:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oay85-0000qz-SP for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oay85-0000UC-J1 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57961 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57961-submit@debbugs.gnu.org id=B57961.16637605451797 (code B ref 57961); Wed, 21 Sep 2022 11:43:01 +0000 Original-Received: (at 57961) by debbugs.gnu.org; 21 Sep 2022 11:42:25 +0000 Original-Received: from localhost ([127.0.0.1]:60939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oay7V-0000Sv-50 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:42:25 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oay7T-0000Si-45 for 57961@debbugs.gnu.org; Wed, 21 Sep 2022 07:42:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MN8gbkI6OaKoSDTmlSnpBhCssD+Schj82klN9g7m3Qw=; b=ohujxoHmsE5+Mj092HkKG4nvVd R8OzSfV1XVVreuMGSTT51v6+p9KBg4IQme2BVQHk26FbF8yqnPi9qgDyN5Md0a8JQJAh6WeHF0OsG tPySa1KkXKQvfdF6qA6IBNjpIWHPgR3YaY1V1p7sOVPOf0b3BGx5QDd625z9bhU2I1CM=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oay7K-0004Zk-LR; Wed, 21 Sep 2022 13:42:17 +0200 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Tue, 20 Sep 2022 22:53:19 +0200") X-Now-Playing: Niki Mono's _Contradictions are a Luxury_: "I Am Your Feeling" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243306 Archived-At: Daniel Mart=C3=ADn writes: > I've created this patch so that PDF thumbnails get the correct JPG or > PNG extension. That fixes the problem on macOS, at least. > > Any ideas if the logic is correct and makes sense? Thanks. I think the patch makes sense. Perhaps Stefan has some comments; added to the CCs.