unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 57961@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#57961: 29.0.50; [PATCH] image-dired thumbnail generation fails for PDFs on macOS
Date: Wed, 21 Sep 2022 13:42:14 +0200	[thread overview]
Message-ID: <87sfkl6jjd.fsf@gnus.org> (raw)
In-Reply-To: <m14jx1n4xs.fsf@yahoo.es> ("Daniel Martín"'s message of "Tue, 20 Sep 2022 22:53:19 +0200")

Daniel Martín <mardani29@yahoo.es> writes:

> I've created this patch so that PDF thumbnails get the correct JPG or
> PNG extension.  That fixes the problem on macOS, at least.
>
> Any ideas if the logic is correct and makes sense?  Thanks.

I think the patch makes sense.  Perhaps Stefan has some comments; added
to the CCs.





  reply	other threads:[~2022-09-21 11:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m14jx1n4xs.fsf.ref@yahoo.es>
2022-09-20 20:53 ` bug#57961: 29.0.50; [PATCH] image-dired thumbnail generation fails for PDFs on macOS Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-21 11:42   ` Lars Ingebrigtsen [this message]
2022-09-21 13:09   ` Stefan Kangas
2022-09-21 13:58     ` Stefan Kangas
2022-09-28 10:45     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfkl6jjd.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=57961@debbugs.gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).