From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Fri, 07 Oct 2022 08:03:42 +0000 Message-ID: <87sfk0jc0x.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <8fa87ad2-6d5c-2f9d-ed37-0b956fbadd2c@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25792"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , 57400@debbugs.gnu.org, Antoine Kalmbach To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 07 10:06:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogiMx-0006UB-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Oct 2022 10:06:07 +0200 Original-Received: from localhost ([::1]:55876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogiMv-0006aS-M2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Oct 2022 04:06:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogiKx-0006Y4-2C for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2022 04:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogiKw-0005Da-67 for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2022 04:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogiKv-0005mW-Sn for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2022 04:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Oct 2022 08:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166512983622210 (code B ref 57400); Fri, 07 Oct 2022 08:04:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 7 Oct 2022 08:03:56 +0000 Original-Received: from localhost ([127.0.0.1]:34242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogiKp-0005mA-Ru for submit@debbugs.gnu.org; Fri, 07 Oct 2022 04:03:56 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:36643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogiKo-0005lw-FH for 57400@debbugs.gnu.org; Fri, 07 Oct 2022 04:03:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 46177240028 for <57400@debbugs.gnu.org>; Fri, 7 Oct 2022 10:03:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665129828; bh=ZzU6IzuM3bqrN8EjzD5JigEv4O406BLIpE3YpbbY8hs=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=ag9A21xYBvhABMu475IYVRJX2GrdvhRxNWLKH+z+8Rg017eiDcysa/gAplOmHcW3x MBlzdAVgAtX3KOkMICZTJIHcKolZx9K+q+1SSvJ02GxFBlF3XPsdSg/ourroXak3+c eBpu19ZGEuImeaoyAMGnBO6l4wFAPe3B1lZxUO7ebRWJH4HAjNaDyx51oyEefBmx98 /qWJus/9FmqnwReml/GpxCo51un0FjBf8wLmuVR1ST1vkudXpYQN2VNaNztrNwMHYP rLgV2gvZa3Kaz2SQHqHRnRyytmSpwyk8f1/GwqkV0TcGjCaHV/7NYjirBQBPD8U2YI Utl9CvgjcPJMQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MkLRM1x37z6tnC; Fri, 7 Oct 2022 10:03:43 +0200 (CEST) In-Reply-To: <8fa87ad2-6d5c-2f9d-ed37-0b956fbadd2c@yandex.ru> (Dmitry Gutov's message of "Fri, 7 Oct 2022 01:10:32 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244743 Archived-At: Dmitry Gutov writes: > Hi Philip, > > On 06.10.2022 15:38, Philip Kaludercic wrote: >> I'm glad to hear that. Here is the updated patch: > > This version resolves the main questions I had as well. > > Here's one more, though: the way I normally used 'git format-patch' is > I pass just one ref, and that's usually the name of the branch to > start the history at (the argument from the manual). So I > never had to "type revisions in the Git syntax" for this to work, > something Eli was worried about. It might be tricky to do this in a VC-generic way, but what I can think of would be if the command is invoked with a prefix argument, then instead of querying for specific revisions, we query for one only, then use 'next-revision' to check if it is a predecessor of the current revision. If so, all the commits in-between are used. The main issue I see here is that 'next-revision' requires a file argument. What should that be? > Should this new command support this usage as well? > > The range of revisions could be fetched by passing the base revision > as LIMIT to the 'print-log' action (like vc-log-mergebase does), but > how the updated calling convention for vc-prepare-patch will look is > not obvious to me. Even if we do this, the value of the argument "files" still remains an open question. It is for this reason that I prefer the current approach, especially when combined with the ability to select commits in a log.