From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Fri, 11 Nov 2022 09:45:06 +0000 Message-ID: <87sfip7rkt.fsf@gmail.com> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <83o7tdq4f2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58790@debbugs.gnu.org, felician.nemeth@gmail.com, stefankangas@gmail.com, danny@dfreeman.email, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 10:44:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otQa2-0004rF-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 10:44:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otQZv-0005Br-PL; Fri, 11 Nov 2022 04:44:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otQZu-0005Bf-Gs for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 04:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otQZu-00083F-7m for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 04:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otQZt-0001cG-So for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 04:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 09:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.16681598416199 (code B ref 58790); Fri, 11 Nov 2022 09:44:01 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 11 Nov 2022 09:44:01 +0000 Original-Received: from localhost ([127.0.0.1]:45115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otQZs-0001bu-UJ for submit@debbugs.gnu.org; Fri, 11 Nov 2022 04:44:01 -0500 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:54088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otQZr-0001bi-GB for 58790@debbugs.gnu.org; Fri, 11 Nov 2022 04:44:00 -0500 Original-Received: by mail-wm1-f43.google.com with SMTP id p16so2630928wmc.3 for <58790@debbugs.gnu.org>; Fri, 11 Nov 2022 01:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=emeyOO0+1hUBXVri5mdtqpbLw85AQCZkws1KIh149aQ=; b=ImjNRwIsHXG2L7IspJsOHmmGoIuLl7deQn6m16d2TuWvAQij2RyD3owZsUfFFSuL3n 8R1D731ilBZFKehwJVFDdZdS9Blnq9H57JayXHvu6BrtgiTadrqT9rDHiRmGybNzCxDF 5Z+0k9tWt9VnLYJ7bFbP506RfASOSUD3dMcpjqYn8g5ChbaHT82rKpWaKgJ9tNT34fNi vR7/Bm/neRV9cDMtcHaHbKfepLrtlH+i9yVEp2h3NHfjbPAxZ1dyG1Fm26YNyBoZdlIS QeWPk2jzqYmxV2j0qJax6eQfJfzU5BVe++bJKlfFpm89doGbpTSEUJKnhRPzjOdxT5PB A2dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=emeyOO0+1hUBXVri5mdtqpbLw85AQCZkws1KIh149aQ=; b=HHiUD6VE3B39BN7JJNozaylosqm0rRJtU0ZOWaix57wI6TyzfrPL7Qbm0cGGEPPUDn kW3Va1UNPH6E2sAsB8XxdiN+CuJDwOGy3SGvT7HyA4+JDjSERp2ey4IDIDxsNItnHpY3 JgUNHHy56jQXWi8ooq2xQM91SgwNqUNry61urj9kqzcqAcsQYnZgQuMZ3JQIVysY8ofP bp1crpMWO/wMzhyq7//RuqIo1ZfYuCpOOib40OwxwyM0pNI0QBNm7giXqwAz3mO8a+hh ZFW/lv2pCuScD7O5UCy8WJBqv9d74WCYk3ZfDIWSGyygx1EvAGyCY7uPiuKBha998gVy zScQ== X-Gm-Message-State: ANoB5plWPCGLSdBfBDokAxids19Fk+X+/GPGmN9LatAAjzSogUC+TJPk epWeV+dHcNzmHBMzROIHCF0= X-Google-Smtp-Source: AA0mqf5Gj91EZ7NAMlVuJn4lSIn2LvIgehe1NglLn8xwTK8J0hIvu+M60a1Ow78vRuIjQB1jq/iVWg== X-Received: by 2002:a05:600c:448a:b0:3cf:6182:a458 with SMTP id e10-20020a05600c448a00b003cf6182a458mr679640wmo.70.1668159832618; Fri, 11 Nov 2022 01:43:52 -0800 (PST) Original-Received: from krug (87-196-81-1.net.novis.pt. [87.196.81.1]) by smtp.gmail.com with ESMTPSA id x6-20020a5d6506000000b002305cfb9f3dsm268873wru.89.2022.11.11.01.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 01:43:52 -0800 (PST) In-Reply-To: <83o7tdq4f2.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Nov 2022 10:30:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247579 Archived-At: Eli Zaretskii writes: > It is quite possible that you personally don't need these additional > comments because you are very familiar with the code and with LSP > servers in general.=20=20 Oh you're mistaken. I do need this information at hand, I forget things on a weekly basis. Whether in comments or in commit messages, that's a different decision. >But future Emacs developers and maintainers might > not have such insight, and I'm trying to represent them. This is part > of my job and my responsibility. And since comments can never > adversely affect code, I see no reason for you to object. Comments are not a 0-cost thing, obviously They can hamper readability, they contribute e.g. to a small function no longer fitting in one screen. They present a maintenance burden too and a source of duplication. These are their drawbacks, but they have many many advantages too, of course. You'll see me using comments very often. I do this on a case-by-case basis. I thought you were suggesting that those big blocks of text about Clojure jar URI be moved to comments. IMO they are out-of-place in source code, especially in such a short function, but they are quite acceptable in commit messages. It would seem you weren't proposing that, so this was a misunderstanding. Anyway, the comments Danny inserted: "Only attempt to parse URIs with the file scheme.". and=20 =20=20 "Leave non-file type URIs untouched, `file-name-handler-alist' handlers can be used to dispatch them properly." Are quite fine. I've condensed them and tweaked them to include a reference to this bug#58790 Now if someone could fix=20 ;; bug-reference-bug-regexp: "\\(github#\\([0-9]+\\)\\)" ;; bug-reference-url-format: "https://github.com/joaotavora/eglot/issues/= %s" To work for both GitHub bugs and Emacs bug references in that file, it would be just peachy. Jo=C3=A3o