unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sean Whitton <spwhitton@spwhitton.name>
To: Juri Linkov <juri@linkov.net>, Dmitry Gutov <dgutov@yandex.ru>,
	59414@debbugs.gnu.org
Subject: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
Date: Sat, 03 Dec 2022 00:04:17 -0700	[thread overview]
Message-ID: <87sfhxynm6.fsf@melete.silentflame.com> (raw)
In-Reply-To: <878rk5i8zx.fsf@melete.silentflame.com> (Sean Whitton's message of "Sun, 20 Nov 2022 14:58:10 -0700")

Hello,

On Sun 20 Nov 2022 at 02:58PM -07, Sean Whitton wrote:

> We already have vc-git-log-switches.  git-log(1) gets called *without*
> it in (at least) the following places:
>
> - vc-git-log-outgoing
> - vc-git-log-incoming
> - vc-git-log-search
> - vc-git-expanded-log-entry
> - vc-git-region-history
>
> I guess that the first three should probably use vc-git-log-switches if
> anything?  And so we would want a separate option for
> vc-git-expanded-log-entry.  Not sure about vc-git-region-history.

I think that we actually need two defcustoms for the regular logs and
shortlogs:

- vc-git-print-log -- should choose which defcustom to include based on
                      its SHORTLOG parameter
- vc-git-log-outgoing -- vc-git-shortlog-switches
- vc-git-log-incoming -- vc-git-shortlog-switches
- vc-git-log-search -- vc-git-log-switches
- vc-git-expanded-log-entry -- vc-git-log-switches

This is because some options are incompatible with shortlogs, such as
--stat.  So, the proposed change is to add the new defcustom, change
vc-git-print-log to use both defcustoms, and change all the other
functions to use one of them.  How does    this sound?

-- 
Sean Whitton





  parent reply	other threads:[~2022-12-03  7:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20 17:35 bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat Sean Whitton
2022-11-20 17:52 ` Juri Linkov
2022-11-20 20:14   ` Dmitry Gutov
2022-11-20 21:58   ` Sean Whitton
2022-11-20 22:11     ` Dmitry Gutov
2022-11-21 20:29       ` Sean Whitton
2022-12-03  7:04     ` Sean Whitton [this message]
2022-12-04 19:19       ` Juri Linkov
2022-12-04 22:57         ` Sean Whitton
2022-12-05  0:54           ` Dmitry Gutov
2022-12-05  5:09             ` Sean Whitton
2022-12-05 12:29           ` Eli Zaretskii
2022-12-05 12:40             ` Dmitry Gutov
2022-12-05 12:57               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfhxynm6.fsf@melete.silentflame.com \
    --to=spwhitton@spwhitton.name \
    --cc=59414@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).