From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed) Date: Mon, 05 Dec 2022 09:10:04 +0800 Message-ID: <87sfhupser.fsf@yahoo.com> References: <835yerd5gb.fsf@gnu.org> <87ilirr0uq.fsf@yahoo.com> <83ilirbh68.fsf@gnu.org> <87a643qt09.fsf@yahoo.com> <838rjnbbqc.fsf@gnu.org> <0137C1CC-0AEC-4790-85E6-D1AD987A63E1@gmail.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35604"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= , 59794@debbugs.gnu.org, Kai Ma , Eli Zaretskii To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 02:11:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p200v-00096v-FK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 02:11:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p200d-00065n-PS; Sun, 04 Dec 2022 20:11:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p200c-00065R-MO for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 20:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p200c-00059s-EY for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 20:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p200b-0005Up-SA for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 20:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 01:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59794 X-GNU-PR-Package: emacs Original-Received: via spool by 59794-submit@debbugs.gnu.org id=B59794.167020263121120 (code B ref 59794); Mon, 05 Dec 2022 01:11:01 +0000 Original-Received: (at 59794) by debbugs.gnu.org; 5 Dec 2022 01:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:60835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2007-0005Ua-6Z for submit@debbugs.gnu.org; Sun, 04 Dec 2022 20:10:31 -0500 Original-Received: from sonic314-21.consmr.mail.ne1.yahoo.com ([66.163.189.147]:46379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2001-0005UU-VP for 59794@debbugs.gnu.org; Sun, 04 Dec 2022 20:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670202619; bh=8uxD4o74OcYlXr9a+EQSi+7oZOVBTGkWVwutVFO8H/s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=a9FIAMC8lj32HH7zxUPvnjjJZJITxpmBlk9AFX2/cCWW6QjC/ygjgkBaYmXACkj5NlqR751MNCjUSuqyVe/Qaf7nbWKIhl/PHpggaLL6l7yBzGtmiku+RUUL1GqZ4dyFYVmwRNtlkhoLb2B9gqRsVtgSl8KhbpUPqb8NTxnSqUdAc0oKc1TNky5Au+9IWH2V8ZAJpsuFc5U6o3nt5gIIrfXXrBNKPb97tDOr5vpIrErMkeXsouD1gz+BjBkAuxK+8s1m37grz/LxbYGF6uqKpGp8jX2ho769KeecDZCH6rl0aKVC+ygDFhMfRIkVyS5Xty/hr3LLGquj+KDnMGXMlA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670202619; bh=glg/WWd3+8WMaDj9vM6dmdZ53y8VOrNyFREKBLc6ex9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ajy8bY+ZlP5IYsE+YbXei9R//v7Yif7vvsxsbUSIWG+bYSFTwMF21OsnopBQh8Ss8GbplglhlMUEcibzXueVqL/WPcVsjQD1YclxVOi0dS5xpaCHBPI32kzfyENOJgOaBDlag141cDQwIdAer464ZK0DgEWLCU4axSCfdFFcgvjRBswkJa88tt+0JRGe/nympj9I5kZ38Gm8W/PtC10OfZqku+reHRdfXJ0cPFZq5cacl/h7fPqqxgKaUniBemAEMopkrD+gRQb2qiWqrLEndVDp8J5SZ1TPRx1SastNRYyX8Q4hqDsi8f8ZZvGG10wM7Nmq/vgevnZ6MzS8Bpr9Hg== X-YMail-OSG: eo3PERAVM1kYx2ZsKCsoywaYg1mqW7eD8nXo2D_pEbj.2pBnkDtaehrjshJz3GT ix5Ce3NffMnum_y5huz.ejgWocq33cm4x.oFC7TfdehH5B9Q9umpKCqeGQfKaW._b_62nTEq4tL9 z8tf6FWEEj1icYzKElwUKJ0a91D5D_A7iuFreW3_Tuk0cMzo07Lj7n33DSAuFo_Ncn8Lq0SPrkO2 LMZE16VFRykW0Wah7308gwQErhiV4UOJM.8s_PvAhd5CeVS6VSh511ffCmLtZjBrexQFxbOEzWCT LL5mqWq4FKyvjCxVKSpesiEuOIHkygF3zJMzpxNjx61qCTQWgIlTLIq858bfXvIIJ9k7S.IsOqJV 5.HfiQn1J6AGnW0yfkrZBMmrRzC9aQoT1dW50ugAR7ssVBo0ZHkvcOvyxnyDuEh.5U3PM4ARSOaf dEcXkLDZ2RscPu8TNNE134HU006vDrq.9ykv95TF4bt9hu_IIxWqSXmJkSIpJpemOD5bJdk3IZ5Y HO1Wesjd6AxIP3u8XvagnqgEiaPsh8IcMkMvcm2cZo7odaSEROBm51XxOe_4TUWiZsrBDGA8pd6c .txkJCdzEaQm2nGsxCY8mRNu_.MCKdQktCtN8HPLtAl3bZrXPNsfKLIc3zgkrxTwwYoS1lu58a.2 Vlc8PLp1xsVmm.n9rspfU7fdONd1DbXFu13KmBLgIJakPMQ7_GSkYZqr3MzLnwywJMMg3dLQWjih AzDoOyJj53zS3lDgRjJXMJGRGjYPGbQWq44LawAxsjvJdYpjmfc1WsfHppc2Jcwpk9pfem8VKUqT 5zhxGZe_FB1i2aQMyFjf58jWR7mvABHOa0lHsgWPmS X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Mon, 5 Dec 2022 01:10:19 +0000 Original-Received: by hermes--production-sg3-b666c6484-8hzhs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3e4b85771d0a95685327329430512b7b; Mon, 05 Dec 2022 01:10:13 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 04 Dec 2022 14:53:45 +0100") X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249981 Archived-At: Daniel Mart=C3=ADn writes: > Kai Ma writes: > >> >> diff --git a/src/nsterm.m b/src/nsterm.m >> index 507f2a9e7d..f99d7cde3c 100644 >> --- a/src/nsterm.m >> +++ b/src/nsterm.m >> @@ -6703,8 +6703,18 @@ - (BOOL)acceptsFirstResponder >>=20=20 >> - (void)resetCursorRects >> { >> - NSRect visible =3D [self visibleRect]; >> - NSCursor *currentCursor =3D FRAME_POINTER_TYPE (emacsframe); >> + NSRect visible; >> + NSCursor *currentCursor; >> + >> + /* FIXME: [resetCursorRects:] can be called from the event loop >> + after the frame is deleted. When this happens, >> + emacsframe->output_data is NULL. This means there is an >> + underlying leak of the EmacsView object! (bug#59794) */ >> + if (! emacsframe || ! FRAME_OUTPUT_DATA (emacsframe)) > > Wouldn't it be more clear to check !FRAME_LIVE_P (emacsframe) instead? > (I can't reproduce this bug, so I don't know if that would avoid the > crash.) There is a similar check in - (void)windowWillExitFullScreen > and - (void)windowDidExitFullScreen, for example. Those other calls are a serious problem too. They obscure an underlying memory leak, and if emacsframe is not set to NULL by the point they are called, they could result in use-after-frees once GC deletes emacsframe entirely.