From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60977: 29.0.60; Dired: invalid face reference with dir symlinks Date: Mon, 23 Jan 2023 21:04:00 +0000 Message-ID: <87sfg1q7y7.fsf@tcd.ie> References: <87mt6cdaao.fsf@tcd.ie> <86wn5e7imn.fsf@mail.linkov.net> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17940"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60977@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 23 22:05:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK40O-0004Qt-Kz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Jan 2023 22:05:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pK401-0004K0-4K; Mon, 23 Jan 2023 16:05:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK3zy-0004Ja-OW for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 16:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pK3zy-0006X9-Ew for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 16:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pK3zy-0007Ad-9w for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 16:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2023 21:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60977-submit@debbugs.gnu.org id=B60977.167450785027483 (code B ref 60977); Mon, 23 Jan 2023 21:05:02 +0000 Original-Received: (at 60977) by debbugs.gnu.org; 23 Jan 2023 21:04:10 +0000 Original-Received: from localhost ([127.0.0.1]:55433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK3z8-00079D-HV for submit@debbugs.gnu.org; Mon, 23 Jan 2023 16:04:10 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:40745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK3z5-00078y-Vc for 60977@debbugs.gnu.org; Mon, 23 Jan 2023 16:04:08 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id r2so12032339wrv.7 for <60977@debbugs.gnu.org>; Mon, 23 Jan 2023 13:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=MRG9Fu+i+sM+iKIQtHr/oUSnhkVSIB93ZIy+Gv6EZt0=; b=V/IDurLGCNCdZUyINP2xHMtRHmHoUY0OFUHQgRr72U3QWslJMbanRfoUdKPkxnEAKB Aje/9rgjy96+Uq7Nq6NU1RsjdeZtuIg27MsTBe4WOZ3U/Cc0vqIkKzCZnNucI9mARC79 x+jlcZw5KcJXxb4H7gQrHk9D/+mBaT3XDluDq02/t81VDydROze4b71wOjZvSHPZsZPw aMRGPYHe+A/aheZMDorRBGiMKl+kU7M4GFXyvq2c8COoI/QzXn3UHmb2YIdRgoBQw07k uxoek/LlKMxBox6uPHBZUZYk7apQ8sC/kXOiGY3TE7T8QnmIZuyf9kKVp2zfCCQF2eeH P3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MRG9Fu+i+sM+iKIQtHr/oUSnhkVSIB93ZIy+Gv6EZt0=; b=uYOPKQ36NppThYoasuDcXJF5/AsmxVHJzwXqNiUOaML7gMV4+sB+QAsCZv3Zo+t9p/ MrA6t70mIOUxXUYqsaGCHfNjvA5Lyx5SPAymgSlKsvLfmVvh5+8iNXUnpwtSbrK0SR1M Rf+9KtYBF94auOTIhz60lUbOV25qGlVpVmStjLCTp0UE2+HZXZI/Nwi4NdncEbL57Wxo N/v9hQvCmuQkDQIl79OFkGEr3lya/fSyOmlr2r2NZLZlBVkCIOUFPX8wweaLNTyX6ST2 X3sz6MCE0S7+GeoVNo18d548+7HuY+qDNSPsQ75G8eluHQTitU/Fjh7gYyeuTVyGdvcf 67pA== X-Gm-Message-State: AFqh2kr4lw5J12JndF8R8RIhjSewJPZsDFp4lEtazMBP6rEkGk6fI8i/ KXVCY90k3Gcj83bbkDqxbEqPwQ== X-Google-Smtp-Source: AMrXdXvHSEWLQvHdH+6wSXB85ddgoPZNR2WmLTuUMxu64KREvEiGPIfl1l4ZwmEx8Nia1HQfq6e9oA== X-Received: by 2002:adf:b604:0:b0:2bd:f35f:1b5e with SMTP id f4-20020adfb604000000b002bdf35f1b5emr22349457wre.4.1674507841903; Mon, 23 Jan 2023 13:04:01 -0800 (PST) Original-Received: from localhost ([51.37.218.63]) by smtp.gmail.com with ESMTPSA id x12-20020adfdccc000000b002bddac15b3dsm288110wrm.33.2023.01.23.13.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 13:04:01 -0800 (PST) In-Reply-To: <86wn5e7imn.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 22 Jan 2023 19:05:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254028 Archived-At: Juri Linkov [2023-01-22 19:05 +0200] wrote: >> - Link target fontified with undefined 'dired-directory-face' face >> - *Messages* says 'Invalid face reference: dired-directory-face' >> >> This seems to be a regression in Emacs 29 (https://bugs.gnu.org/57293): > > Thanks for finding this regression. > >> But I don't know whether it's acceptable for emacs-29, or whether it >> conses too much during font lock. In the latter case, we could evaluate >> dired-directory-face once (when dired-font-lock-keywords is defined), or >> we could use the 'dired-directory' face directly. WDYT? > > I think the effect of consing is negligible. Thanks for confirming. I'll install it once we hear from Eli re: emacs-29. -- Basil