From: Fernando de Morais <fernandodemorais.jf@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 61479@debbugs.gnu.org
Subject: bug#61479: 28.2; icomplete-in-buffer --- Error in post-command-hook: args-out-of-range
Date: Sat, 25 Feb 2023 09:15:51 -0300 [thread overview]
Message-ID: <87sfeuj5zc.fsf@gmail.com> (raw)
In-Reply-To: <86ttzckaxm.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 23 Feb 2023 10:36:45 +0200")
Hello Juri,
Juri Linkov <juri@linkov.net> writes:
> This shows that C-M-i bound to icomplete-force-complete needs the same
> treatment:
>
> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index f7a91599f3b..b0b55dd1e7e 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -215,7 +215,11 @@ icomplete-force-complete-and-exit
> ;; calculated, This causes the first cached completion to
> ;; be taken (i.e. the one that the user sees highlighted)
> completion-all-sorted-completions)
> - (minibuffer-force-complete-and-exit)
> + (if (window-minibuffer-p)
> + (minibuffer-force-complete-and-exit)
> + (minibuffer-force-complete (icomplete--field-beg)
> + (icomplete--field-end)
> + 'dont-cycle))
> ;; Otherwise take the faster route...
> (minibuffer-complete-and-exit)))
>
> @@ -223,7 +227,11 @@ icomplete-force-complete
> "Complete the icomplete minibuffer."
> (interactive)
> ;; We're not at all interested in cycling here (bug#34077).
> - (minibuffer-force-complete nil nil 'dont-cycle))
> + (if (window-minibuffer-p)
> + (minibuffer-force-complete nil nil 'dont-cycle)
> + (minibuffer-force-complete (icomplete--field-beg)
> + (icomplete--field-end)
> + 'dont-cycle)))
>
> ;; Apropos `icomplete-scroll', we implement "scrolling icomplete"
> ;; within classic icomplete, which is "rotating", by contrast.
I've tested it and it worked perfectly! Thank you once more.
> Thanks for finding another way to reproduce the problem.
You're welcome. 🤝
--
Regards,
Fernando de Morais.
next prev parent reply other threads:[~2023-02-25 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 14:56 bug#61479: 28.2; icomplete-in-buffer --- Error in post-command-hook: args-out-of-range Fernando de Morais
2023-02-13 17:56 ` Juri Linkov
2023-02-13 18:01 ` Fernando de Morais
2023-02-14 4:01 ` Fernando de Morais
2023-02-14 18:28 ` Juri Linkov
2023-02-14 19:32 ` Fernando de Morais
2023-02-15 18:20 ` Juri Linkov
2023-02-16 18:29 ` Juri Linkov
2023-02-18 13:24 ` Fernando de Morais
2023-02-23 8:36 ` Juri Linkov
2023-02-25 12:15 ` Fernando de Morais [this message]
2023-02-27 18:45 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfeuj5zc.fsf@gmail.com \
--to=fernandodemorais.jf@gmail.com \
--cc=61479@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).