From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Sat, 11 Mar 2023 15:07:05 +0800 Message-ID: <87sfebepgm.fsf@yahoo.com> References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <16ecbe9ea8ba9d39d058@heytings.org> <83v8j8zutj.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7177"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: philipk@posteo.net, michael_heerdegen@web.de, mail@daniel-mendler.de, Gregory Heytings , monnier@iro.umontreal.ca, 62009@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 08:08:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1patKq-0001eu-QA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 08:08:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1patKl-0006m9-C4; Sat, 11 Mar 2023 02:08:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1patKk-0006m0-E1 for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 02:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1patKk-0006RW-3m for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 02:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1patKj-0003rw-LX for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 02:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Mar 2023 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.167851844514829 (code B ref 62009); Sat, 11 Mar 2023 07:08:01 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 11 Mar 2023 07:07:25 +0000 Original-Received: from localhost ([127.0.0.1]:56438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1patK8-0003r6-Ow for submit@debbugs.gnu.org; Sat, 11 Mar 2023 02:07:25 -0500 Original-Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:33699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1patK6-0003qr-Bg for 62009@debbugs.gnu.org; Sat, 11 Mar 2023 02:07:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678518436; bh=dIGb19aGv+DEC+YDO8XOwPKdomSaewts5Q2bBMI26Cw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=OM8+Pnh97CP5PVgzqjGoYSvDhz/lniY9Py75IYFlGRvU5NCVv0q7kO1eDYCzKAWhDPp25WMNwVzbp3YIZa1YW5qPH/hMpabspmNtJB3yQ3Ujz5chX66rMo4lIOeRnEqGZLl/YVeO1nUj9wOxVdEyiUrQ5he4bLuSqpVT7r1Xgfyxue+dkoH09eFSO1bHHddVvF9vmtwFUK7eTk9gQbdN3ctQsx9VR1EJao1y8CeNts5A2oISqJqaQAfPhkKsI0PcMRAIuwwMesYJkRk2ODwuzLmmhOdATelvoFy2SAA+wNORwxaT/psNALwhrIMuwlwZj0ge75GWqCPXeJjC3RQ92g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678518436; bh=WrwdN2yRxXp/v0wjh9jnS8ulkl7dCiDw5GnK6d4vfa6=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=se+c0ptTIcuu4yLxol9xspj7hORdaSRttVofPpDGpD2zIdloZUX51tmt5wwlP/P+p3w044eiMWQ9G1I7Sn2VcHF1wHpfx2EGzE+59Pxxzf/bmQ+SR3PeyCER9DH+MptbOChOO1COrf6kcyJKTlnHzpcqo5N90KxvM2IOGTx2AdAKXErNhwu3MwdZ6qZ+yTnScdnjY6sDD4WxMIFeU74yaUgRp3zXmnoBdHaSndtghguagZigHGSCesTrU14ziMJF+FIZF73T+GyAhUMbYmluWeq1kzFXSKre1e0RIOuHB/lYxB130tQi8Tu7TvennI6itRXQhWqfE538JTTAzeW51w== X-YMail-OSG: dUO7IiAVM1k9Ge8qFqE19VZCIr0Yv9vnK9xhm_6lrNLOULuE5Mz6SqG4Aj6jua1 W1jxqvfD8x5neo3q9v42ysrgOcV5HdZ9os6IacYKo7TaC.4gtlaHl8hzUj4BWGLf4u10SNgGTj0R Ox_jQ_7VnHnW4yoy3UCL9PY6czdgiXemNfr.nsLfULWg1gyQXpOydYAQqo1AyfLVhbZquH428Akg tG.iuS9HWAPKfJuG9oXPBMaa3I_pG7c2HW0hRxGqC3dJ3nwXUptCq7whBDJUan50BZUzh4uvfYpt StGh1KUggqq8nModDh_CeBkB5kV3n1vge7HU3z3CiWUbZm8wHv5SVTPEDskv.7DTwP79kY9D3RVq HRDvCcIuAZK0Efjkgv.1v8D2YUqZKEom_WXvmsxtgvF1__u6lF_DM8t.M4EAqy8Ry9Msh7P49O6Z fEaHjbg7j9ZOBbJsqeTNi.qexNpol6j6rO9W9RZAw0S_s93bAFIxVHf8z5J0_wHSqT..rGx3_r.r ZhHlSQlqPpXFtpF2hGBW_7CqAfVekKwzgbvy35cS8D1obU.CpHLVbKkfBHZbOPXxWliDNCP9Hpzd Ijhyp93EANsa3CICQ.3_KZxf745LuoVV4zdk5NUIysH4XtDimNkXkviw8cqiijqMaEob2XJRAoRu VpjC_y267tRbWedpmbEoZjZbIHPax50WuAKVQ.wqLh9isu2C.K1IJe7hLuU8lEz.AJOsJBc2subD dx.8dICBpZwKY9.gH_MqNaxV7SK9NbXOmAL.1LHT.VdZIoY9aHF41E_TaJAQnk43FmMZUvhCZyAO xZPtPvbl2RVhue1_QUa2LBjkl4NZv6fV_uNLMPkB0H X-Sonic-MF: X-Sonic-ID: 2782a14f-9f3f-4fa7-8b71-66c88d5d4f84 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sat, 11 Mar 2023 07:07:16 +0000 Original-Received: by hermes--production-sg3-67c57bccff-b6t8r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 44070af5701c5a83c8490e43210e72e2; Sat, 11 Mar 2023 07:07:11 +0000 (UTC) In-Reply-To: <83v8j8zutj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Mar 2023 13:53:28 +0200") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257754 Archived-At: Eli Zaretskii writes: >> Date: Fri, 10 Mar 2023 09:40:31 +0000 >> From: Gregory Heytings >> cc: Philip Kaludercic , michael_heerdegen@web.de, >> mail@daniel-mendler.de, monnier@iro.umontreal.ca, 62009@debbugs.gnu.org >> >> >> Instead of raising a signal, I suggest: >> >> diff --git a/src/data.c b/src/data.c >> index 0f1d881e00b..76867d6787e 100644 >> --- a/src/data.c >> +++ b/src/data.c >> @@ -780,7 +780,7 @@ DEFUN ("symbol-name", Fsymbol_name, Ssymbol_name, 1, >> 1, 0, >> >> CHECK_SYMBOL (symbol); >> name = SYMBOL_NAME (symbol); >> - return name; >> + return build_string (SSDATA (name)); >> } >> >> DEFUN ("bare-symbol", Fbare_symbol, Sbare_symbol, 1, 1, 0, > > No, we will NOT increase GC pressure in Emacs just because someone > could do a silly and nonsensical thing. No way. Can't we make puresize.h check (in addition to whether or not the string is in pure space) whether or not the string lies in read-only segments of the executable? Or maybe put all of string data of DEFSYM'd symbols in pure space, since Faset already checks that the string is not in pure space.