From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#62237: 28.1 or higher: 24-bit true color breaks colours in Emacsen built without X under GNU Screen Date: Sat, 18 Mar 2023 12:44:45 +0100 Message-ID: <87sfe2qo5u.fsf@gmail.com> References: <87sfe390kv.fsf@sebyte.me> <83h6ujefq1.fsf@gnu.org> <87wn3fs7yw.fsf@gmail.com> <833563e3xc.fsf@gnu.org> <87sfe3s26k.fsf@gmail.com> <83pm97cin8.fsf@gnu.org> <87o7oqsa36.fsf@gmail.com> <83v8iybf49.fsf@gnu.org> <871qlms7h3.fsf@gmail.com> <83r0tmbb11.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sdt@sebyte.me, 62237@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 12:45:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdV0A-0002ux-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 12:45:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdUzj-0003zh-5l; Sat, 18 Mar 2023 07:45:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdUze-0003yq-Jr for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdUze-0006dj-B8 for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdUze-0006k6-6f for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62237 X-GNU-PR-Package: emacs Original-Received: via spool by 62237-submit@debbugs.gnu.org id=B62237.167913989425742 (code B ref 62237); Sat, 18 Mar 2023 11:45:02 +0000 Original-Received: (at 62237) by debbugs.gnu.org; 18 Mar 2023 11:44:54 +0000 Original-Received: from localhost ([127.0.0.1]:46456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdUzW-0006h8-EB for submit@debbugs.gnu.org; Sat, 18 Mar 2023 07:44:54 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:46850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdUzV-0006gw-2t for 62237@debbugs.gnu.org; Sat, 18 Mar 2023 07:44:53 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id l15-20020a05600c4f0f00b003ed58a9a15eso4790297wmq.5 for <62237@debbugs.gnu.org>; Sat, 18 Mar 2023 04:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679139887; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=PzMU962rtBMM0LRGXf9TduTfET5Oz/Nao1LnOY7UCv8=; b=cOBAIEXFy0xFPEW1EoSUDP4nR9+QtvNGwNeOS4Glw1QmRRl4vBdOgH/Z151chutj42 +MCsqbOaXF0ZoDH1tOlGwqdB0JztiIE6g12sTVYlt/Mf2CoxG3bH39/DkJcdZ6tJCIca 9Z2wLET4VmLBLX3HRcLEs3TAKxEjzCXHkmc0Ew/Au+0cwf/l4OKRK/xzx2O4oHC7RqsF N8UBL1toeOEcsPGYxS5w2ewse3xYM0wsLFyk0AO//8eBcdh4AxE//vovcY2bfIy4+UPi 7qJALOuvuEjSjHC+PbBjcmE8Xb5PXS6vscDxVis0Itg0na6BDiMbdYm6CswKONftSRrw oFsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679139887; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PzMU962rtBMM0LRGXf9TduTfET5Oz/Nao1LnOY7UCv8=; b=KkcM6bDTuPEY/sUQdfWh4O7iB5zD7SSi7vsIqFUCap9G4ow6CMr3NANvleHnwpJI47 /Rp67xTDQ6dInNmPf2y2LOkGpk4ImdAauSfDgyYVyfecvghMvu2BpWlcGpgMoUcOdY+4 hdSrCfKAOcs/GPXsZqhdd6IamUs1EBTnN6BNifY2mppqZLWwvghNBm2t5XdinRIYJu+s qBYg2dySBwJEu3a5g+mnX4XyPqyaupWWUomhIVnaFaHddiaqsl2OByxt7UFkKx07J31b 9glE4lGvwtRdstH+YdZ75A2FQONJscs1PrJWtXm37Wds74oGPuhSgD7svzsS2SYvzQVY O+tA== X-Gm-Message-State: AO0yUKVEwnt61AKleXON/l6RKn+Dnm9KwSv9+05BrBNyqtm+jdpKJYKM bb403M6tWCi48j4RO/bxD+d2fv2LM5I= X-Google-Smtp-Source: AK7set9LxzqIe8w0gtqCBVhoqnp+3g+bgKC4KwPEInspIPryw4wwURaCSyJCczmglDxwIGkjF8OjUg== X-Received: by 2002:a05:600c:470e:b0:3eb:29fe:734a with SMTP id v14-20020a05600c470e00b003eb29fe734amr26940305wmo.39.1679139886816; Sat, 18 Mar 2023 04:44:46 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n23-20020a1c7217000000b003eb68bb61c8sm4913917wmc.3.2023.03.18.04.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 04:44:46 -0700 (PDT) In-Reply-To: <83r0tmbb11.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Mar 2023 12:37:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258167 Archived-At: >>>>> On Sat, 18 Mar 2023 12:37:30 +0200, Eli Zaretskii said: Eli> Then I guess we should install your proposed fix in init_tty. In emacs-29? That seems a bit radical. Patch below in any case I guess we could do something with not checking COLORTERM under screen instead. Robert -- diff --git i/src/dispnew.c w/src/dispnew.c index 87ec83acdf3..f165c604ae9 100644 --- i/src/dispnew.c +++ w/src/dispnew.c @@ -6586,6 +6586,21 @@ init_display_interactive (void) exit (1); } + if (!NILP (Vterm_strip_prefixes)) + { + Lisp_Object prefixes = Vterm_strip_prefixes; + FOR_EACH_TAIL (prefixes) + { + char *c_prefix = SSDATA (XCAR (prefixes)); + int len = strlen (c_prefix); + if (strncmp (terminal_type, c_prefix, len) == 0) + { + terminal_type += len; + break; + } + } + } + { struct terminal *t; struct frame *f = XFRAME (selected_frame); @@ -6817,6 +6832,11 @@ syms_of_display (void) Possible values are t (below the tool bar), nil (above the tool bar). This option affects only builds where the tool bar is not external. */); + DEFVAR_LISP ("term-strip-prefixes", Vterm_strip_prefixes, + doc: /* List of prefixes to try to strip from the TERM environment variable. +This will strip the first matching prefix only. */); + Vterm_strip_prefixes = Fcons (build_string ("screen."), Qnil); + pdumper_do_now_and_after_load (syms_of_display_for_pdumper); }