unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sdt@sebyte.me, 62237@debbugs.gnu.org
Subject: bug#62237: 28.1 or higher: 24-bit true color breaks colours in Emacsen built without X under GNU Screen
Date: Sat, 18 Mar 2023 12:44:45 +0100	[thread overview]
Message-ID: <87sfe2qo5u.fsf@gmail.com> (raw)
In-Reply-To: <83r0tmbb11.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Mar 2023 12:37:30 +0200")

>>>>> On Sat, 18 Mar 2023 12:37:30 +0200, Eli Zaretskii <eliz@gnu.org> said:

    Eli> Then I guess we should install your proposed fix in init_tty.

In emacs-29? That seems a bit radical. Patch below in any case

I guess we could do something with not checking COLORTERM under screen
instead.

Robert
-- 

diff --git i/src/dispnew.c w/src/dispnew.c
index 87ec83acdf3..f165c604ae9 100644
--- i/src/dispnew.c
+++ w/src/dispnew.c
@@ -6586,6 +6586,21 @@ init_display_interactive (void)
       exit (1);
     }
 
+  if (!NILP (Vterm_strip_prefixes))
+    {
+      Lisp_Object prefixes = Vterm_strip_prefixes;
+      FOR_EACH_TAIL (prefixes)
+	{
+	  char *c_prefix = SSDATA (XCAR (prefixes));
+	  int len = strlen (c_prefix);
+	  if (strncmp (terminal_type, c_prefix, len) == 0)
+	    {
+	      terminal_type += len;
+	      break;
+	    }
+	}
+    }
+
   {
     struct terminal *t;
     struct frame *f = XFRAME (selected_frame);
@@ -6817,6 +6832,11 @@ syms_of_display (void)
 Possible values are t (below the tool bar), nil (above the tool bar).
 This option affects only builds where the tool bar is not external.  */);
 
+  DEFVAR_LISP ("term-strip-prefixes", Vterm_strip_prefixes,
+	       doc: /* List of prefixes to try to strip from the TERM environment variable.
+This will strip the first matching prefix only.  */);
+  Vterm_strip_prefixes = Fcons (build_string ("screen."), Qnil);
+
   pdumper_do_now_and_after_load (syms_of_display_for_pdumper);
 }
 






  reply	other threads:[~2023-03-18 11:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  9:41 bug#62237: 28.1 or higher: 24-bit true color breaks colours in Emacsen built without X under GNU Screen Sebastian Tennant
2023-03-17 12:15 ` Eli Zaretskii
2023-03-17 15:39   ` Robert Pluim
2023-03-17 16:30     ` Eli Zaretskii
2023-03-17 17:44       ` Robert Pluim
2023-03-17 18:55         ` Eli Zaretskii
2023-03-18  9:05           ` Robert Pluim
2023-03-18  9:09             ` Eli Zaretskii
2023-03-18 10:02               ` Robert Pluim
2023-03-18 10:37                 ` Eli Zaretskii
2023-03-18 11:44                   ` Robert Pluim [this message]
2023-03-18 13:29                     ` Eli Zaretskii
2023-03-20  8:36                       ` Robert Pluim
2023-03-20  8:57                         ` Sebastian Tennant
2023-03-20 12:17                           ` Eli Zaretskii
2023-03-20 12:15                         ` Eli Zaretskii
2023-03-20 14:08                           ` Robert Pluim
2023-03-20 14:23                             ` Eli Zaretskii
2023-03-20 14:51                               ` Robert Pluim
2023-03-20 16:26                                 ` Sebastian Tennant
2023-03-23  8:05                                 ` Eli Zaretskii
2023-03-18 10:34               ` Sebastian Tennant
2023-03-18 11:38                 ` Robert Pluim
2023-03-18 15:01                   ` Sebastian Tennant
2023-03-18 15:13                     ` Eli Zaretskii
2023-03-18 17:56                       ` Sebastian Tennant
2023-03-18 18:35                       ` Sebastian Tennant
2023-03-17 16:20   ` Sebastian Tennant
2023-03-17 16:42     ` Eli Zaretskii
2023-03-17 18:31       ` Sebastian Tennant
2023-03-17 19:02         ` Eli Zaretskii
2023-03-17 19:50           ` Eli Zaretskii
2023-03-17 20:18             ` Sebastian Tennant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfe2qo5u.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=62237@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=sdt@sebyte.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).