From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package Date: Fri, 14 Apr 2023 20:07:54 +0000 Message-ID: <87sfd2ns6d.fsf@posteo.net> References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17529"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62767@debbugs.gnu.org, eliz@gnu.org To: lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 14 22:08:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnPin-0004JE-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Apr 2023 22:08:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnPiF-000323-J0; Fri, 14 Apr 2023 16:08:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnPiE-00031n-14 for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 16:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnPiD-0003jj-Pb for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 16:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnPiD-0000sK-KM for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 16:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2023 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62767-submit@debbugs.gnu.org id=B62767.16815028533312 (code B ref 62767); Fri, 14 Apr 2023 20:08:01 +0000 Original-Received: (at 62767) by debbugs.gnu.org; 14 Apr 2023 20:07:33 +0000 Original-Received: from localhost ([127.0.0.1]:47790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnPhk-0000rK-NF for submit@debbugs.gnu.org; Fri, 14 Apr 2023 16:07:33 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:57407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnPhi-0000r4-9m for 62767@debbugs.gnu.org; Fri, 14 Apr 2023 16:07:30 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C7CFE2401F7 for <62767@debbugs.gnu.org>; Fri, 14 Apr 2023 22:07:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681502844; bh=gEg3YqnOm9/DNB3v4b6SNLsNOgj6/hEyxU8aKaC90ds=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=neRv0IB2hJoAlex4vqQE7zDwMwZuOQB9BBhCIbNLQBXkMpGzDdVNS2KJXqLPBt7Ta kYfJJun2pC2lztBniicK6h6VT1Gjlu8ZH2YAhQRlLg2Doh6GXxCPTRECKpMFFBT4dG tFDe0EypruFlAhDr+vApNRaQChavnACfX/S2mFgNR3QMODIkOtLmv/nVMPhvIxBqSY N6M04EIxr1PjulesNUCgEASivaRtYA8RTfwYTl0RMaKHMKEncZIT5cunRLKwaYGpuQ oKZyTGVoy7nzisj10gVZkOJXEzDHFh1Mzbztg3dLmzETsaV5t6ny8yVQuwcXGILIk+ tK+fenzqABPIQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PynY82LxHz6tw5; Fri, 14 Apr 2023 22:07:24 +0200 (CEST) In-Reply-To: (lin Sun's message of "Tue, 11 Apr 2023 05:15:45 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259977 Archived-At: --=-=-= Content-Type: text/plain lin Sun writes: > Hi, > > The package.el will always require the entire `info.el` on its package > activating function. > Using the `with-eval-after-load` to arrange the work can avoid the > unnecessary loading the `info` package. Note that this is not the only place where info is required. If this is an acceptable solution (which I am not sure since `with-eval-after-load' is something I usually encounter in user configurations), then we should think about consistently addressing the issue: --=-=-= Content-Type: text/plain Content-Disposition: inline 3 matches for "require 'info" in buffer: package.el : (add-to-list 'load-path (directory-file-name pkg-dir))) : ;; Add info node. : (when (file-exists-p (expand-file-name "dir" pkg-dir)) : ;; FIXME: not the friendliest, but simple. 896: (require 'info) : (info-initialize) : (add-to-list 'Info-directory-list pkg-dir)) : (push name package-activated-list) : ;; Don't return nil. ------- :(defun package-quickstart-refresh () : "(Re)Generate the `package-quickstart-file'." : (interactive) : (package-initialize 'no-activate) 4444: (require 'info) : (let ((package--quickstart-pkgs ()) : ;; Pretend we haven't activated anything yet! : (package-activated-list ()) : ;; Make sure we can load this file without load-source-file-function. ------- : package-activated-list))) : (current-buffer)) : (let ((info-dirs (butlast Info-directory-list))) : (when info-dirs 4489: (pp `(progn (require 'info) : (info-initialize) : (setq Info-directory-list : (append ',info-dirs Info-directory-list))) : (current-buffer)))) --=-=-= Content-Type: text/plain > Please help review the patch. Thanks. > > Best regards > Lin > > From 4908999eefa315cfa1a1434baf891ce98ee8d871 Mon Sep 17 00:00:00 2001 > From: Lin Sun > Date: Tue, 11 Apr 2023 00:00:13 +0000 > Subject: [PATCH] *lisp/emacs-lisp/package.el: set variables after info package > be loaded > > --- > lisp/emacs-lisp/package.el | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index f92afe56b7..bb0491e509 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -892,10 +892,9 @@ package-activate-1 > (add-to-list 'load-path (directory-file-name pkg-dir))) > ;; Add info node. > (when (file-exists-p (expand-file-name "dir" pkg-dir)) > - ;; FIXME: not the friendliest, but simple. > - (require 'info) > - (info-initialize) > - (add-to-list 'Info-directory-list pkg-dir)) > + (with-eval-after-load 'info > + (info-initialize) > + (add-to-list 'Info-directory-list pkg-dir))) > (push name package-activated-list) > ;; Don't return nil. > t))) --=-=-=--