From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63337: [PATCH] package-vc--build-documentation: Fix relative @include statements Date: Sun, 07 May 2023 19:19:43 +0000 Message-ID: <87sfc8gd9s.fsf@posteo.net> References: <87fs89qg9y.fsf@breatheoutbreathe.in> <87cz3cea4k.fsf@posteo.net> <87pm7c7zfs.fsf@breatheoutbreathe.in> <83zg6gc5yp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18100"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63337@debbugs.gnu.org, Joseph Turner To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 21:20:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvjvc-0004WX-DB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 21:20:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvjvS-0003Fe-GS; Sun, 07 May 2023 15:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvjvQ-0003FP-HN for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 15:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvjvO-0002EW-IK for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 15:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvjvO-0001E9-DV for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63337-submit@debbugs.gnu.org id=B63337.16834871924697 (code B ref 63337); Sun, 07 May 2023 19:20:02 +0000 Original-Received: (at 63337) by debbugs.gnu.org; 7 May 2023 19:19:52 +0000 Original-Received: from localhost ([127.0.0.1]:38524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvjvE-0001Dh-IG for submit@debbugs.gnu.org; Sun, 07 May 2023 15:19:52 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:49699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvjvD-0001DS-AG for 63337@debbugs.gnu.org; Sun, 07 May 2023 15:19:52 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 71E3124017F for <63337@debbugs.gnu.org>; Sun, 7 May 2023 21:19:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683487185; bh=+QsxMS4o9JiyW1p5kyXkgg1zer+EN1HhBMignovghRw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=UWZ1tDvLjlzlOx5eSyXf0HYRT2s9WHju+7d4jTvSlyvZ4F0kOItM/lYASfRq7ifuF VF389ziPMNNSioqSAu29ANpJgv2F75iuQ3LADPseUnVVLUSSNkmguIQL9ASigRjhoO cDqPcSciAmuSHWP8GJRltKd0ZSLZpYC6lolJqNjzo+J8ztC2my95Ix6+yWQB/YEtSs M8TjzLE+7WYq7hvrrzaL9f6DohRr4O8sD821q6+ReDMU1i20n8WLdzp264/ZiRetHE 0dxiJmrUMdEuJWUfEZwwc/eK12ub8z4sI/NiAdhozt7ZDe/O6tqzytqgII03nR4xm/ 0uzyOEejvkseg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDvPX4nx4z9rxL; Sun, 7 May 2023 21:19:44 +0200 (CEST) In-Reply-To: <83zg6gc5yp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 May 2023 22:11:10 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261275 Archived-At: Eli Zaretskii writes: >> Cc: 63337@debbugs.gnu.org >> Date: Sun, 07 May 2023 11:40:46 -0700 >> From: Joseph Turner via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > According to the docs, makeinfo has -I to append the search path, and -P >> > to prepend. I don't know how well either of the two are supported, but >> > assuming they are, shouldn't -P be preferred? Or wouldn't it have any >> > effect? >> >> I am not sure what difference it would make. I don't know if the default >> @include search path includes anything besides the working directory. I don't know that either, and I can imagine that certain versions of makeinfo might be patched or this could change in the future. > It doesn't, according to the Texinfo manual. Only the current > directory is searched. > >> In the attached diff, I have changed -I to -P. > > I think it's a mistake: the current directory should searched first. > So -I is better. What do we mean by the current directory? When building the manual from an org-file, we switch to a temporary directory (where the .org -> .texi conversion is stored), so the "actual" directory is not the same as the default-directory.