From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ] Date: Wed, 17 May 2023 16:07:16 +0200 Message-ID: <87sfbvuk4r.fsf@gmx.de> References: <877ct8w4bs.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63539@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 17 16:08:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzHp7-0000SA-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 May 2023 16:08:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzHoz-0003Gb-1y; Wed, 17 May 2023 10:08:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzHow-0003Ff-QB for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 10:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzHow-0002f6-C8 for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 10:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzHow-0002HD-8L for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63539 X-GNU-PR-Package: emacs Original-Received: via spool by 63539-submit@debbugs.gnu.org id=B63539.16843324468687 (code B ref 63539); Wed, 17 May 2023 14:08:02 +0000 Original-Received: (at 63539) by debbugs.gnu.org; 17 May 2023 14:07:26 +0000 Original-Received: from localhost ([127.0.0.1]:50546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzHoM-0002G2-9f for submit@debbugs.gnu.org; Wed, 17 May 2023 10:07:26 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:44979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzHoK-0002Fi-Bi for 63539@debbugs.gnu.org; Wed, 17 May 2023 10:07:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1684332437; i=michael.albinus@gmx.de; bh=+st6SxWZd94YzJ4JxvBc030GZnWc6vua+g+nfBnicFI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ZNNsyo/aSjNnJMLw2RuTw/hfyiGP+fbKHuMNMglq9U3U3LD9io+qr6UMV2orjW6Je c/Y4EHyGGdlYxieWxK+JwiIkPr57l1njo9aDTNodlREnQUhWxJEqPJpKtNJD1b0x5+ A9bqHKui8KkeOu43R/s545TKGE4lFo1AujZURRrx6FG3kUHDPWj1hpYlyGZOW4jbCO tAqSuMxgG+AJjpT1UHhvX+DbntrSjksmvuELAuiMhFyx89yEV6AyuqO3dQ1pagwB60 8i+rvrXa1J19QRktkdrWDU/ZcMuAqRbsAw5rYOh6fiWsLg4OgDjjvvT1xCz5lAGGGJ JEF4f6cPTGz1w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.13]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N0XCw-1qJxNw3nwS-00wTFV; Wed, 17 May 2023 16:07:16 +0200 In-Reply-To: (Spencer Baugh's message of "Tue, 16 May 2023 16:06:42 -0400") X-Provags-ID: V03:K1:0ieh0Z5ZYkV75eFEZ8tw3m3rbmCwwU+R+IGdbZIY2tNuqJkP9xb 2VMvXYnk92Ws/vJzzMz6ZuXYqyiMbVzo/jqtgdXs/4/HsAhuWKu1OGQTNhZqXzsULuZlhbk IwsXaL+/R2AvnA0N5Ar0Ot5llFS0vZ3MlooissZi60omtTKG4G1HuzKCkSoAVNxxe003Jwe PYdcrrLujsFZRRUAv+7SA== UI-OutboundReport: notjunk:1;M01:P0:MAB/Ypg9jzg=;mvfpFn7r8/iaRSbHMyluk5rmJn3 UlRu4NyoaSsT5SZAUGPHquyF6RJy3v+ftmDVmUtDkl08vmXORl7E6dGq4lf0ExSm/N76hePH5 rGLnYMpA/t84IAMLi0b/a7LEq/GJtzlToMg7RbfYMhR5ZKIvJPSRb/J/A8LCZo8VVDZyK4/D0 gRCnyOMkYPMzhXOjj26UBqsppSrsubovCGj/A+tm/3YzBc7gmNfINTfpm4/teJgHY4xLQ4F8X Mrz40vpd8YHlPV+hR9hfQyAjhWxlE81ftJZpi2goScTAU+hNz1qWfoxhvgQHpxIsnhHGOz1+W xXyYHU7GRt07gMPdOvTcqQSDenxDOauvJLTf+jlSeUQt4iB2xQZqOBzzTWRJDBLq4eBuU8vb7 xBhlT0Xj0hU6OGTayJ8ZvynKX9csyI9mW5eo2Wl6GGW5cF/gkGMzDL3P6rqhcVIeO/hwwydeQ Lcz93i9SlM1yTpEKWbvaJ16rZ5+LKxRKusvdMSPQEJ3YL49z/F3DBttX5wm8yQ52Gaf0AfRjC WkmKupVN2I8qx0gA2OeGLxsAYde3p7LtS+yGSOCsP2sXYKzwj5QF8eu6xcf5o3c+m0OelqWtW 1otii8M/kJtMTdP9FngUgxzabd1SYtNURQeh1riP/h6AACwHym7P4Tu0SNHKTRk181cM6bcNH s4tjQckJqVZQTb1Oj1L1AeRlwFkVI+m8ajBfaZx5Tx0ZiWUAlKYAweOntn/ifnLkheU0d1FKm lPtMPYXsF/lH99iH/KqxP8HQ3SKDSL6HyiYIK16oLgMUBoxPUmcAirxtwy75LLvPP2XtT0Mr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261854 Archived-At: Spencer Baugh writes: Hi Spencer, >> Just as an additional point, I'm not always connecting to hosts that I >> can trivially change the .profile for. > > The RHEL (and Fedora maybe?) prompt by default contains []. It looks > like: > > [sbaugh@hostname ~]$ > > TRAMP connections to RHEL seems *pretty* important to support by > default. > > TRAMP is only working on such hosts today because of the fallback to > shell-prompt-pattern, which doesn't treat [] as a prompt character. This kind of shell prompt is supported. I'm running Fedora myself, so I know it. > But such machines' prompts stop working if they add color, which > shell-prompt-pattern also doesn't support (namely that regex doesn't > support escape sequences appearing after the prompt, which are necessary > to clear the coloring). > > So actually, how about setting shell-prompt-pattern to the following? > All it does is add support for escape characters after the prompt in > shell-prompt-pattern. That would make my use case work. > > (setopt shell-prompt-pattern (rx (* (not (any "#$%>\n"))) > (any "#$%>") > (* blank) > ;; Escape characters. > (* "^[[" (* (any ";" digit)) alpha (* blank)))) Oh no! There are much more escape sequences but for coloring. We would open a can of worms if we start to handle them in Tramp regexps. What we could try is to remove such escape sequences by a function like `ansi-color-filter-region' and/or `ansi-osc-filter-region', before checking for a shell prompt. Patches to Tramp welcome! Best regards, Michael.