From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Thu, 01 Jun 2023 18:34:53 +0200 Message-ID: <87sfbb9m4y.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <83lehbjdjd.fsf@gnu.org> <87wn0vkqn1.fsf@gmail.com> <83jzwvj94x.fsf@gnu.org> <87h6rw8y82.fsf@gmail.com> <83353gipww.fsf@gnu.org> <87edmzto0l.fsf@gmail.com> <83ilcbgrxo.fsf@gnu.org> <87zg5nb3m3.fsf@gmail.com> <83bki3gpai.fsf@gnu.org> <87sfbfazfp.fsf@gmail.com> <837csrgioe.fsf@gnu.org> <87jzwqb7r3.fsf@gmail.com> <83ttvuf29m.fsf@gnu.org> <87a5xmaqul.fsf@gmail.com> <83r0qxg4q0.fsf@gnu.org> <875y88bhvr.fsf@gmail.com> <83ilc8eapd.fsf@gnu.org> <83edmvcpzl.fsf@gnu.org> <87wn0n9uol.fsf@gmail.com> <83a5xjcgev.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 01 18:36:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4lHh-0004oi-Cp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jun 2023 18:36:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4lHQ-0007Vs-NP; Thu, 01 Jun 2023 12:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4lHO-0007Py-Rj for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2023 12:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4lHO-00087F-HI for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2023 12:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q4lHO-0001y9-1n for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2023 12:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jun 2023 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.16856373047457 (code B ref 63731); Thu, 01 Jun 2023 16:36:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 1 Jun 2023 16:35:04 +0000 Original-Received: from localhost ([127.0.0.1]:38402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4lGR-0001wA-T7 for submit@debbugs.gnu.org; Thu, 01 Jun 2023 12:35:04 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:52706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4lGP-0001vT-Bi for 63731@debbugs.gnu.org; Thu, 01 Jun 2023 12:35:03 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-3f6042d610fso10542095e9.1 for <63731@debbugs.gnu.org>; Thu, 01 Jun 2023 09:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685637295; x=1688229295; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=olexrzSYESWLgtjOTYa8aO8Hy1X+SJBl1tCiM2bA6RA=; b=Xjm1yW2m1Q/Ho7eZduOlZ2bDhk01CwBQYQHmsyNm0ItNVa2HRaBxsIp+fUO98CjHB6 zriKMnC6S+T+3Inu+yVlZR/+oz34pySfISzifMJazTxBaC+ONRunNCNbyPCp64PmydjY kN2dsPeMABtx9EnBTzLK3Ih8Is7v2kOXPsqi/o0cSEL588j90J8y1BmQJW5GrVbtD23P 27SgyOp15+U3dr1l/GTUFsDKJttRVsiCMdBHE/DTHc5nouy7IAgrp5Lvr9TtJSMJNjXL 3obETCKba9aATaB9ZvsCIC7qZHI9daysWIxQgVoKy5nMbDOWZ6u+SptVVL1BwBS4tWQj yjAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685637295; x=1688229295; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=olexrzSYESWLgtjOTYa8aO8Hy1X+SJBl1tCiM2bA6RA=; b=GAmF2F2+W2lgdm31RuctrNfrDsC9GuzycjY4c9xNEtVfRD0ZUC6k0BmfaS3bp6CWO2 KJsdSIvdhyEPoZI/q/m9lbbQY98tG4pzF4AgzfJEHyaRsDrsxGRO023o4zJ7uxej/ri/ +4/QpYjBPb5QZCPrfrzskieskxytYATRdlY09YXlI5ybsR86mNaaAfUojuJQaLgWCdCU GVoH2HO4YwUQh2iO8z/GLbJxWsGwSmIAie7p8v+N4N57/kzmhTwJtHXwkn5YBwx5rT99 SInZmUA3Bf4XXzm6U5ghD4OYLFkbGDlhDs6EaZVvcVL1CTJowZj3/lfDRvp+6YDmnwtb Qiuw== X-Gm-Message-State: AC+VfDzj11gcJ+nEPHk7YxWMGN/Z1dzoUnPf5hbFy/vQHHiJz07rzfPx cT0eizzSa+cJ2tmTUz8uhTw= X-Google-Smtp-Source: ACHHUZ5OB1bOl7ffmFhrkDYizuzklJ668alogTayBBT0vLQ8aouLN6OZzNrOjgz6Z1n44yV35hMsEQ== X-Received: by 2002:a05:600c:404:b0:3f6:da2:bc86 with SMTP id q4-20020a05600c040400b003f60da2bc86mr2633383wmb.7.1685637294987; Thu, 01 Jun 2023 09:34:54 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id f1-20020a1c6a01000000b003f423508c6bsm2896589wmc.44.2023.06.01.09.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 09:34:54 -0700 (PDT) In-Reply-To: <83a5xjcgev.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Jun 2023 19:10:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262712 Archived-At: >>>>> On Thu, 01 Jun 2023 19:10:16 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 63731@debbugs.gnu.org, steven@stebalien.com >> Date: Thu, 01 Jun 2023 15:30:18 +0200 >>=20 Eli> OK, the issue is quite clear even without stepping with a debugger. >>=20 Eli> Bottom line: we cannot support a situation where the same character Eli> can be composed by more than one slot in composition-function-tabl= e. Eli> If there are more than a single slot for the same character, one of Eli> them will be tried, and the rest will be ignored (not even tried). Eli> In particular, if a character CH has a "forward" composition rule = that Eli> starts with itself, and also has a "backward" rule (one with non-z= ero Eli> look-back parameter) triggered by a different character (which sho= uld Eli> follow CH), the latter rule will never be tried. >>=20 >> OK, that makes sense. Where would be a good place to document this? Eli> In the doc string of composition-function-table, I think. We alre= ady Eli> document there the caveat of arranging rules in descending order of Eli> look-back, which is part of the same "misfeature". OK. I=CA=BCll see if I can come up with something (or I=CA=BCll just steal = what you wrote above :-)). >> That makes all the VS-16 sequences in >> admin/unidata/emoji-variation-sequences.txt display with the emoji >> font for me. Eli> Ready to install this on the emacs-29 branch? Not today. My brain is fuzzy, and it needs more testing (the patch, not my brain). >> If find-composition DTRT, could we not use it in the display engine? Eli> Not easily, because the display code calls subroutines of Eli> find-composition in a certain order, and that's what causes the Eli> behavior I described. Eli> And even if we could make this happen, I'm not sure we should: Eli> basically, having multiple matching slots would mean users and cal= lers Eli> will never be sure which one "wins". Yes, at least the semantics are clear (now that we know what they are). Robert --=20